Merge lp:~verifydtapn-contributers/verifydtapn/3.1MissingParentFix into lp:verifydtapn

Proposed by Peter Gjøl Jensen
Status: Merged
Merged at revision: 308
Proposed branch: lp:~verifydtapn-contributers/verifydtapn/3.1MissingParentFix
Merge into: lp:verifydtapn
Diff against target: 11 lines (+0/-1)
1 file modified
src/DiscreteVerification/VerificationTypes/LivenessSearch.hpp (+0/-1)
To merge this branch: bzr merge lp:~verifydtapn-contributers/verifydtapn/3.1MissingParentFix
Reviewer Review Type Date Requested Status
Jiri Srba Approve
Mathias Grund Sørensen Pending
Jakob Taankvist Pending
Review via email: mp+224029@code.launchpad.net

Commit message

Redefinition of class member for temporary storage of parent marking makes the behaviour unspecified.
The class member in the successor generator is never set, setting the parent of all markings to become the initial, unspecified value, which is a pointer to a random memory address.

Description of the change

Redefinition of class member for temporary storage of parent marking makes the behaviour unspecified.
The class member in the successor generator is never set, setting the parent of all markings to become the initial, unspecified value, which is a pointer to a random memory address.

To post a comment you must log in.
Revision history for this message
Jiri Srba (srba) wrote :

The problem on linux is fixed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/DiscreteVerification/VerificationTypes/LivenessSearch.hpp'
2--- src/DiscreteVerification/VerificationTypes/LivenessSearch.hpp 2014-03-11 20:25:13 +0000
3+++ src/DiscreteVerification/VerificationTypes/LivenessSearch.hpp 2014-06-21 18:10:15 +0000
4@@ -47,7 +47,6 @@
5 void getTrace();
6 protected:
7 int validChildren;
8- NonStrictMarking* tmpParent;
9 };
10
11 class LivenessSearchPTrie : public LivenessSearch {

Subscribers

People subscribed via source and target branches