Ubuntu
jsch package

Code review comment for lp:~veger/ubuntu/quantal/jsch/fix-for-803492-v2

  1. Quantal (12.10)
  2. fix-for-803492-v2
  3. Merge into quantal
Revision history for this message
James Page (james-page) wrote :

Hi Maarten

Thanks for preparing this update; I have two bits of feedback

1) The Merge proposal looks a little odd (removal of files in the .pc directory) because you have not applied all patched and added the .pc directory. This is a little counter intuitive but makes it easier to review

2) d/manifest.mf needed an update as well for the new version.

I've fixed both of these issues and uploaded - thanks for your contribution!

Cheers

James

review: Approve

« Back to merge proposal