Merge lp:~veebers/sloecode/yui-menu into lp:sloecode
Proposed by
Thomi Richards
Status: | Merged |
---|---|
Merged at revision: | 43 |
Proposed branch: | lp:~veebers/sloecode/yui-menu |
Merge into: | lp:sloecode |
Diff against target: |
280 lines (+184/-32) 4 files modified
sloecode/controllers/person.py (+6/-6) sloecode/lib/helpers.py (+1/-1) sloecode/templates/base.html (+4/-2) sloecode/templates/macros/nav.html (+173/-23) |
To merge this branch: | bzr merge lp:~veebers/sloecode/yui-menu |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards | Pending | ||
Review via email:
|
To post a comment you must log in.
A few tweaks that I think are worth doing:
* Once logged in as admin, the 'Admin' menu has a menu entry called "Manage Sloecode" that always seems to point to the current page, and does nothing.
* We should get rid of the "Manage Projects" and "Manage Users" pages. Remove the links and delete the template files. These pages are there as temporary navigation, and were never destined to stick around long term.
* Given the above point, there will on;y be two entries in each submenu of the "admin" main menu. is it worth having a sub menu at all? Maybe, maybe not. I leave that to your discretion. It *might* be better to just have all four links under the 'Admin' menu.
Other than that, it looks great!