Merge lp:~veebers/juju-ci-tools/perfscale_add_mass_model_destruction into lp:juju-ci-tools

[Christopher Lee]

Add perfscale test that adds a lot of models (default 1000) and then destroys them, monitoring system metrics through out.

A relatively simple test. Takes about 2.5 hours. Demonstrates mongodb memory usage climbing to a peak.

[Curtis Hovey (sinzui)]

I have some questions inline.

review: Needs Information (code)

[lp:~veebers/juju-ci-tools/perfscale_add_mass_model_destruction]

1661. By Christopher Lee on 2016-10-20

Add missing tests.

1662. By Christopher Lee on 2016-10-20

Remove use of wait_for_started.

[Christopher Lee (veebers)]

Thanks Curtis. I have added the missing tests as you pointed out. I also removed wait_for_started as it wasn't needed.

[Curtis Hovey (sinzui)]

Thank you.

review: Approve (code)

=== added file 'perfscale_mass_model_destruction.py'
--- perfscale_mass_model_destruction.py	1970-01-01 00:00:00 +0000
+++ perfscale_mass_model_destruction.py	2016-10-20 22:49:23 +0000
@@ -0,0 +1,84 @@
+#!/usr/bin/env python
+"""Perfscale test measuring adding and destroying a large number of models.
+
+Steps taken in this test:
+  - Bootstraps a provider
+  - Creates x amount of models and waits for them to be ready
+  - Delete all the models at once.
+"""
+
+import argparse
+from datetime import datetime
+import logging
+import sys
+from time import sleep
+
+from deploy_stack import (
+    BootstrapManager,
+)
+from generate_perfscale_results import (
+    DeployDetails,
+    TimingData,
+    run_perfscale_test,
+)
+from utility import (
+    add_basic_testing_arguments,
+    configure_logging,
+)
+
+
+log = logging.getLogger("perfscale_mass_model_destruction")
+
+__metaclass__ = type
+
+
+def perfscale_assess_model_destruction(client, args):
+    """Create a bunch of models and then destroy them all."""
+    model_count = args.model_count
+
+    all_models = []
+    for item in xrange(0, model_count):
+        model_name = 'model{}'.format(item)
+        log.info('Creating model: {}'.format(model_name))
+        new_model = client.add_model(client.env.clone(model_name))
+        all_models.append(new_model)
+
+    # Workaround for bug: https://bugs.launchpad.net/juju/+bug/1635052
+    # Noted here: https://bugs.launchpad.net/juju-ci-tools/+bug/1635109
+    sleep(10)
+    destruction_start = datetime.utcnow()
+    for doomed in all_models:
+        doomed.destroy_model()
+    destruction_end = datetime.utcnow()
+
+    destruction_timing = TimingData(destruction_start, destruction_end)
+    return DeployDetails(
+        'Destroy {} models'.format(model_count),
+        {'Model Count': model_count},
+        destruction_timing)
+
+
+def parse_args(argv):
+    """Parse all arguments."""
+    parser = argparse.ArgumentParser(
+        description="Perfscale bundle deployment test.")
+    add_basic_testing_arguments(parser)
+    parser.add_argument(
+        '--model-count',
+        type=int,
+        help='Number of models to create.',
+        default=100)
+    return parser.parse_args(argv)
+
+
+def main(argv=None):
+    args = parse_args(argv)
+    configure_logging(args.verbose)
+    bs_manager = BootstrapManager.from_args(args)
+    run_perfscale_test(perfscale_assess_model_destruction, bs_manager, args)
+
+    return 0
+
+
+if __name__ == '__main__':
+    sys.exit(main())

=== added file 'tests/test_perfscale_mass_model_destruction.py'
--- tests/test_perfscale_mass_model_destruction.py	1970-01-01 00:00:00 +0000
+++ tests/test_perfscale_mass_model_destruction.py	2016-10-20 22:49:23 +0000
@@ -0,0 +1,87 @@
+"""Tests for perfscale_mass_model_desctruction"""
+
+import argparse
+from mock import patch, Mock
+
+import perfscale_mass_model_destruction as pmmd
+from generate_perfscale_results import DeployDetails
+from fakejuju import fake_juju_client
+from tests import (
+    TestCase
+)
+from utility import temp_dir
+
+
+def get_default_args(model_count=100, log_dir='/tmp/logs'):
+    return argparse.Namespace(
+        env='an-env',
+        juju_bin='/bin/juju',
+        logs=log_dir,
+        temp_env_name='an-env-mod',
+        model_count=model_count,
+        debug=False,
+        agent_stream=None,
+        agent_url=None,
+        bootstrap_host=None,
+        keep_env=False,
+        machine=[],
+        region=None,
+        series=None,
+        upload_tools=False,
+        verbose=20,
+        deadline=None,
+    )
+
+
+class TestPerfscaleAssessModelDestruction(TestCase):
+
+    def test_returns_DeployDetails(self):
+        client = fake_juju_client()
+        client.bootstrap()
+
+        args = argparse.Namespace(model_count=1)
+
+        with patch.object(pmmd, 'sleep', autospec=True):
+            results = pmmd.perfscale_assess_model_destruction(client, args)
+        self.assertIsInstance(results, DeployDetails)
+
+    def test_returns_creates_requested_model_amount(self):
+        client = fake_juju_client()
+        client.bootstrap()
+
+        args = argparse.Namespace(model_count=12)
+
+        with patch.object(pmmd, 'sleep', autospec=True):
+            results = pmmd.perfscale_assess_model_destruction(client, args)
+        self.assertEqual(results.applications['Model Count'], 12)
+
+
+class TestParseArgs(TestCase):
+
+    def test_default_args(self):
+        expected_args = get_default_args(model_count=42)
+        self.assertEqual(
+            expected_args,
+            pmmd.parse_args(
+                ['an-env',
+                 '/bin/juju',
+                 '/tmp/logs',
+                 'an-env-mod',
+                 '--model-count',
+                 '42']))
+
+
+class TestMain(TestCase):
+
+    def test_main(self):
+        with temp_dir() as log_dir:
+            argv = ['an-env', '/bin/juju', log_dir, 'an-env-mod']
+            bs_manager = Mock()
+            with patch.object(pmmd, 'run_perfscale_test') as mock_run_pt:
+                with patch.object(pmmd.BootstrapManager, 'from_args',
+                                  return_value=bs_manager):
+                    pmmd.main(argv)
+            mock_run_pt.assert_called_once_with(
+                pmmd.perfscale_assess_model_destruction,
+                bs_manager,
+                get_default_args(log_dir=log_dir))