Merge lp:~veebers/autopilot/revert-ext-class-fix-for-now into lp:autopilot

Proposed by Christopher Lee on 2015-02-26
Status: Merged
Approved by: Christopher Lee on 2015-02-26
Approved revision: 544
Merged at revision: 543
Proposed branch: lp:~veebers/autopilot/revert-ext-class-fix-for-now
Merge into: lp:autopilot
Diff against target: 34 lines (+2/-4)
2 files modified
autopilot/introspection/_object_registry.py (+0/-3)
autopilot/tests/functional/test_introspection_features.py (+2/-1)
To merge this branch: bzr merge lp:~veebers/autopilot/revert-ext-class-fix-for-now
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-02-26
Thomi Richards (community) 2015-02-26 Approve on 2015-02-26
Review via email: mp+251025@code.launchpad.net

Commit Message

Revert previous fix to unblock landing of other fixes and documentation updates.

Description of the Change

Revert previous fix to unblock landing of other fixes and documentation updates.

To post a comment you must log in.
Thomi Richards (thomir) wrote :

I disagree with the motive, but can't argue with the implementation :D

review: Approve
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/introspection/_object_registry.py'
2--- autopilot/introspection/_object_registry.py 2015-01-19 23:10:49 +0000
3+++ autopilot/introspection/_object_registry.py 2015-02-26 00:42:54 +0000
4@@ -173,9 +173,6 @@
5 )
6 )
7 if len(possible_classes) == 1:
8- extended_proxy_bases = _get_proxy_bases_for_id(object_id)
9- if extended_proxy_bases:
10- possible_classes[0].__bases__ = extended_proxy_bases
11 return possible_classes[0]
12 return None
13
14
15=== modified file 'autopilot/tests/functional/test_introspection_features.py'
16--- autopilot/tests/functional/test_introspection_features.py 2014-07-31 04:46:16 +0000
17+++ autopilot/tests/functional/test_introspection_features.py 2015-02-26 00:42:54 +0000
18@@ -24,7 +24,7 @@
19 import subprocess
20 import tempfile
21 from tempfile import mktemp
22-from testtools import skipIf
23+from testtools import skip, skipIf
24 from testtools.matchers import (
25 Contains,
26 Equals,
27@@ -99,6 +99,7 @@
28 Equals(WindowMockerApp)
29 )
30
31+ @skip("Currently fails due to lp:1425721 (and lp:1376996)")
32 def test_customised_proxy_classes_have_extension_classes(self):
33 class WindowMockerApp(EmulatorBase):
34 @classmethod

Subscribers

People subscribed via source and target branches