Merge into trunk : fix-1328600-large-datetime : Code : Autopilot

Reviewer	Review Type	Date Requested	Status
Nicholas Skaggs (community)			Approve on 2014-10-22
PS Jenkins bot	continuous-integration	2014-10-02	Needs Fixing on 2014-10-17
Thomi Richards (community)		2014-10-02	Needs Fixing on 2014-10-16
Robert Bruce Park		2014-10-02	Pending
Barry Warsaw		2014-10-02	Pending
Christopher Lee			Pending
Review via email: mp+236815@code.launchpad.net

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-18: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/804/rebuild

review: Approve (continuous-integration)

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2014-07-21: Posted in a previous version of this proposal

#

This doesn't actually fix the problem, it just creates new problems. Please see my comment on the bug report:

https://bugs.launchpad.net/ubuntu-calendar-app/+bug/1328600/comments/9

Thanks for the patch though, but it looks like this is going to be a bit more of an involved fix.

Cheers,

review: Disapprove

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-07-22: Posted in a previous version of this proposal

#

So the idea of using tzlocal seems to suffer from daylight savings problem, unless I'm missing something.

>>> from datetime import datetime, time, timedelta
>>> from dateutil.tz import tzlocal, tzutc
>>> print(datetime.fromtimestamp(1377209927))
2013-08-22 18:18:47
>>> print(datetime.fromtimestamp(1377209927,tzutc()))
2013-08-22 22:18:47+00:00
>>> naive = datetime.fromtimestamp(0) + timedelta(seconds=1377209927)
>>> print(naive)
2013-08-22 17:18:47
>>> aware = naive.replace(tzinfo=tzlocal())
>>> print(aware)
2013-08-22 17:18:47-04:00
>>> print(aware.astimezone(tzutc()))
2013-08-22 21:18:47+00:00
>>> aware2 = datetime.fromtimestamp(0, tzlocal())
>>> print(aware2)
1969-12-31 19:00:00-05:00
>>> print(aware2.astimezone(tzutc()))
1970-01-01 00:00:00+00:00
>>> try2 = aware2 + timedelta(seconds=1377209927)
>>> print(try2)
2013-08-22 17:18:47-04:00
>>> print(try2.astimezone(tzutc()))
2013-08-22 21:18:47+00:00

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-07-22: Posted in a previous version of this proposal

#

Going to grab the local offset at the time of the timestamp and apply it against the fromtimestamp date.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:511
http://jenkins.qa.ubuntu.com/job/autopilot-ci/815/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/90/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/89/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/89/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/231/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2154/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/815/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:512
http://jenkins.qa.ubuntu.com/job/autopilot-ci/817/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/92/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/91/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/91/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/233/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2156/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/817/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:513
http://jenkins.qa.ubuntu.com/job/autopilot-ci/819/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/94
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/94/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/93/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/93/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/235/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic-autopilot/289/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2160
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2160/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/819/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:512
http://jenkins.qa.ubuntu.com/job/autopilot-ci/818/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/93/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/92/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/92/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/234/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2158/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/818/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2014-07-22: Posted in a previous version of this proposal

#

I have a couple of comments in the diff.

Overall, this looks excellent - thank you for taking this on.

There's one change I'd like you to make in the tests, and I'd really like Barry Warsaw to review the implementation.

I'm setting this to approve, so you don't need a re-review once those two things have happeend (I trust ya :D )

review: Approve

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2014-07-22: Posted in a previous version of this proposal

#

Oh, also, CI has to pass (obviously)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/823/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:513
http://jenkins.qa.ubuntu.com/job/autopilot-ci/821/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/96
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/96/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/95/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/95/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/237/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic-autopilot/291/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2163
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2163/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/821/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:513
http://jenkins.qa.ubuntu.com/job/autopilot-ci/822/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/97
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/97/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/96/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/96/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/238/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic-autopilot/292/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2165
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2165/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/822/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-22: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/824/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-07-22: Posted in a previous version of this proposal

#

Tests don't want to run now?

/var/local/autopilot/setup.log: I: Running autopilot
/var/local/autopilot/setup.log: I: Using python2
tail: '/var/lib/lxc//utopic-amd64-20140619-0752/run/delta//var/local/autopilot/autopilot.log' has become accessible
/var/local/autopilot/autopilot.log: Loading tests from: /usr/lib/python2.7/dist-packages
/var/local/autopilot/autopilot.log:
/var/local/autopilot/autopilot.log: Did not find any tests
/var/local/autopilot/autopilot.log:
/var/local/autopilot/autopilot.log: ----------------------------------------------------------------------
/var/local/autopilot/autopilot.log: Ran 0 tests in 0.126s
/var/local/autopilot/autopilot.log:
/var/local/autopilot/autopilot.log: OK
/var/local/autopilot/setup.log: I: Using python3
tail: /var/lib/lxc//utopic-amd64-20140619-0752/run/delta//var/local/autopilot/autopilot.log: file truncated
/var/local/autopilot/autopilot.log:
/var/local/autopilot/autopilot.log: ----------------------------------------------------------------------
/var/local/autopilot/autopilot.log: Ran 0 tests in 0.110s
/var/local/autopilot/autopilot.log:
/var/local/autopilot/autopilot.log: OK
/var/local/autopilot/setup.log: I: No test left to run

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-23: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:514
http://jenkins.qa.ubuntu.com/job/autopilot-ci/826/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/101/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/100/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/100/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/243/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2173/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/826/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-01: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/839/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:515
http://jenkins.qa.ubuntu.com/job/autopilot-ci/842/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/117/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/116/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/116/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/278/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3039/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/842/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-13: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:509
http://jenkins.qa.ubuntu.com/job/autopilot-ci/843/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/118/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/117/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/117/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/279/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3040/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/843/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:516
http://jenkins.qa.ubuntu.com/job/autopilot-ci/844/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/119/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/118/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/118/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/280/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3071/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/844/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:522
http://jenkins.qa.ubuntu.com/job/autopilot-ci/845/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/120/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/119/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/119/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/281/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3092/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/845/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-14: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/846/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-15: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:524
http://jenkins.qa.ubuntu.com/job/autopilot-ci/847/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/122/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/121/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/283/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3096/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/847/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-15: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:525
http://jenkins.qa.ubuntu.com/job/autopilot-ci/848/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/123/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/122/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/122/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/284/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3097/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/848/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-28: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/851/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-28: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/852/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-28: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/853/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-29: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/854/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-08-29: Posted in a previous version of this proposal

#

Why is this running 0 tests?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-29: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:531
http://jenkins.qa.ubuntu.com/job/autopilot-ci/855/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/130/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/129/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/129/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/292/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3508/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/855/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-08-29: Posted in a previous version of this proposal

#

I see a crash:

PythonArgs: ['/usr/sbin/aa-status']
Traceback:
Traceback (most recent call last):
   File "/usr/sbin/aa-status", line 194, in <module>
     commands[cmd]()
   File "/usr/sbin/aa-status", line 17, in cmd_enabled
     if get_profiles() == {}:
   File "/usr/sbin/aa-status", line 92, in get_profiles
     for p in open(apparmor_profiles).readlines():
PermissionError: [Errno 13] Permission denied: '/sys/kernel/security/apparmor/profiles'

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-08-29: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/856/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-02: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/857/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-04: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/859/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-04: Posted in a previous version of this proposal

#

FAILED: Continuous integration, rev:533
http://jenkins.qa.ubuntu.com/job/autopilot-ci/860/
Executed test runs:
    None: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/135/console
    None: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/134/console
    None: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/297/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/860/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-09-04: Posted in a previous version of this proposal

#

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/autopilot/tests/functional/test_types.py", line 28, in test_date
    datetime(2014, 1, 1, 0, 0, 0)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 338, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 423, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: DateTime(2014-01-01 00:00:00) != datetime.datetime(2014, 1, 1, 0, 0)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-04: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/861/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Christopher Lee (veebers) wrote on 2014-09-08: Posted in a previous version of this proposal

#

A couple of minor indent issues. Deeper review to come.

review: Needs Fixing

Revision history for this message

Robert Bruce Park (robru) wrote on 2014-09-08: Posted in a previous version of this proposal

#

Packaging looks good, thanks for the wrap-and-sort, makes for a noisy diff now but easier to read later.

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-08: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/865/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-09: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/866/rebuild

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-09-09: Posted in a previous version of this proposal

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/867/rebuild

review: Approve (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-09-18: Posted in a previous version of this proposal

#

Can you provide an update on what you'd like to see with mp?

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-02:

#

FAILED: Continuous integration, rev:541
http://jenkins.qa.ubuntu.com/job/autopilot-ci/876/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/151/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/150/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/150/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/314/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4198/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/876/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-02

542. By Christopher Lee on 2014-10-02: Commented out part of test to explore failure.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-02:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/877/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-06

543. By Christopher Lee on 2014-10-06: Avoid use of calls that use fromtimestamp (or _isdst) as they aren't large timestamp safe.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-06:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/878/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-06

544. By Christopher Lee on 2014-10-06: Fix creation of localtime + re-added test.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-06:

#

FAILED: Continuous integration, rev:544
http://jenkins.qa.ubuntu.com/job/autopilot-ci/883/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/158/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/157/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/157/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/321/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4272/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/883/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-07

545. By Christopher Lee on 2014-10-06: Removed unneeded check
546. By Christopher Lee on 2014-10-06: Cleanup tz setting in functional test.
547. By Christopher Lee on 2014-10-07: WIP comments for working out the DST applications.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-07:

#

FAILED: Continuous integration, rev:547
http://jenkins.qa.ubuntu.com/job/autopilot-ci/887/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/162/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/161
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/161/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/161
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/161/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/325/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4278/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/887/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-16

548. By Christopher Lee on 2014-10-15: Rough (further)WIP. About to all change.
549. By Christopher Lee on 2014-10-16: Code confirmation and cleanup. Using aware datetime objects now
550. By Christopher Lee on 2014-10-16: Change __eq__ operator and update test

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-16:

#

FAILED: Continuous integration, rev:550
http://jenkins.qa.ubuntu.com/job/autopilot-ci/892/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-amd64-ci/167/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-armhf-ci/166/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-utopic-i386-ci/166/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic-autopilot/331/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4438/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/892/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-16

551. By Christopher Lee on 2014-10-16: Improve naming and comments explaining what is going on.
552. By Christopher Lee on 2014-10-16: flake8 cleanup.
553. By Christopher Lee on 2014-10-16: Commit and whitespace cleanup
554. By Christopher Lee on 2014-10-16: Re-enable test.
555. By Christopher Lee on 2014-10-16: Remove un-needed package from d/control

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-16:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/893/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-16:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/894/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-16

556. By Christopher Lee on 2014-10-16: Updated docstrings.
557. By Christopher Lee on 2014-10-16: Further docstring update

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-16:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/895/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2014-10-16:

#

Getting very close now, but still need to make a few changes

review: Needs Fixing

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-17

558. By Christopher Lee on 2014-10-16: Clarify docstrings, comments and variables
559. By Christopher Lee on 2014-10-16: Added SetTimezone fixture + tests for it
560. By Christopher Lee on 2014-10-17: Update tests skip tests only when the platform doesn't support the large time_t
561. By Christopher Lee on 2014-10-17: Clarified comment a little bit.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/896/rebuild

review: Needs Fixing (continuous-integration)

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-17

562. By Christopher Lee on 2014-10-17: Added and clarified details around DateTime.timestamp
563. By Christopher Lee on 2014-10-17: Really minor comment change.
564. By Christopher Lee on 2014-10-17: Backout packaging changes to be put in a separate patch
565. By Christopher Lee on 2014-10-17: Cleanup double-up in debian/control

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/897/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-17:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/899/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2014-10-22:

#

I retested the original failing tests (both calendar as well as UITK) and confirmed this change fixes the test. We also tested the trunk version of these tests and the tests reacted the same way as trunk autopilot; no regressions on date handling.

review: Approve

lp:~veebers/autopilot/fix-1328600-large-datetime updated on 2014-10-30

566. By Christopher Lee on 2014-10-22: Minor whitespace fix
567. By Christopher Lee on 2014-10-28: Better name for Timezone fixture.
568. By Christopher Lee on 2014-10-30: Alter test to not use Europe/Moscow for now.
569. By Christopher Lee on 2014-10-30: Fix flake8 issue

Autopilot

Merge lp:~veebers/autopilot/fix-1328600-large-datetime into lp:autopilot

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers

 === modified file 'autopilot/introspection/types.py'
 --- autopilot/introspection/types.py	2014-05-29 19:44:44 +0000
 +++ autopilot/introspection/types.py	2014-10-22 20:43:57 +0000
@@ -37,7 +37,9 @@
  """
--from datetime import datetime, time
++from datetime import datetime, time, timedelta
++from dateutil.tz import gettz, tzutc
++
  import dbus
  import logging
  from testtools.matchers import Equals
@@ -547,6 +549,15 @@
      """The DateTime class represents a date and time in the UTC timezone.
      DateTime is constructed by passing a unix timestamp in to the constructor.
++    The incoming timestamp is assumed to be in UTC.
++
++    .. note:: This class expects the passed in timestamp to be in UTC but will
++      display the resulting date and time in local time (using the local
++      timezone).
++
++      This is done to mimic the behaviour of most applications which will
++      display date and time in local time by default
++
      Timestamps are expressed as the number of seconds since 1970-01-01T00:00:00
      in the UTC timezone::
@@ -588,10 +599,48 @@
      Finally, you can also compare a DateTime instance with a python datetime
      instance::
--        >>> my_datetime = datetime.datetime.fromutctimestamp(1377209927)
--        True
--
--    DateTime instances can be converted to datetime instances:
++        >>> my_datetime = datetime.datetime.utcfromtimestamp(1377209927)
++        True
++
++
++    .. note:: Autopilot supports dates beyond 2038 on 32-bit platforms. To
++     achieve this the underlying mechanisms require to work with timezone aware
++     datetime objects.
++
++      This means that the following won't always be true (due to the naive
++      timestamp not having the correct daylight-savings time details)::
++
++        >>> # This time stamp is within DST in the 'Europe/London' timezone
++        >>> dst_ts = 1405382400
++        >>> os.environ['TZ'] ='Europe/London'
++        >>> time.tzset()
++        >>> datetime.fromtimestamp(dst_ts).hour == DateTime(dst_ts).hour
++        False
++
++      But this will work::
++
++        >>> from dateutil.tz import gettz
++        >>> datetime.fromtimestamp(
++                dst_ts, gettz()).hour == DateTime(dst_ts).hour
++        True
++
++      And this will always work to::
++
++        >>> dt1 =  DateTime(nz_dst_timestamp)
++        >>> dt2 = datetime(
++                dt1.year, dt1.month, dt1.day, dt1.hour, dt1.minute, dt1.second
++            )
++        >>> dt1 == dt2
++        True
++
++    .. note:: DateTime.timestamp() will not always equal the passed in
++      timestamp.
++      To paraphrase a message from [http://bugs.python.org/msg229393]
++      "datetime.timestamp is supposed to be inverse of
++      datetime.fromtimestamp(), but since the later is not monotonic, no such
++      inverse exists in the strict mathematical sense."
++
++    DateTime instances can be converted to datetime instances::
          >>> isinstance(my_dt.datetime, datetime.datetime)
          True
@@ -599,7 +648,41 @@
      """
      def __init__(self, *args, **kwargs):
          super(DateTime, self).__init__(*args, **kwargs)
--        self._cached_dt = datetime.fromtimestamp(self[0])
++        # Using timedelta in this manner is a workaround so that we can support
++        # timestamps larger than the 32bit time_t limit on 32bit hardware.
++        # We then apply another workaround where timedelta doesn't apply
++        # daylight savings, so we need to work out the offsets for the
++        # localtime manually and apply them to give us the correct local time.
++        #
++        # Note. self[0] is a UTC timestamp
++        EPOCH = datetime(1970, 1, 1, tzinfo=tzutc())
++        utc_dt = EPOCH + timedelta(seconds=self[0])
++
++        local_tzinfo = gettz()
++
++        # Get the localtimes timezone offset (known as standard offset) by
++        # subtracting its dst offset (if any) from its utc offset.
++        # We apply this to the utc datetime object to get datetime object in
++        # localtime.
++        # (We will check (once we have a local datetime) if the time is in dst
++        # and make that adjustment then.)
++        utc_offset = local_tzinfo.utcoffset(utc_dt)
++        dst_offset = local_tzinfo.dst(utc_dt)
++        standard_offset = utc_offset - dst_offset
++
++        # Create a local timezone aware datetime object from the utc_dt
++        # (i.e. attaching a timezone to it) and apply the standard offset to
++        # give us the local time.
++        local_dt = utc_dt.replace(tzinfo=local_tzinfo) + standard_offset
++
++        # If the new local time is firmly in std time then the standard offset
++        # will be 0 (i.e. timedelta(0)).
++        # If the delta isn't 0 then we need to use the timezone information to
++        # apply the dst delta to the local time.
++        if standard_offset != timedelta(0):
++            local_dt = local_dt + local_tzinfo.dst(local_dt)
++
++        self._cached_dt = local_dt
      @property
      def year(self):
@@ -627,14 +710,21 @@
      @property
      def timestamp(self):
--        return self[0]
++        return self._cached_dt.timestamp()
      @property
      def datetime(self):
          return self._cached_dt
      def __eq__(self, other):
++        # A little 'magic' here, if the datetime object to test against is
++        # naive, use the tzinfo from the cached datetime (just for the
++        # comparison)
          if isinstance(other, datetime):
++            if other.tzinfo is None:
++                return other.replace(
++                    tzinfo=self._cached_dt.tzinfo
++                ) == self._cached_dt
              return other == self._cached_dt
          return super(DateTime, self).__eq__(other)
 === modified file 'autopilot/tests/functional/fixtures.py'
 --- autopilot/tests/functional/fixtures.py	2014-05-23 13:44:36 +0000
 +++ autopilot/tests/functional/fixtures.py	2014-10-22 20:43:57 +0000
@@ -25,8 +25,9 @@
  from shutil import rmtree
  import tempfile
  from textwrap import dedent
++import time
--from fixtures import Fixture
++from fixtures import EnvironmentVariable, Fixture
  logger = logging.getLogger(__name__)
@@ -166,3 +167,16 @@
          with open(tmp_file_path, 'w') as desktop_file:
              desktop_file.write(file_contents)
          return tmp_file_path
++
++
++class SetTimezone(Fixture):
++    def __init__(self, timezone):
++        self._timezone = timezone
++
++    def setUp(self):
++        super().setUp()
++        # These steps need to happen in the right order otherwise they won't
++        # get cleaned up properly and we'll be left in an incorrect timezone.
++        self.addCleanup(time.tzset)
++        self.useFixture(EnvironmentVariable('TZ', self._timezone))
++        time.tzset()
 === modified file 'autopilot/tests/functional/test_types.py'
 --- autopilot/tests/functional/test_types.py	2014-05-22 06:41:16 +0000
 +++ autopilot/tests/functional/test_types.py	2014-10-22 20:43:57 +0000
@@ -1,29 +1,99 @@
++# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
++#
++# Autopilot Functional Test Tool
++# Copyright (C) 2013-2014 Canonical
++#
++# This program is free software: you can redistribute it and/or modify
++# it under the terms of the GNU General Public License as published by
++# the Free Software Foundation, either version 3 of the License, or
++# (at your option) any later version.
++#
++# This program is distributed in the hope that it will be useful,
++# but WITHOUT ANY WARRANTY; without even the implied warranty of
++# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++# GNU General Public License for more details.
++#
++# You should have received a copy of the GNU General Public License
++# along with this program.  If not, see <http://www.gnu.org/licenses/>.
++#
  from datetime import datetime
  from autopilot.testcase import AutopilotTestCase
  from autopilot.tests.functional import QmlScriptRunnerMixin
++from autopilot.tests.functional.fixtures import SetTimezone
  from textwrap import dedent
--class TypeTests(AutopilotTestCase, QmlScriptRunnerMixin):
--
--    def test_date(self):
--        proxy = self.start_qml_script(
--            dedent(
--                """\
--                import QtQuick 2.0
--
--                Item {
--                    objectName: "TestMePlease"
--                    property date foo: "2014-01-01"
++class DateTimeTests(AutopilotTestCase, QmlScriptRunnerMixin):
++    scenarios = [
++        ('UTC', dict(
++            TZ='UTC',
++            expected_string='2014-09-29T12:00:00',
++        )),
++        ('NZ', dict(
++            TZ='Pacific/Auckland',
++            expected_string='2014-09-30T01:00:00',
++        )),
++        ('US Central', dict(
++            TZ='US/Central',
++            expected_string='2014-09-29T07:00:00',
++        )),
++        ('US Eastern', dict(
++            TZ='US/Eastern',
++            expected_string='2014-09-29T08:00:00',
++        )),
++        ('MSK', dict(
++            TZ='Europe/Moscow',
++            expected_string='2014-09-29T16:00:00',
++        )),
++    ]
++
++    def get_test_qml_string(self, date_string):
++        return dedent("""
++            import QtQuick 2.0
++            import QtQml 2.2
++            Rectangle {
++                property date testingTime: new Date(%s);
++                Text {
++                    text: testingTime;
+                 }
--                """
--            )
--        )
--        item = proxy.select_single('*', objectName="TestMePlease")
++            }""" % date_string)
++
++    def test_qml_applies_timezone_to_timestamp(self):
++        """Test that when given a timestamp the datetime displayed has the
++        timezone applied to it.
++
++        QML will apply a timezone calculation to a timestamp (but not a
++        timestring).
++
++        """
++        self.useFixture(SetTimezone(self.TZ))
++
++        qml_script = self.get_test_qml_string('1411992000000')
++
++        proxy = self.start_qml_script(qml_script)
          self.assertEqual(
--            item.foo,
--            datetime(2014, 1, 1, 0, 0, 0)
++            proxy.select_single('QQuickText').text,
++            self.expected_string
+         )
++
++    def test_timezone_not_applied_to_timestring(self):
++        """Test that, in all timezones, the literal representation we get in
++        the proxy object matches the one in the Qml script.
++
++        """
++        self.useFixture(SetTimezone(self.TZ))
++
++        qml_script = self.get_test_qml_string("'2014-01-15 12:34:52'")
++        proxy = self.start_qml_script(qml_script)
++        date_object = proxy.select_single("QQuickRectangle").testingTime
++
++        self.assertEqual(date_object.year, 2014)
++        self.assertEqual(date_object.month, 1)
++        self.assertEqual(date_object.day, 15)
++        self.assertEqual(date_object.hour, 12)
++        self.assertEqual(date_object.minute, 34)
++        self.assertEqual(date_object.second, 52)
++        self.assertEqual(datetime(2014, 1, 15, 12, 34, 52), date_object)
 === modified file 'autopilot/tests/unit/test_test_fixtures.py'
 --- autopilot/tests/unit/test_test_fixtures.py	2014-05-20 08:53:21 +0000
 +++ autopilot/tests/unit/test_test_fixtures.py	2014-10-22 20:43:57 +0000
@@ -19,6 +19,7 @@
  from autopilot.tests.functional.fixtures import (
      ExecutableScript,
++    SetTimezone,
      TempDesktopFile,
+ )
@@ -213,3 +214,22 @@
      def test_creates_file_with_execute_bit_set(self):
          fixture = self.useFixture(ExecutableScript(script=""))
          self.assertTrue(os.stat(fixture.path).st_mode & stat.S_IXUSR)
++
++
++class SetTimezoneTests(TestCase):
++
++    def test_sets_environment_variable_to_timezone(self):
++        token = self.getUniqueString()
++
++        self.useFixture(SetTimezone(token))
++
++        self.assertEqual(os.environ.get('TZ'), token)
++
++    def test_resets_timezone_back_to_original(self):
++        original_tz = os.environ.get('TZ', None)
++        token = self.getUniqueString()
++
++        fixture = self.useFixture(SetTimezone(token))
++        fixture.cleanUp()
++
++        self.assertEqual(os.environ.get('TZ', None), original_tz)
 === modified file 'autopilot/tests/unit/test_types.py'
 --- autopilot/tests/unit/test_types.py	2014-07-22 02:39:26 +0000
 +++ autopilot/tests/unit/test_types.py	2014-10-22 20:43:57 +0000
@@ -18,13 +18,14 @@
+ #
  from datetime import datetime, time
--from testscenarios import TestWithScenarios
++from testscenarios import TestWithScenarios, multiply_scenarios
  from testtools import TestCase
  from testtools.matchers import Equals, IsInstance, NotEquals, raises
  import dbus
  from unittest.mock import patch, Mock
++from autopilot.tests.functional.fixtures import SetTimezone
  from autopilot.introspection.types import (
      Color,
      create_value_instance,
@@ -51,6 +52,8 @@
  from autopilot.introspection.dbus import DBusIntrospectionObject
  from autopilot.utilities import compatible_repr
++from dateutil import tz
++
  class PlainTypeTests(TestWithScenarios, TestCase):
@@ -281,19 +284,32 @@
          self.assertEqual(repr(c), str(c))
--class DateTimeTests(TestCase):
++def unable_to_handle_timestamp(timestamp):
++    """Return false if the platform can handle timestamps larger than 32bit
++    limit.
++
++    """
++    try:
++        datetime.fromtimestamp(timestamp)
++        return False
++    except:
++        return True
++
++
++class DateTimeCreationTests(TestCase):
++
++    timestamp = 1405382400  # No significance, just a timestamp
      def test_can_construct_datetime(self):
--        dt = DateTime(1377209927)
++        dt = DateTime(self.timestamp)
          self.assertThat(dt, IsInstance(dbus.Array))
      def test_datetime_has_slice_access(self):
--        dt = DateTime(1377209927)
--
--        self.assertThat(dt[0], Equals(1377209927))
++        dt = DateTime(self.timestamp)
++        self.assertThat(dt[0], Equals(self.timestamp))
      def test_datetime_has_properties(self):
--        dt = DateTime(1377209927)
++        dt = DateTime(self.timestamp)
          self.assertTrue(hasattr(dt, 'timestamp'))
          self.assertTrue(hasattr(dt, 'year'))
@@ -303,58 +319,154 @@
          self.assertTrue(hasattr(dt, 'minute'))
          self.assertTrue(hasattr(dt, 'second'))
++    def test_repr(self):
++        # Use a well known timezone for comparison
++        self.useFixture(SetTimezone('UTC'))
++        dt = DateTime(self.timestamp)
++        observed = repr(dt)
++
++        expected = "DateTime({:%Y-%m-%d %H:%M:%S})".format(
++            datetime.fromtimestamp(self.timestamp)
++        )
++        self.assertEqual(expected, observed)
++
++    def test_repr_equals_str(self):
++        dt = DateTime(self.timestamp)
++        self.assertEqual(repr(dt), str(dt))
++
++    def test_can_create_DateTime_using_large_timestamp(self):
++        """Must be able to create a DateTime object using a timestamp larger
++        than the 32bit time_t limit.
++
++        """
++        # Use a well known timezone for comparison
++        self.useFixture(SetTimezone('UTC'))
++        large_timestamp = 2**32+1
++        dt = DateTime(large_timestamp)
++
++        self.assertEqual(dt.year, 2106)
++        self.assertEqual(dt.month, 2)
++        self.assertEqual(dt.day, 7)
++        self.assertEqual(dt.hour, 6)
++        self.assertEqual(dt.minute, 28)
++        self.assertEqual(dt.second, 17)
++        self.assertEqual(dt.timestamp, large_timestamp)
++
++
++class DateTimeTests(TestWithScenarios, TestCase):
++
++    timestamps = [
++        # This timestamp uncovered an issue during development.
++        ('Explicit US/Pacific test', dict(
++            timestamp=1090123200
++        )),
++
++        ('NZ DST example', dict(
++            timestamp=2047570047
++        )),
++
++        ('Winter', dict(
++            timestamp=1389744000
++        )),
++
++        ('Summer', dict(
++            timestamp=1405382400
++        )),
++
++        ('32bit max', dict(
++            timestamp=2**32+1
++        )),
++
++        ('32bit limit', dict(
++            timestamp=2983579200
++        )),
++
++    ]
++
++    timezones = [
++        ('UTC', dict(
++            timezone='UTC'
++        )),
++
++        ('London', dict(
++            timezone='Europe/London'
++        )),
++
++        ('New Zealand', dict(
++            timezone='NZ',
++        )),
++
++        ('Pacific', dict(
++            timezone='US/Pacific'
++        )),
++
++        ('Hongkong', dict(
++            timezone='Hongkong'
++        )),
++
++        ('Moscow', dict(
++            timezone='Europe/Moscow'
++        ))
++    ]
++
++    scenarios = multiply_scenarios(timestamps, timezones)
++
++    def skip_if_timestamp_too_large(self, timestamp):
++        if unable_to_handle_timestamp(self.timestamp):
++            self.skip("Timestamp to large for platform time_t")
++
      def test_datetime_properties_have_correct_values(self):
--        dt = DateTime(1377209927)
--        dt_with_tz = datetime.fromtimestamp(1377209927)
--
--        self.assertThat(dt.timestamp, Equals(dt_with_tz.timestamp()))
--        self.assertThat(dt.year, Equals(dt_with_tz.year))
--        self.assertThat(dt.month, Equals(dt_with_tz.month))
--        self.assertThat(dt.day, Equals(dt_with_tz.day))
--        self.assertThat(dt.hour, Equals(dt_with_tz.hour))
--        self.assertThat(dt.minute, Equals(dt_with_tz.minute))
--        self.assertThat(dt.second, Equals(dt_with_tz.second))
++        self.skip_if_timestamp_too_large(self.timestamp)
++        self.useFixture(SetTimezone(self.timezone))
++
++        dt1 = DateTime(self.timestamp)
++        dt2 = datetime.fromtimestamp(self.timestamp, tz.gettz())
++
++        self.assertThat(dt1.year, Equals(dt2.year))
++        self.assertThat(dt1.month, Equals(dt2.month))
++        self.assertThat(dt1.day, Equals(dt2.day))
++        self.assertThat(dt1.hour, Equals(dt2.hour))
++        self.assertThat(dt1.minute, Equals(dt2.minute))
++        self.assertThat(dt1.second, Equals(dt2.second))
++        self.assertThat(dt1.timestamp, Equals(dt2.timestamp()))
      def test_equality_with_datetime(self):
--        dt1 = DateTime(1377209927)
--        dt2 = DateTime(1377209927)
++        self.skip_if_timestamp_too_large(self.timestamp)
++        self.useFixture(SetTimezone(self.timezone))
++
++        dt1 = DateTime(self.timestamp)
++        dt2 = datetime(
++            dt1.year, dt1.month, dt1.day, dt1.hour, dt1.minute, dt1.second
++        )
          self.assertThat(dt1, Equals(dt2))
      def test_equality_with_list(self):
--        dt1 = DateTime(1377209927)
--        dt2 = [1377209927]
++        self.skip_if_timestamp_too_large(self.timestamp)
++        self.useFixture(SetTimezone(self.timezone))
++
++        dt1 = DateTime(self.timestamp)
++        dt2 = [self.timestamp]
          self.assertThat(dt1, Equals(dt2))
--    def test_equality_with_datetime_timestamp(self):
--        # DateTime no longer assumes UTC and uses local TZ.
--        dt1 = DateTime(1377209927)
--        dt2 = datetime.fromtimestamp(1377209927)
--        dt3 = datetime.fromtimestamp(1377209928)
++    def test_equality_with_datetime_object(self):
++        self.skip_if_timestamp_too_large(self.timestamp)
++        self.useFixture(SetTimezone(self.timezone))
++
++        dt1 = DateTime(self.timestamp)
++        dt2 = datetime.fromtimestamp(self.timestamp, tz.gettz())
++        dt3 = datetime.fromtimestamp(self.timestamp + 1, tz.gettz())
          self.assertThat(dt1, Equals(dt2))
          self.assertThat(dt1, NotEquals(dt3))
      def test_can_convert_to_datetime(self):
--        dt1 = DateTime(1377209927)
++        self.skip_if_timestamp_too_large(self.timestamp)
++        dt1 = DateTime(self.timestamp)
          self.assertThat(dt1.datetime, IsInstance(datetime))
--    def test_repr(self):
--        expected = repr_type(
--            u"DateTime({:%Y-%m-%d %H:%M:%S})".format(
--                datetime.fromtimestamp(1377209927)
--            )
--        )
--        dt = DateTime(1377209927)
--        observed = repr(dt)
--        self.assertEqual(expected, observed)
--
--    def test_repr_equals_str(self):
--        dt = DateTime(1377209927)
--        self.assertEqual(repr(dt), str(dt))
--
  class TimeTests(TestCase):
 === modified file 'debian/control'
 --- debian/control	2014-08-05 21:58:41 +0000
 +++ debian/control	2014-10-22 20:43:57 +0000
@@ -15,6 +15,7 @@
                 libjs-underscore,
                 liblttng-ust-dev,
                 python3-all-dev (>= 3.4),
++               python3-dateutil,
                 python3-dbus,
                 python3-decorator,
                 python3-evdev,
@@ -44,6 +45,7 @@
           ${python3:Depends},
           gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
           libjs-underscore, libjs-jquery,
++         python3-dateutil,
           python3-dbus,
           python3-decorator,
           python3-fixtures,
@@ -135,6 +137,7 @@
           libautopilot-gtk (>= 1.4),
           libautopilot-qt (>= 1.4),
           python3-autopilot,
++         python3-dateutil,
           python3-dbus.mainloop.qt,
           python3-evdev,
           python3-pyqt4,