Code review comment for lp:~vds/usso/validity_check_and_better_auth_failure_handling

Revision history for this message
Vincenzo Di Somma (vds) wrote :

> Instead of declaring jsonBuffer as an interface at 64+ and then casting to a
> map at 70+ could jsonBuffer just be declared as a map leaving json.Unmarshal
> to do the work?
>
> At 75+ if USSO change there source and the json code field is no longer a
> string then we will panic. If 75+ was replaced with the code below we won't
> panic should the external source change.
>
> return "", fmt.Errorf("%v",code)
>
> Do you think it is worth changing the code to be on the safe side?
>
> The above questions for 124+, 137+, and 142+ too.

All good suggestions, all fixed, thanks.

« Back to merge proposal