Code review comment for lp:~vds/usso/better_interface

Revision history for this message
Graham Binns (gmb) wrote :

Hi Vincenzo,

Thanks for addressing my concerns. I still think the documentation on the tests needs tweaking. The documentation you've added does describe the expected behaviour for which we're testing, but it does it in a rather opaque way. I've pastebinned a diff of how I think the documentation should read:

Generally, comments on tests should be written as something like:

// Foo() returns an instance of Bar when its returnBar parameter is set to true.
func (suite *FooTestSuite) TestFooReturnsBarWhenReturnBarParameterIsTrue (c *gocheck.C) {

review: Approve (code)

« Back to merge proposal