lp:xdg-utils

Created by Jelmer Vernooij and last modified
Get this branch:
bzr branch lp:xdg-utils

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
VCS imports
Project:
Xdg-utils
Status:
Development

Import details

Import Status: Failed

This branch is an import of the HEAD branch of the Git repository at git://anongit.freedesktop.org/xdg/xdg-utils.

The import has been suspended because it failed 5 or more times in succession.

Last successful import was .

Import started on alnitak and finished taking 15 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log

Recent revisions

760. By Andrea Tarocchi <email address hidden>

fixed #166: xdg-open dose not search correctly in directories with spaces in the name

759. By Martin Puppe <email address hidden>

xdg-mime: return correct exit code for GNOME

If the desktop environment was GNOME and none of the commands for
detecting the MIME type of a file was available, xdg-mime used to return
exit code 0 even though it failed. The man page says it should return
exit code 3. This commit fixes the issue.

I have considered returning exit code 4 instead since that is what would
be returned if info_kde() or info_generic() fail to find a tool for MIME
type detection. But I have decided to implement the behavior as
specified in the man page.

The exit code of an if construct is 0 if no condition
tested true [^1]. The author of the original code probably was not aware
of this.

[^1]: https://www.gnu.org/software/bash/manual/html_node/Conditional-Constructs.html#Conditional-Constructs

758. By Cameron Fieber <email address hidden>

support digits in uri scheme regex

As per RFC 2396[1] a valid URI scheme may contain a digit:

scheme = alpha *( alpha | digit | + | - | . )

[1]: https://www.ietf.org/rfc/rfc2396.txt

757. By Rex Dieter

Merge branch 'simotek/xdg-utils-fix-xdg-open-typo'

756. By Rex Dieter

Merge branch 'simotek/xdg-utils-feature-xdg-su-enhancements'

755. By Rex Dieter

Merge branch 'simotek/xdg-utils-fix-xscreensaver-sanitize'

754. By Rex Dieter

Merge branch 'simotek/xdg-utils-term-fixes'

753. By mvdlinde <email address hidden>

Enable cinnamon screensaver for xdg aware desktop environments (eg lxqt)

752. By Richard Tollerton

test-lib.sh: run: eat xdg-open's exit code

It was observed that t-xdg-open.sh exits after only a fraction of the tests have
been run, e.g.

ASSERTION FAILED: expected command to be run: gio open http://www.freedesktop.org/
ASSERTION FAILED: expected command to be run: gio open http://www.freedesktop.org/
  - opens a URL with gvfs-open if gio open is missing in GNOME 3, GNOME 2, and Cinnamon
gio: http://www.freedesktop.org/: Operation not supported
make: *** [Makefile:21: t-xdg-open.sh] Error 4

Given that some tests are failing on my machine (likely because of the
peculiarities of my archlinux install), the root cause is `set -e`. The nonzero
exit code returned by xdg-open gets returned by run(), which is also returned by
e.g. test_open_url(), which causes the script to exit immediately.

All test passes/failures at present are being defined by explicit assertions,
not by exit codes, and it seems at least plausible that some xdg-open calls are
meant to fail. So rather than report the nonzero error code, just ignore it, and
trust that the assertions determine the results.

Signed-off-by: Richard Tollerton <email address hidden>

751. By Richard Tollerton

xdg-open: handle file://localhost/

Presently, file://localhost/ URLs are totally unsupported: is_file_url_or_path
correctly considers them files, but they are undecoded and hence
check_input_file fails.

While the standardization surrounding file: URLs is admittedly vague [1], AFAIK,
*all* literature, and other implementations, unambiguously demonstrate that
file://localhost/ should be equivalent to file:///:

- The "File URI specification" explicitly linked to from the xdg-utils homepage [2]
- RFC 8089 section 1.1
- RFC 1738 section 3.10
- Observed implementations of Windows `start`, macOS `open`, Firefox, Chrome, IE

Fix this by adding some simple carve-outs for file://localhost specifically in
file_url_to_path.

[1] https://lists.freedesktop.org/archives/xdg/2004-November/003711.html
[2] https://edeproject.org/spec/file-uri-spec.txt

Signed-off-by: Richard Tollerton <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.