lp:reviewboard

Created by Jelmer Vernooij on 2009-12-17 and last modified on 2019-09-16
Get this branch:
bzr branch lp:reviewboard

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
VCS imports
Project:
Review Board
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://github.com/reviewboard/reviewboard.git.

The next import is scheduled to run in 4 hours.

Last successful import was 1 hour ago.

Import started 1 hour ago on alnitak and finished 1 hour ago taking 25 seconds — see the log
Import started 7 hours ago on alnitak and finished 7 hours ago taking 25 seconds — see the log
Import started 14 hours ago on alnitak and finished 14 hours ago taking 25 seconds — see the log
Import started 21 hours ago on alnitak and finished 21 hours ago taking 25 seconds — see the log
Import started on 2019-09-17 on alnitak and finished on 2019-09-17 taking 25 seconds — see the log
Import started on 2019-09-17 on alnitak and finished on 2019-09-17 taking 25 seconds — see the log
Import started on 2019-09-17 on alnitak and finished on 2019-09-17 taking 25 seconds — see the log
Import started on 2019-09-16 on alnitak and finished on 2019-09-16 taking 25 seconds — see the log
Import started on 2019-09-16 on alnitak and finished on 2019-09-16 taking 25 seconds — see the log
Import started on 2019-09-16 on alnitak and finished on 2019-09-16 taking 25 seconds — see the log

Recent revisions

4773. By Christian Hammond <email address hidden> on 2019-09-16

Merge branch 'release-4.0.x'

4772. By Christian Hammond <email address hidden> on 2019-09-16

Merge branch 'release-4.0.x'

4771. By Christian Hammond <email address hidden> on 2019-09-12

Merge branch 'release-4.0.x'

4770. By Barret Rennie on 2019-09-10

Set the correct root URL in RB.TextBasedReviewableView

The `RB.TextBasedReviewableView` was using an incorrect root path
Instead of just being the path relative to the FQDN, it was using the
entire URL. This resulted in Backbone never matching URLs since it was
trying to match fragments against full URLs. The view would then be
stuck in the rendered view mode at all times.

Testing Done:
Verified that the TextBasedReviewableView can switch between rendered
and source modes on Python 2.7, 3.5, 3.6, and 3.7.

Reviewed at https://reviews.reviewboard.org/r/10701/

4769. By Barret Rennie on 2019-09-10

Fix prepare-dev.py hook installation on Python 3

There were two issues in the implementation of `install_git_hooks` that
prevented it from working on Python 3:
- an old-style (0777) octal literal was used instead of a new-style one
  (0o777): old-style literals are not supported on Python 3; and
- bytes and unicode were being mixed in `os.path.join`, which is not an
  issue in Python 2 but is on Python 3.

Since `prepare-dev.py` is intended to install dependencies, we can't
assume the presence of `six`, so we determine the correct string type
manually.

Testing Done:
Ran prepare-dev.py under Python 2 and Python 3 and it created git
hooks successfully.

Reviewed at https://reviews.reviewboard.org/r/10680/

4768. By Christian Hammond <email address hidden> on 2019-09-10

Merge branch 'release-4.0.x'

4767. By David Trowbridge on 2019-09-07

Merge branch 'release-4.0.x'

4766. By Christian Hammond <email address hidden> on 2019-09-07

Merge branch 'release-4.0.x'

4765. By Christian Hammond <email address hidden> on 2019-09-06

Merge branch 'release-4.0.x'

4764. By Christian Hammond <email address hidden> on 2019-09-06

Merge branch 'release-4.0.x'

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers

No subscribers.