lp:reviewboard

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

5085. By David Trowbridge on 2024-09-19

Merge branch 'release-7.1.x'

5084. By David Trowbridge on 2024-09-06

Remove old DraftReviewBannerView.

The new unified banner is fully stable, and we're never going back to
the old banners. This change removes the DraftReviewBannerView.

Testing Done:
Ran js-tests.

Reviewed at https://reviews.reviewboard.org/r/14097/

5083. By David Trowbridge on 2024-09-06

Convert a couple of legacy test files to TypeScript.

The MenuView and MenuButtonView were converted to TypeScript a while
ago, but we didn't convert the matching test files. This change does
that.

These views are obsolete anyway because we are moving to Ink's versions.

Testing Done:
Ran js-tests.

Reviewed at https://reviews.reviewboard.org/r/14096/

5082. By David Trowbridge on 2024-09-06

Convert RB.OAuthClientSecretView to TypeScript/spina

This change converts the OAauth client secret widget JS to TypeScript
and spina. I decided to merge this into the "widgets" bundle, since it
seemed excessive to have a separate bundle just for this one file.

Testing Done:
- Ran js-tests.
- Verified that the OAuth secret input still worked as expected.

Reviewed at https://reviews.reviewboard.org/r/14095/

5081. By David Trowbridge on 2024-09-06

Switch to Ink buttons for the OAuth application form.

This change switches to using Ink buttons for the OAuth application form
template.

Testing Done:
Loaded the OAuth application form and saw the new buttons.

Reviewed at https://reviews.reviewboard.org/r/14094/

5080. By David Trowbridge on 2024-09-06

Convert RB.OAuthTokensView to TypeScript/spina.

This change converts the RB.OAuthTokensView config forms views to
TypeScript.

The only functional change is that while doing this I discovered that we
were always showing the "You do not have any OAuth2 tokens" text, even
when there were tokens in the list.

Testing Done:
- Ran js-tests.
- Created Oauth tokens (via the admin site) and saw them in the list,
  and removed them via the UI.

Reviewed at https://reviews.reviewboard.org/r/14093/

5079. By David Trowbridge on 2024-09-06

Convert RB.OAuthApplicationsView to TypeScript/spina

This change converts the OAuth applications view for the account
settings to TypeScript.

The only functional change is that while doing this, I discovered that
we were always showing the "have not registered any OAuth2
applications." text, even when there were applications in the list.

Testing Done:
- Ran js-tests.
- Used the OAuth applications page in the settings.

Reviewed at https://reviews.reviewboard.org/r/14090/

5078. By David Trowbridge on 2024-09-06

Convert RB.JoinedGroupsView to TypeScript/spina

This change converts the groups page for the account settings to
TypeScript.

Testing Done:
- Used the various features of the groups page.
- Ran js-tests.

Reviewed at https://reviews.reviewboard.org/r/14089/

5077. By David Trowbridge on 2024-09-06

Fix up a handful of review-request related type problems.

This change fixes up some issues with our typing and some issues exposed
by adding typing:

- In our review request data templates, the initial value of the
  `submitter` link was being added to the review request, but it really
  only belongs on the review request draft.
- Added the url field to the review group resource data definition.
- The types for several things inside the review request attributes were
  incorrect (should have been ResourceLink[] instead of string[] or
  ReviewRequest[]).
- Types throughout the review request fields implementation had some
  errors, especially typing for methods.

Testing Done:
Ran js-tests.

Reviewed at https://reviews.reviewboard.org/r/14087/

5076. By David Trowbridge on 2024-09-06

Convert RB.DraftReviewRequest to TypeScript/spina

This change converts the DraftReviewRequest resource model to
TypeScript.

The one complication in here is a change in behavior with mixins
where the `url()` implementation in `DraftResourceModelMixin` was
taking priority over the one in `DraftReviewRequest`. In the vast
majority of draft resource cases, the implementation in the mixin
is what we want, but review requests are special.

Testing Done:
- Ran js-tests.
- Ran setup.py build_media.

Reviewed at https://reviews.reviewboard.org/r/14086/