lp:reviewboard

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

4890. By David Trowbridge on 2021-10-14

Remove add_metaclass compatibility shim.

Now that 5.0 in Python 3 only, we can start moving away from all the
compatibility shims. This change does that for the `@six.add_metaclass`
decorator.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/11844/

4889. By David Trowbridge on 2021-10-14

Un-blacklist p4python on Python 3.9.

p4python now has builds for Python 3.9, so we can un-blacklist it.

Testing Done:
Ran setup.py develop for 3.9 and saw that it didn't try to brokenly
compile things.

Reviewed at https://reviews.reviewboard.org/r/11845/

4888. By David Trowbridge on 2021-10-13

Replace nose.SkipTest with modern alternatives.

Once upon a time, when nose test runner, raising `nose.SkipTest` was the
only way to mark a unit test as skipped. This concept made it into core
Python in 2.7, along with some nice additional helpers and methods. This
change moves us over to the standard library versions.

Testing Done:
Ran unit tests.

Reviewed at https://reviews.reviewboard.org/r/11828/

4887. By David Trowbridge on 2021-10-03

Convert BaseCollection.fetch to return a promise.

This is the first of what is likely to be many steps to move our
codebase towards a more modern feel of using promises and
`async`/`await` for asynchronous operations. In this change,
`BaseCollection.fetch` has been changed, along with everything that
actually uses that including similar methods inside
`ResourceCollection`. The old callback usage is still available through
a helper which will wrap the returned promise, but causes a warning to
be logged to the console.

This also tweaks to our browserslist config in order to ensure that
`async`/`await` won't get polyfilled out due to niche browsers
(primarily on mobile) that we really don't care about supporting.

Testing Done:
- Ran js-tests.
- Manually tested data population on the review dialog and post commit
  views.

Reviewed at https://reviews.reviewboard.org/r/11629/

4886. By David Trowbridge on 2021-10-03

Merge branch 'release-4.0.x'

4885. By Ruonan Jia <email address hidden> on 2021-09-01

Add documentation for Matrix.

This adds documentation for the new Matrix integration which was landed
for rbintegrations 3.0.

Testing Done:
Build docs and viewed the output.

Reviewed at https://reviews.reviewboard.org/r/11322/

4884. By David Trowbridge on 2021-08-27

Merge branch 'release-4.0.x'

4883. By David Trowbridge on 2021-08-17

Merge remote-tracking branch 'origin/release-4.0.x'

4882. By Christian Hammond <email address hidden> on 2021-07-29

Merge branch 'release-4.0.x'

4881. By Christian Hammond <email address hidden> on 2021-07-20

Merge branch 'release-4.0.x'