lp:~vcs-imports/putty/master

Created by Colin Watson on 2016-10-02 and last modified on 2019-06-15
Get this branch:
bzr branch lp:~vcs-imports/putty/master

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
VCS imports
Project:
PuTTY
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://git.tartarus.org/simon/putty.git.

The next import is scheduled to run in 3 hours.

Last successful import was 2 hours ago.

Import started 2 hours ago on izar and finished 2 hours ago taking 20 seconds — see the log
Import started 8 hours ago on alnitak and finished 8 hours ago taking 20 seconds — see the log
Import started 14 hours ago on alnitak and finished 14 hours ago taking 20 seconds — see the log
Import started 20 hours ago on izar and finished 20 hours ago taking 15 seconds — see the log
Import started on 2019-06-17 on alnitak and finished on 2019-06-17 taking 20 seconds — see the log
Import started on 2019-06-16 on izar and finished on 2019-06-16 taking 20 seconds — see the log
Import started on 2019-06-16 on izar and finished on 2019-06-16 taking 15 seconds — see the log
Import started on 2019-06-16 on alnitak and finished on 2019-06-16 taking 15 seconds — see the log
Import started on 2019-06-16 on izar and finished on 2019-06-16 taking 15 seconds — see the log
Import started on 2019-06-15 on alnitak and finished on 2019-06-15 taking 15 seconds — see the log

Recent revisions

5489. By Simon Tatham <email address hidden> on 2019-06-15

Add missing del234 in ssh_transient_hostkey_cache_add.

The idea was that if we found a host key already cached for the given
algorithm, we should remove it from the tree and free it. In fact, I
forgot the 'remove from tree' step, so we freed a key that was still
linked from the tree234. Depending on luck and platform, this could
either cause a segfault, or an assertion failure on the subsequent
attempt to add the new key in place of the not-removed-after-all old
one.

5488. By Simon Tatham <email address hidden> on 2019-06-03

GTK: fix handling of delete event in Change Settings dialog.

If the user closes the Change Settings dialog box using the close
button provided by the window manager (or some analogous thing that
generates the same X11 event) instead of using the Cancel button
within the dialog itself, then after_change_settings_dialog() gets
called with retval < 0, which triggers an early return path in which
we forget to call unregister_dialog(), and as a result, assertions
fail all over the place the _next_ time you try to put up a Change
Settings dialog.

Also, the early return causes ctx.newconf to be memory-leaked. So
rather than just moving the unregister_dialog() call to above the
early return, a better fix is to remove the early return completely,
and simply treat retval<0 the same as retval==0: it doesn't matter
_how_ the user closed the config box without committing the changes,
it only matters that they did.

5487. By Jacob Nevins <email address hidden> on 2019-05-12

Note Pentium 4+ processor requirement.

(At least, that's what the Clang bog brush option -### says it's
building with.)

5486. By Simon Tatham <email address hidden> on 2019-05-10

Uppity: fill in some missing end-of-session handling.

I needed to send a server-side disconnect message in a test just now,
which caused me to notice that I'd never got round to filling in
ssh_proto_error properly. Now I've done that, and added the associated
machinery for waiting for the remote EOF and winding up the SSH
connection.

The rest of the error functions are still stubs, though.

5485. By Simon Tatham <email address hidden> on 2019-05-10

Print 'instruction' field in keyboard-interactive auth.

When I reworked this code to make it strbuf-based, I apparently forgot
to copy the contents of one particular strbuf into the prompts_t.

5484. By Simon Tatham <email address hidden> on 2019-05-08

pscp: clear act->buf after receiving 'T' command.

Without this missing line, if you tried to download a file in SCP mode
using the -p option, the payload of the 'T' command (file times) would
still be sitting in act->buf when we went back round the loop, so the
payload of the followup 'C' or 'D' would be appended to it, leading to
a massive misparse and a complaint about illegal file renaming.

5483. By Simon Tatham <email address hidden> on 2019-05-08

Uppity: print a startup message.

When I start Uppity in listening mode, it's useful to have it
acknowledge that it _has_ started up in that mode, and isn't (for
example) stuck somewhere in my local wrapper script.

5482. By Simon Tatham <email address hidden> on 2019-05-05

Missing piece of the previous commit.

Ahem. I was sure I'd hit save!

5481. By Simon Tatham <email address hidden> on 2019-05-05

Use a proper PRNG for GTK askpass.

Coverity complained that it was wrong to use rand() in a security
context, and although in this case it's _very_ marginal, I can't
actually disagree that the choice of which light to light up to avoid
giving information about passphrase length is a security context.

So, no more rand(); instead we instantiate a shiny Fortuna PRNG
instance, seed it in more or less the usual way, and use that as an
overkill-level method of choosing which light to light up next.

(Acknowledging that this is a slightly unusual application and less
critical than most, I don't actually put the passphrase characters
themselves into the PRNG, and I don't use a random-seed file.)

5480. By Simon Tatham <email address hidden> on 2019-05-05

Move random_save_seed() into sshrand.c.

It's identical in uxnoise and winnoise, being written entirely in
terms of existing cross-platform functions. Might as well centralise
it into sshrand.c.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers