lp:pmake

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

3873. By rillig on 2021-01-10

make(1): make a few more bool expressions more precise

The previous version of lint(1) from a few hours ago didn't catch all
occurrences. And even the current one doesn't catch everything.
Function arguments and return types still need some work. The "return
quietly" from shouldDieQuietly still implicitly converts from int to
_Bool.

No functional change.

3872. By rillig on 2021-01-10

make(1): consistently use boolean expressions in conditions

Most of the make code already followed the style of explicitly writing
(ptr != NULL) instead of the shorter (ptr) in conditions.

The remaining 50 instances have been found by an experimental,
unpublished check in lint(1) that treats bool expressions as
incompatible to any other scalar type, just as in Java, C#, Pascal and
several other languages.

The only unsafe operation on Boolean that is left over is (flags &
FLAG), for an enum implementing a bit set. If Boolean is an ordinary
integer type (the default), some high bits may get lost. But if Boolean
is the same as _Bool (by compiling with -DUSE_C99_BOOLEAN), C99 6.3.1.2
defines that a conversion from any scalar to the type _Bool acts as a
comparison to 0, which cannot lose any bits.

3871. By rillig on 2021-01-09

make(1): fix lint warnings

3870. By sjg on 2021-01-08

Ensure PrintOnError always reports 'stopped in' on first call.

We may still suppress the rest of the noise if shouldDieQuietly
says to, but the 'stopped in' output is too important to lose.
Avoid repeating it though in the same process.

For the case of aborting due to failure detected elsewhere,
exit 6 so we have a clue.

PR: 55578
Reviewed by:

3869. By sjg on 2021-01-08

Set wantToken when none available.

PR: 53285
Reviewed by: gson

3868. By sjg on 2021-01-07

Remove .MAKE from nested target which is not a sub-make

This does not fix the issue, just makes the unit-test more accurate.

PR: 55578
Reviewed by: rillig

3867. By rillig on 2021-01-03

make(1): remove anonymous union from struct ListNode

Anonymous structs and unions have been introduced in C11. The code of
make is supposed to be compatible with C90 though.

The additional members were intended to be used during an interactive
debugging session only and were thus not relevant to running the actual
code.

3866. By rillig on 2021-01-02

make(1): add a few remarks to JobOutput

That function is not used in practice. Still, there are a lot of subtle
details that can get wrong in that code.

3865. By sjg on 2021-01-01

var-op-expand needs MAKE.SAVE_DOLLARS=yes

3864. By rillig on 2020-12-31

make(1): replace pointers in controlling conditions with booleans