lp:~vcs-imports/pango/+git/pango

Author: Matthias Clasen
Author Date: 2021-11-28 04:37:23 UTC

Fix line heights in improper gravities

Without this, we end up with line height being
zero in gravity north or west. The visible symptom
is that wrapped lines are drawn on top of each
other with line-height != 0.

Affected tests have been updated.

Fixes: #631

Author: Matthias Clasen
Author Date: 2021-11-27 14:22:01 UTC

Add a test for pango_font_serialize

Now that we have fonts in git, we can
reliably test this.

Author: Matthias Clasen
Author Date: 2021-11-25 13:47:51 UTC

Skip test-layout on macOS

It should work there, but it doesn't.

Author: Matthias Clasen
Author Date: 2021-11-21 21:20:25 UTC

Fix handling of extra width

When handling items that fix completely,
we were not consistently taking extra width
into account, leading to hyphens sticking
out in some cases.

Author: Matthias Clasen
Author Date: 2021-11-20 03:15:06 UTC

wip: Fix up font metrics in improver gravities

In these gravities, we give the font a negative scale
to get negative advance widths, but this also makes
font metrics come out negative, and some of our code
in pango-layout.c can't deal with that. So flip the
metrics back.

Author: Matthias Clasen
Author Date: 2021-11-18 19:06:04 UTC

Add a json-glib subproject

This is necessary for ci on MacOs to build.

Author: Matthias Clasen
Author Date: 2021-11-18 12:30:01 UTC

Neuter g_debug in line-breaking

This code gets run for gtks size-allocation,
and we don't want it to be any slower than it
has to be, when not debugging it.

Author: Matthias Clasen
Author Date: 2021-11-14 05:12:34 UTC

Add pango_tab_array_to/from_string

Author: Benjamin Otte
Author Date: 2021-11-12 02:14:34 UTC

tests: Add spiced up wrapping tests

* Generate random string that looks like a sentence.
* Measure the size at 100 random widths.
* assert that for those widths, when sorted, the measured widths
  are increasing and the heights are decreasing.

* Generate random string that looks like a sentence.
* Generate a 2nd string adding hyphen + newline after every char of
  original string.
* Assert that wrap-char wrap with width=0 is not larger than the width
  of the 2nd string

The tests also generate random strings in LTR, RTL or both at the same
time to spice the test up even more.
It does that by picking random words out of hunspell directories, and if
none are installed, it falls back to lorem ipsum.

Author: Matthias Clasen
Author Date: 2021-11-15 14:36:25 UTC

Update affected tests

Some of the layout tests now get better line breaks.

Author: Matthias Clasen
Author Date: 2021-11-15 03:59:47 UTC

Revert "testrandom: Disable assertions I can't make work"

This reverts commit 3bacb9c23b211ffe6674f9d0ce3e6dbecdb4808f.

Author: Matthias Clasen
Author Date: 2021-11-13 02:39:29 UTC

testrandom: Add other wrap modes

Author: Matthias Clasen
Author Date: 2021-11-14 05:17:46 UTC

serializer: Use the new tabarray api

Author: Matthias Clasen
Author Date: 2021-11-13 16:12:34 UTC

Skip the test on macOS

Author: Matthias Clasen
Author Date: 2021-11-13 16:02:17 UTC

Add a serialization test

Author: Matthias Clasen
Author Date: 2021-11-12 23:31:09 UTC

Fix a thinko

Author: Chun-wei Fan
Author Date: 2021-11-12 02:57:13 UTC

testmisc.c: Fix builds without PangoFT2

Builds using the pango_ot_*() APIs rely on PangoFT2, so only build these items
if we are building PangoFT2.

Author: Matthias Clasen
Author Date: 2021-11-12 00:58:21 UTC

Try harder to not produce overlong lines

Our accounting for run lengths is imperfect (mainly
due to log widths for clusters being evenly distributed),
so it can happen that after reshaping the split item,
we find that it does not actually fit in the remaining
width. Previously, we would just use the split run
at that point and produce an overlong line. Instead,
undo the split, disable the breakpoint we used, and
try again.

Author: Matthias Clasen
Author Date: 2021-11-11 04:47:16 UTC

wip: A more biting layout width test

Author: Matthias Clasen
Author Date: 2021-11-11 01:32:07 UTC

Update affected tests

Author: Matthias Clasen
Author Date: 2021-11-10 05:07:38 UTC

docs: Small addition

Mention new attribute values in markup docs.

Author: Matthias Clasen
Author Date: 2021-11-09 01:06:47 UTC

Call hb_font_set_ptem when creating fonts

This is useful information for Harfbuzz to have,
so pass it along.

Author: Matthias Clasen
Author Date: 2021-11-07 16:40:47 UTC

itemize: Handle text transforms

Take text transforms into account when emulating
Small Caps. This requires us to have log attrs
to determine word starts.

Author: Matthias Clasen
Author Date: 2021-11-05 10:57:44 UTC

Fix advance widths with transforms

The hb_font_t we were passing to Harfbuzz
for shaping was not taking context transforms
into account, and therefore was not scaling
advance widths as necessary. Always go through
pangos glyph extents to fix this.

Fixes: #620

Author: Matthias Clasen
Author Date: 2021-11-03 22:13:41 UTC

Add a few more default-ignorables

Add some more directional formatting characters
to the list of default-ignorables that we make
visible when requested: ALM, LRI, RLI, FSI, PDI.

Author: Matthias Clasen
Author Date: 2021-11-01 14:34:17 UTC

Revert "ci: Allow macos to fail"

This reverts commit e46a0fb53e92f359e739a818f0e0ce0d2fbf6c18.

We welcome the macos runner back.

Author: Matthias Clasen
Author Date: 2021-10-31 01:37:15 UTC

cairo: Small fixup

cf_priv->scaled_font is initialized on demand, it may
be NULL. So better call the getter. This was showing
up as failure in the asan test in ci.

Author: Matthias Clasen
Author Date: 2021-10-28 02:10:42 UTC

Disable failing line height tests

These need to wait until 20ec670e124e4461075
can be reapplied.

Author: Matthias Clasen
Author Date: 2021-10-19 16:29:32 UTC

Add more line height tests

Author: Matthias Clasen
Author Date: 2021-09-30 21:08:29 UTC

pangocairo: Round font metrics when appropriate

When metrics hinting is on, we used to provide rounded
font metrics. We should keep doing that since otherwise
we end up with logical rects sometimes being rounded
and sometimes not, leading to jumping empty lines.

Test included.

Fixes: #421

Author: Matthias Clasen
Author Date: 2021-09-24 16:07:17 UTC

Underline spaces again

in ada1bc9385d638e4c42, I switched to using ink rects
for horizontal underline extents, to improve the placement
of single-character underlines in the presence of
kerning. I overlooked the fact that spaces don't have ink,
so the change caused leading and trailing whitespace to
not be underlined anymore. Fix this by using the union
of ink and logical rectangles.

Fixes: #613

Author: Matthias Clasen
Author Date: 2021-09-20 00:17:27 UTC

Update script data for Unicode 14

Author: Chun-wei Fan
Author Date: 2021-09-07 02:59:31 UTC

README.win32: Update Windows build instructions

We now really require HarfBuzz, and Visual Studio 2015 or later since we are
using HarfBuzz 2.6.0 items and we have much more C99 items being used in the
code in Pango main.

Also let people know that for Visual Studio builds, Ninja builds are better
supported by Meson at this point.

Author: Matthias Clasen
Author Date: 2021-09-01 05:35:59 UTC

test-shape: Show color glyph information

Author: Matthias Clasen
Author Date: 2021-08-30 16:44:00 UTC

test-layout: Add a --show-fonts option

A bit more natural than the environment variable.

Author: Matthias Clasen
Author Date: 2021-08-30 21:05:44 UTC

tests: Test font roundtrips on MacOs

We were skipping the test that would have found
the brokenness in the previous fix. Lets see if
we can get the test working on MacOs.

Author: Matthias Clasen
Author Date: 2021-08-28 23:22:05 UTC

layout: Use pango_glyph_string_x_to_index_full

Author: Matthias Clasen
Author Date: 2021-08-28 17:41:37 UTC

pango-view: Use pango_glyph_string_index_to_x_full

Author: Matthias Clasen
Author Date: 2021-08-28 15:28:45 UTC

layout: Use char_offset in a few places

There is more we can do here, but this is a start.

Author: Matthias Clasen
Author Date: 2021-08-27 19:27:04 UTC

renderer: Use ink rects for line lengths

When rendering underlines and the like, we should use
ink extents, since the logical extents will get shortened
by kerning, which can be pretty noticable when underlining
individual glyphs, such as the T in To.

Fixes: #139

Author: Matthias Clasen
Author Date: 2021-08-27 17:59:55 UTC

pango-view: Allow showing glyph ink rects

Author: Matthias Clasen
Author Date: 2021-08-21 19:42:18 UTC

layout: Validate external log attrs

These might be nonsense, better do some checks.

Author: Matthias Clasen
Author Date: 2021-08-26 05:30:31 UTC

More break tests

Author: Matthias Clasen
Author Date: 2021-08-25 18:37:24 UTC

Use ligature caret lists

Some fonts provide information about where to
place carets inside ligatures. Use it, when it
is available.

Fixes: #39

Author: Matthias Clasen
Author Date: 2021-08-22 03:54:03 UTC

Add segmentation attributes

Add attributes that let us override word and
sentence boundaries (and, indirectly, line breaks).

Tests included.

Author: Matthias Clasen
Author Date: 2021-08-25 02:57:04 UTC

Add some new tests for hyphens

Author: Matthias Clasen
Author Date: 2021-08-24 20:38:47 UTC

Add an illustration for caret metrics

Author: Matthias Clasen
Author Date: 2021-08-22 03:25:39 UTC

docs: Update some links

We have added new APIs breaking and shaping, link to them.

Author: Matthias Clasen
Author Date: 2021-08-23 02:07:50 UTC

docs: Add another illustration

Show font metrics.

Author: Matthias Clasen
Author Date: 2021-08-22 20:50:11 UTC

Sync up test file lists

We have more tests than meson knows about.

Fixes: #600

Author: Matthias Clasen
Author Date: 2021-08-22 01:37:28 UTC

build: More compiler warnings

Now that the code has been fixed, we can enable
these warnings. The flags here match what is used
in GTK.

Author: Matthias Clasen
Author Date: 2021-08-21 23:38:12 UTC

Remove leftover test files

These don't have a corresponding .break file, so
they are useless.

Author: Matthias Clasen
Author Date: 2021-08-21 23:08:32 UTC

renderer: Don't divide by zero

Before dividing by num_glyphs in draw_strikethrough,
make sure it isn't 0. This should fix reported crashes
in this function.

Fixes: #599

Author: Matthias Clasen
Author Date: 2021-08-21 04:04:38 UTC

language: Document issue with per-thread locales

Document that pango_language_get_default() assumes
a single, globale locale.

Fixes: #501

Author: Matthias Clasen
Author Date: 2021-08-21 03:22:15 UTC

Add a test for text_transform in markup

Author: Matthias Clasen
Author Date: 2021-08-20 17:27:08 UTC

Some code reorg

Reshuffle pango-attributes.c internally.

Author: Matthias Clasen
Author Date: 2021-08-20 06:07:53 UTC

layout: Fix some wrapped line start positions

Make pango_layout_index_to_pos report non-empty
pos for the first position in a wrapped line.

Author: Matthias Clasen
Author Date: 2019-07-14 04:35:14 UTC

pango-viewer: Use layout text transform

Author: Matthias Clasen
Author Date: 2019-07-14 03:20:47 UTC

Use the language we are given

pango_get_log_attrs was not using its language
argument at all. Pass it into pango_default_break
as part of the PangoAnalysis struct.

Author: Matthias Clasen
Author Date: 2021-08-19 15:34:30 UTC

Document incompatibility of tabs and justification

Not great, but these *are* conflicting features.

Fixes: #595

Author: Matthias Clasen
Author Date: 2021-08-17 19:05:03 UTC

Add a few missing const

We should only pass char * when we actually
modify the string. Everything else is const char *.

Author: Matthias Clasen
Author Date: 2021-08-17 16:01:33 UTC

Correct an error message

Update affected tests

Fixes: #598

Author: Matthias Clasen
Author Date: 2021-08-17 14:49:24 UTC

gravity: Add missing Multani script

An unfortunate oversight in 709af063 omitted Multani,
and threw the rest of the table off.

Fixes: #597

Author: Matthias Clasen
Author Date: 2021-08-17 14:49:24 UTC

gravity: Add missing Multani script

An unfortunate oversight in 709af063 omitted Multani,
and threw the rest of the table off.

Fixes: #597

Author: Matthias Clasen
Author Date: 2021-08-10 14:32:28 UTC

Add a test for pango_layout_index_to_x

Test that we can round-trip with
pango_layout_x_index (most of the time).

Author: Matthias Clasen
Author Date: 2021-08-10 13:41:28 UTC

Add an option to pango-view

Give pango-view a --justify-last-line option
to test the new PangoLayout option for this.

Author: Matthias Clasen
Author Date: 2021-08-09 21:33:37 UTC

Add more tests for move-visually

These cover more of the corner cases fixed in the
previous commits.

Author: Matthias Clasen
Author Date: 2021-08-09 01:56:43 UTC

Adapt tests

Now that we are using run extents for cursor positions,
the vertical extents aren't necessarily constant across
a line anymore. Adapt our assertions.

Author: Matthias Clasen
Author Date: 2021-08-08 20:40:12 UTC

docs: Cosmetic fixes

Author: Matthias Clasen
Author Date: 2021-08-08 15:00:41 UTC

Tweak the docs

Make the docs for pango_layout_move_cursor_visually
a bit more clear.

Author: Matthias Clasen
Author Date: 2021-08-08 05:40:08 UTC

markup: Allow specifying size as percentage

Accept values like 200%, in addition to other
ways of specifying sizes in markup.

Fixes: #23

Author: Matthias Clasen
Author Date: 2021-08-05 18:43:34 UTC

Add tests for pango_layout_move_cursor_visually

Some of these currently fail.

Author: Matthias Clasen
Author Date: 2021-08-05 00:35:18 UTC

tests: Avoid bidi in test output

When rendering the text char-by-char, use directional
controls to avoid any bidi reordering.

Author: Matthias Clasen
Author Date: 2021-08-04 22:07:40 UTC

Add a test for pango_layout_get_cursor_pos

This checks that we get split cursors in some
cases where we expect it. One of the cases was
broken until the previous commit.

Author: Matthias Clasen
Author Date: 2021-08-04 03:41:27 UTC

itemize: Ignore width in horizontal context

Changes in width only need to break runs in
vertical context.

Update tests and add a new test.

Fixes: #503

Author: Matthias Clasen
Author Date: 2021-08-02 05:47:07 UTC

itemize: Ignore width in horizontal context

Changes in width only need to break runs in
vertical context. Implementing this requires
some reorganization, since we need to compute
the resolved gravity for the next run before
determining the end of the run.

Fixes: #503

Author: Matthias Clasen
Author Date: 2021-08-02 05:17:18 UTC

itemize: Fix up gravity state initialization

itemize_state_init was setting gravity-related fields
to their initial values too late, after update_attr_iterator
has already set them to the values for the first run.

Test included.

Author: Matthias Clasen
Author Date: 2021-07-10 04:03:40 UTC

attributes: Add helper api for introspection

Add functions to cast PangoAttribute to the various
struct types, so language bindings can get at the
payload.

Fixes: #476

Author: Matthias Clasen
Author Date: 2021-07-31 18:50:09 UTC

Clean up rounding code

Add private api to get the necessary information from
the font backend, and drop the hack that was added in
d4356779945855f7cc.

Author: Matthias Clasen
Author Date: 2021-07-30 13:05:22 UTC

bidi: Don't blow the stack

Limit stack allocation to a reasonable size, so things
don't blow up when somebody hands us a ridiculous-size
paragraph.

Author: Matthias Clasen
Author Date: 2021-07-22 11:21:24 UTC

Correctly handle font attributes

pango_attr_iterator_get_attributes only returns
the innermost attribute of each kind. That is correct
for attributes that supersede each other, but not for
font descriptions, which get merged. So, keep all
font attributes in the returned list.

Update affected tests.

Author: Matthias Clasen
Author Date: 2021-07-09 23:26:19 UTC

itemize: Improve handling of spaces

Put spaces into the previous or the next item,
depending on which one has the 'better' font.
This reduces space variations in the presence
of font fallback.

See: #249

Author: Matthias Clasen
Author Date: 2021-07-10 03:08:43 UTC

Add more testcases for pango_attr_list_change

Add more cases to cover move of the branches
in this complicated function. Among other things,
this tests the fix in the previous commit.

Author: Matthias Clasen
Author Date: 2021-07-09 16:10:37 UTC

Add a few missing chars to pango_is_zero_width

The documentation for this function states that all
bidi control chars are zero width, but it was missing
the Isolate ones. Add them.

Updated tests included.

Author: Matthias Clasen
Author Date: 2021-07-09 16:01:43 UTC

Bump hb requirement to 2.2.0

We are using hb_ot_var apis in various places.
These have been introduced in harfbuzz 2.2.0.

2.2.0 is from 2018, so this should be safe.

Author: Matthias Clasen
Author Date: 2021-07-09 14:11:12 UTC

fontconfig: Ignore woff fonts

harfbuzz creates a face, but doesn't seem to find
any glyphs in woff fonts, so filter them out.

Sadly, fontfonfig does not have useful format information
about this, so we need to crudely filter by filename.

Author: Matthias Clasen
Author Date: 2021-07-08 01:43:35 UTC

pango-segmentation: Add a --text option

Change pango-segmentation to interpret its argument as
a filename, and add a --text=STRING option to specify
the text directly. This matches what pango-view does.

Author: Matthias Clasen
Author Date: 2021-07-09 11:12:34 UTC

Add a testcase for pango_attr_list_change

This recreates the scenario described in #564.
It works fine.

Author: Matthias Clasen
Author Date: 2021-07-08 00:31:54 UTC

break: Fix handling of tag sequences

Correctly classify tag characters as Grapheme_Extend,
so that we don't end up putting grapheme boundaries
in the middle of tag sequences.

Includes a test.

Author: Matthias Clasen
Author Date: 2021-07-06 21:59:41 UTC

tests: Move bidi tests to their own file

Also add some tests for bidi embedding levels.

Author: Matthias Clasen
Author Date: 2021-07-06 05:07:39 UTC

tests: Check layout properties

Add more layout properties, and check them in test-layout.
Also print out directions and cursor positions.

Update existing tests, and add more.

Author: Matthias Clasen
Author Date: 2021-07-05 23:16:25 UTC

renderer: Fix averaging of strikethroughs

In 85bdfead1b36945db251 I made consecutive runs average
their strikeout positions, but I did handle the accounting
properly, causing previous runs to influence the strikeout
of later runs, if we have to draw them separately (due to
color change).

It would be nicer to average even across color changes and
draw the line continuously in that case as well, but that
would require two passes over the runs.

Fixes: #574

Author: Matthias Clasen
Author Date: 2021-07-02 11:53:02 UTC

docs: Add some details for PangoWrap

This clarifies things for myself.

Fixes: #573

Author: Matthias Clasen
Author Date: 2021-07-01 19:09:52 UTC

fc: Drop a broken optimization

We were trying to cut short the wait for FcInit in
pango_fc_font_map_set_config. But there was a thinko:
while it is true that the fontmap which had set_config
called on it does not need to wait for FcInit anymore,
other threads fontmaps still do. Instead of making this
more complicated, just drop the optimization.

Author: Matthias Clasen
Author Date: 2021-07-01 11:13:55 UTC

Clarify docs of pango_fc_fontmap_get_config

The return value is owned by Pango. transfer=none doesn't
really work for non-GObject types, so just spell it out.

Fixes: #572

Author: Matthias Clasen
Author Date: 2021-06-30 18:07:11 UTC

tests: Be more careful about font formats

It turns out that we can still see non-scalable fonts
which report a list of sizes. Take that into account.

Fixes: #570

Author: Matthias Clasen
Author Date: 2021-06-27 15:52:34 UTC

Add missing bidi types

The api is deprecated, but it is very ugly to randomly
miss a few values here. Just add them.

Author: Matthias Clasen
Author Date: 2021-06-27 15:31:13 UTC

shape: Bring back careful rounding code

When we added the round-glyph-positions option in
c43da2d3 and b5634799, we lost some code that was careful
to round in device coordinates.

The reason we lost it is that the rounding needs fontconfig-
specific data that is only available in the backend, and the
rounding now happens in the frontend.

Bringing it back is annoying, since we've run out of vfunc
slots to get info from the backend. This commit works around
that limitation in a hacky way.

Fixes: #562

Author: Matthias Clasen
Author Date: 2021-06-27 16:46:56 UTC

gravity: Update script properties table

Our script properties table was last updated in the
Unicode 5.0 era. Add all the scripts up to Unicode 13.
For the properties, I used the same horizontal direction
as harfbuzz, and left the other properties at their
default values.

Author: Matthias Clasen
Author Date: 2021-06-19 21:07:48 UTC

Add another test for pango_attr_list_change

This tests that we handle more cases of overlapping
attributes properly.