lp:libcairo

Created by Jelmer Vernooij on 2010-01-28 and last modified on 2018-07-16
Get this branch:
bzr branch lp:libcairo

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
VCS imports
Project:
libcairo
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.freedesktop.org/git/cairo.

The next import is scheduled to run in 1 hour.

Last successful import was 4 hours ago.

Import started 4 hours ago on alnitak and finished 4 hours ago taking 25 seconds — see the log
Import started 10 hours ago on izar and finished 10 hours ago taking 20 seconds — see the log
Import started 16 hours ago on alnitak and finished 16 hours ago taking 25 seconds — see the log
Import started 22 hours ago on izar and finished 22 hours ago taking 20 seconds — see the log
Import started on 2018-07-19 on alnitak and finished on 2018-07-19 taking 25 seconds — see the log
Import started on 2018-07-18 on alnitak and finished on 2018-07-18 taking 25 seconds — see the log
Import started on 2018-07-18 on alnitak and finished on 2018-07-18 taking 20 seconds — see the log
Import started on 2018-07-18 on izar and finished on 2018-07-18 taking 20 seconds — see the log
Import started on 2018-07-18 on izar and finished on 2018-07-18 taking 20 seconds — see the log
Import started on 2018-07-17 on alnitak and finished on 2018-07-17 taking 20 seconds — see the log

Recent revisions

10505. By BehdadEsfahbod on 2018-07-16

[ft] Implement some more color conversion routines

Makes new COLR/CPAL implementation in FreeType work with cairo now.
Ie. Microsoft's Segoe UI Emoji Regular font renders (instead of
crashing cairo.)

10504. By Bryce Harrington on 2018-06-16

scaled-font: Fix glyph and cluster count checks (CID #983386)

num_glyphs and num_clusters are explicitly checked to be non-NULL at the
beginning of this routine, and by this point in the code both have been
deref'd multiple times, so checking them for NULL here again is
superfluous.

It looks like the intent here is to verify the glyphs and clusters
arrays are non-NULL unless their counts are zero, so change the tests
accordingly.

Coverity ID: #983386

Signed-off-by: Bryce Harrington <email address hidden>

10503. By Bryce Harrington <email address hidden> on 2018-06-13

gl: For glesv3 detection, use glesv2.pc + header check

There is no glesv3.pc provided by mesa, perhaps because
the glesv3 support is provided by the libGLESv2 library.
Don't bother testing for glesv3.pc, just check for glesv2.pc
and then search for the gl3.h header file.

This fixes an issue reported by Theo Veenker, where building
with glesv3 enabled would result in a cairo.pc file that depends
on the non-existant glesv3.pc.

10502. By Bryce Harrington on 2018-06-13

polygon-intersection: Clarify ptr checks for right edges (CID #1160730)

The code is checking a variable is non-NULL after it's already been
dereferenced in an assert.

I'm not certain whether the assert should be conditionalized to only be
tested when right != NULL (which would allow edges_end() to still be
invoked), or if the function should assert right as non-NULL always.

Coverity ID: #1160730
Signed-off-by: Bryce Harrington <email address hidden>
Reviewed-By: Uli Schlachter <email address hidden>

10501. By Bryce Harrington on 2018-06-13

type1-subset: Fix incorrect null ptr check from find_token() (CID #1160662)

subrs was already tested for NULL prior to this, and will never be NULL
at this point. Meanwhile, find_token()'s return is unchecked (it can
return NULL and is checked in all other calls). Quite clearly, this is
a copy-paste error from the prior find_token call, and the intent was to
check array_start not subrs.

Coverity ID: #1160662
Signed-off-by: Bryce Harrington <email address hidden>
Reviewed-By: Uli Schlachter <email address hidden>

10500. By Bryce Harrington on 2018-06-13

pdf: Fix potential null ptr deref when creating smask groups (CID #1159559)

Patch 37a22669 improved performance by using bounding box extents.
However, the code appears to be incorrect. If extents is non-NULL it
copies its contents to group->extents, otherwise it sets group->extents
to sensible defaults, but then goes ahead and tries to copy the
undefined contents. This second copy is unnecessary if extents is
non-NULL and will cause a crash if it is NULL.

Drop the extra copy, guessing it's just a typo.

Coverity ID: #1159559
Signed-off-by: Bryce Harrington <email address hidden>
Reviewed-By: Uli Schlachter <email address hidden>

10499. By Bryce Harrington on 2018-06-13

bo: Free event_y in case of error to prevent memory leak (CID ##1160682)

If the call to _cairo_malloc_ab_plus_c() fails, it returns an error
without first freeing event_y.

Coverity ID: #1160682
Signed-off-by: Bryce Harrington <email address hidden>
Reviewed-By: Uli Schlachter <email address hidden>

10498. By Bryce Harrington on 2018-06-13

snapshot: Don't use extra after it's been freed (CID #220086)

Note this changes the semantics of the value of extra_out such that it
is set to NULL instead of left undefined in case an error is returned.

Coverity ID: 220086
Signed-off-by: Bryce Harrington <email address hidden>
Reviewed-By: Uli Schlachter <email address hidden>

10497. By Bryce Harrington on 2018-06-13

bo: Check null return from _cairo_malloc_ab() (CID #1159556)

_cairo_malloc_ab() can return NULL under some circumstances, and all
other callers of this routine in the Cairo codebase check its return, so
do so here as well.

Coverity ID: #1159556
Signed-off-by: Bryce Harrington <email address hidden>
Reviewed-by: Uli Schlachter <email address hidden>

10496. By Bryce Harrington on 2018-06-13

script-surface: Check for invalid ids (CID #1159557, 1159558)

If the bitmap's min is non-zero, _bitmap_next_id() could break out of
its loop early, before initializing the prev variable. prev would then
be dereferenced without a null ptr check. This condition should never
occur in practice, so add an assert() to assure it doesn't.

Same issue is present in trace.c.

Coverity IDs: #1159557, #1159558
Reviewed-By: Uli Schlachter <email address hidden>
Signed-off-by: Bryce Harrington <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers