lp:~vcs-imports/gtk/+git/gtk

Author: Matthias Clasen
Author Date: 2023-12-09 04:23:07 UTC

dmabuf:Support upside-down dmabufs

Add a y-invert flag to GdkDmabufTextureBuilder, and handle it
when passing dmabufs to the compositor, when downloading them,
and when using them in GL.

Fixes: #6258

Author: Simon McVittie
Author Date: 2023-12-08 16:42:56 UTC

gsk: Always use RGBA on big-endian architectures

The memorytexture test started failing on big-endian CPUs while using
"desktop" GL (not GLES) in commit b0e26873 "gsk: Use has_bgra in more
places". The subsequent commit f5812808 "gsk: Restore bigendian support"
was meant to fix this, but it seems it did not.

Always taking the RGBA code-path on big-endian might not be optimal,
but it seems to result in the test passing again.

Signed-off-by: Simon McVittie <smcv@debian.org>
Resolves: https://gitlab.gnome.org/GNOME/gtk/-/issues/6260

Author: Artur S0
Author Date: 2023-11-27 16:11:08 UTC

Update Russian translation

Author: Nelson Benitez
Author Date: 2023-11-12 21:45:18 UTC

fix detection of gio/gdesktopappinfo.h

Header file gio/gdesktopappinfo.h is currently never found
by Meson because it's inside gio-unix-2.0 directory.

This bug was introduced by commit 13b94dab10e which
fixed the build for MacOS but caused the header file
to not be detected by Linux anymore.

One possible fix would be to replace 'gio/gdesktopappinfo.h'
with 'gio-unix-2.0/gio/gdesktopappinfo.h', but as it's a
unix only header we move the check to an appropiate place
where other unix specific handling is done.

Author: Matthias Clasen
Author Date: 2023-10-29 01:41:37 UTC

testsubsurface: Add dmabuf support

Author: Matthias Clasen
Author Date: 2023-10-25 20:32:40 UTC

Fix up downloader selection

The mmap downloader is now added last, so we checking the downlaoders
list in order no longer prefers the mmap downloader. To fix that, just
select it explicitly if the format is linear.

Author: Matthias Clasen
Author Date: 2023-10-22 00:29:47 UTC

dmabuf: Some debugging infrastructure

Add some helpers to print dmabuf formats.

Author: Matthias Clasen
Author Date: 2023-10-21 11:51:30 UTC

Switch the shader to version 300

Still works!

Author: Emmanuele Bassi
Author Date: 2023-10-19 12:23:46 UTC

Update CODEOWNERS file

GitLab has standardised the CODEOWNERS file and made it available on
self-hosted instances.

Author: Luca Bacci
Author Date: 2023-10-18 14:02:03 UTC

GtkIMContextIM: Avoid committing NULL string

We may get invalid UTF-16 by PostMessage / SendMessage
or even third party hooks. Validate the Unicode string
before committing.

Fixes https://gitlab.com/inkscape/inbox/-/issues/4075

Author: Matthias Clasen
Author Date: 2023-10-18 02:29:20 UTC

glcontext: debug spew

Author: Matthias Clasen
Author Date: 2023-10-14 00:26:19 UTC

Make a test app with dma heaps

This uses the dma-heap kernel api to create a dma-buf
and use it for a GdkDmabufTexture. It supports a few
formats to test how well GL conversion of YUV works.

The YUV code is adapted from weston tests.

Author: Matthias Clasen
Author Date: 2023-10-16 05:02:19 UTC

wip: test download of dmabuf textures

Author: Matthias Clasen
Author Date: 2023-10-15 15:54:27 UTC

hacks

Author: Christian Hergert
Author Date: 2023-10-12 19:14:13 UTC

strawman: add support for constraining resize

compute-size, while aiming to constrain a size, doesn't actually do that
at all for situations where you want to keep the window from resizing
beyond certain increments.

This particular change to GdkToplevel is enough to be able to implement
that in an application by constraining the xdg_toplevel.configure pending
size sent from the display server.

We could also keep this in a specific back-end if the portability of it
was a concern.

This is enough to be able to make a GTK 4 based gnome-terminal resize in
line increments.

However we might want to give more feedback here so that the caller knows
the GdkToplevelState to avoid constraining in maximized/etc scenarios.

Author: Matthias Clasen
Author Date: 2023-10-11 14:04:48 UTC

a11y: try to fix this one more time

This api is really unfortunate. The interpretation
of start, end and text seems semi-random :(

Author: Matthias Clasen
Author Date: 2023-10-10 19:07:38 UTC

wip: gtk4-demo add a yuv video

Author: Matthias Clasen
Author Date: 2023-10-10 22:54:27 UTC

a11y: Avoid a crash

It is not safe to access text[end],
if text may not be NUL-terminated.

Fixes: #6146

Author: Matthias Clasen
Author Date: 2023-10-09 17:27:27 UTC

wayland: Try again to fix the version check

Author: Matthias Clasen
Author Date: 2023-10-06 16:40:43 UTC

wip: Try using EXT_OES_EGL_image_external

This only has a chance of working with GLES,
but doesn't.

Author: Christian Hergert
Author Date: 2023-10-06 03:30:00 UTC

gsk/gl: add fast path for texture masking color

This is useful for colorizing in the same fashion we do for the glyph
texture atlas. In fact, for small GdkTexture, you will end up in something
like the icon texture atlas.

The primary motivator for this optimization is to draw various glyph-like
features from VTE such as many forms of boxes, lines, arrows, etc.

Author: Michael Catanzaro
Author Date: 2023-10-04 14:04:51 UTC

urilauncher: do not use portal for opening help URIs

Using the OpenURI portal to open help: URIs guarantees they will be
opened in host yelp, which cannot see documentation for flatpak
applications. We need to use the flatpak runtime's yelp instead.

Fixes #6135

Author: Chun-wei Fan
Author Date: 2023-10-04 06:33:09 UTC

gsk/gskcurve.c: Avoid returning value in void-retype function

This is considered a compiler error with later GLib releases with Visual Studio
builds, so avoid that.

Author: Daniel Boles
Author Date: 2023-07-09 09:20:03 UTC

theme: Use $button_transition on check+radio nodes

This makes the change in the previous commit transition nicely, as with
'normal' buttons.

Author: Daniel Boles
Author Date: 2023-09-19 09:47:56 UTC

MenuButton: doc :menu-model doesnʼt clear :popover

It presumably used to, but now the existing :popover is replaced with a
non-NULL one that GTK creates automatically from the new :menu-model.

Author: Nelson Benitez
Author Date: 2023-09-30 20:42:07 UTC

Fix segmentation fault when running GTK4

Trying to run any GTK4 app with current GTK main branch results
in a segmentation fault in my system. Caused by code assuming
a GError must be present, but it is not because the functions
supposed to return a GError hit first a g_return_val_if_fail()
which makes them return FALSE without filling the GError out
parameter.

When the fix in here I can run GTK4 apps again, with some
g_critical() messages printed to the console because of
the g_return_val_if_fail() hit, but that seems to not affect
the execution, they are related to some renderers not being
found.

Author: Matthias Clasen
Author Date: 2023-09-27 01:59:57 UTC

Store synthetic font params in the text node

This lets use reduce the overhead by doing the
fontconfig calls only once, instead of every
time.

Author: Matthias Clasen
Author Date: 2023-07-01 21:22:21 UTC

gsk: Make glyphy optional for now

Enable glyphy by default, but make it possible
to get the previous cairo rendering by setting
GSK_DEBUG=no-glyphy in the environment.

Keeping this optional will make it easier to
debug issues and compare output.

Author: Matthias Clasen
Author Date: 2023-07-02 01:26:30 UTC

tools: Add more commands to gtk4-path-tool

Add pathops.

Author: Matthias Clasen
Author Date: 2023-09-05 20:45:27 UTC

path-tool: Show intersections

Author: Matthias Clasen
Author Date: 2023-09-22 16:22:26 UTC

Mark Arabic text as 'needs offscreen'

Arabic is a cursive script, and regularly has
overlapping contours between glyphs, which will
cause ugly artifacts when rendererd with translucency,
unless we use an offscreen.

Author: Claudio Saavedra
Author Date: 2023-09-21 15:26:09 UTC

gdk/win32: remove drag animation source on finalize

The drag animation source needs to be removed when the drag
object is finalized, otherwise it's possible that the source
stays in the main loop after even after the object is gone.

Fixes #6108

Author: Matthias Clasen
Author Date: 2023-09-21 02:42:15 UTC

wip: pathbuilder: Hide artificial joins

When splitting quads or cubics at cusps, add
a single-point quad to indicate that we want
a round join here.

Author: Daniel Boles
Author Date: 2023-09-19 09:54:20 UTC

MenuButton: doc :menu-model does set :pop[over|up]

GTK3 version of https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6408

Author: Corey Berla
Author Date: 2023-09-14 03:27:26 UTC

Revert "gtkfilechooserwidget: fix "Visit file" not scrolling to file"

This reverts commit fec3f0191a8bce21074a881f37b98f4035fc54a6

Author: Nelson Benitez
Author Date: 2023-09-10 13:35:42 UTC

Add API to center listview/columnview items when scrolling

 · A new GtkScrollInfoCenter enum with the different center flags to use
   in scroll_to() functions:

     GTK_SCROLL_INFO_CENTER_ROW: This will center the target
       row item along the visible part of list. If target
       row is already visible, will do nothing.

     GTK_SCROLL_INFO_CENTER_ROW_ALWAYS: Like `GTK_SCROLL_INFO_CENTER_ROW`
       but will work even if target row is already visible.

     GTK_SCROLL_INFO_CENTER_COL: When scrolling to a column
       item in a columnview, this will center it across the
       visible part of list. If target column is already
       visible, will do nothing.

     GTK_SCROLL_INFO_CENTER_COL_ALWAYS: Like `GTK_SCROLL_INFO_CENTER_COL`
       but will work even if target column is already visible.

 · A new GtkScrollInfo public field called `center_flags` to
     store how we want to center target row/column as a set of
     the new GtkScrollInfoCenter enum values.

 · Action "list.scroll-to-item" gains a new GtkScrollInfoCenter
   flag parameter named @center_flags, but ensuring that the
   previous action with no parameter keeps working.

Some widgets are also added to gtk4-demo program to easily
test/demo the scrolling_to() functionality, it's in the panel
"Lists -> Characters" and can be directly run with:

  gtk4-demo --run=listview_ucd

Author: Corey Berla
Author Date: 2023-09-04 18:18:37 UTC

gtkfilechooserwidget: Stop leaking bitsets

Author: Zander Brown
Author Date: 2023-08-30 00:03:27 UTC

filechooserutils: add fallback name to themed icons

Instead of using the misleading `gtk_icon_theme_has_gicon`, which for
non-themed simply assumes they exist without even trying to check, and
for themed icons ends up taking locks to do unnecessary cache validation
that also gets done when we actually resolve the thing later, simply add
the fallback name to a themed icons list — providing the same result as
the existing code

More broadly we may want to consider deprecating
`gtk_icon_theme_has_gicon`, I also wonder if perhaps GIO should include
`text-x-generic` as a default icon.

Author: Matthias Clasen
Author Date: 2023-08-29 16:18:49 UTC

composetable: Warn for things we can't handle

The compose table stores the keyvals to match against
in a guint16 array, so it can't handle directly encoded
Unicode codepoints (which have a high bit set). Warn
if we encounter those.

Author: Bilal Elmoussaoui
Author Date: 2023-08-29 15:18:49 UTC

gsk: Export GLRenderer header

Otherwise it is not possible to instantiate a GskGLRenderer without hacks like manually including gskglrenderer.h

Author: Matthias Clasen
Author Date: 2023-08-29 04:38:26 UTC

path-tool: Add a dash command

This is the obvious wrapper around gsk_path_dash.

Author: Matthias Clasen
Author Date: 2023-08-26 03:10:04 UTC

Add more fill and stroke node tests

Author: Matthias Clasen
Author Date: 2023-08-26 01:25:27 UTC

Revise gsk_path_foreach

Make this struct-based.

Author: Corey Berla
Author Date: 2023-08-23 18:08:16 UTC

inscription: Implement buildable for attributes

This is a copy and paste from gtklabel.

Author: Matthias Clasen
Author Date: 2023-08-16 13:41:24 UTC

Add the randomized segment test

This produces bad split examples quickly.

Author: Matthias Clasen
Author Date: 2023-08-22 01:19:13 UTC

Make gsk_path_builder_add_contour public

This allows to split a path into contours
without losing their closedness.

Author: Matthias Clasen
Author Date: 2023-08-17 16:43:46 UTC

gtk-demo: Add a spinbutton to the path walk

Let the user pick how many arrows to show,
to explore performance implications.

Author: AsciiWolf
Author Date: 2023-08-16 19:39:03 UTC

Update Czech translation

Author: Matthias Clasen
Author Date: 2023-08-14 14:14:29 UTC

Move path point getters to GskPath

This is more in line with treating GskPathPoint as just
a struct, not an object. And gi-docgen already puts the
apis there anyway. As an extra bonus, the function names
get shorter.

Update all callers.

Author: Benjamin Otte
Author Date: 2023-08-14 00:00:52 UTC

demos: Add an animation demo

Author: Benjamin Otte
Author Date: 2023-08-14 00:00:52 UTC

demos: Add an animation demo

Author: Matthias Clasen
Author Date: 2023-08-12 20:09:31 UTC

Add rounded rects to the tests

Author: Matthias Clasen
Author Date: 2023-08-12 13:04:34 UTC

Pencil in the no-LUT approach

If we don't use a LUT, we have to handle the
one curve the point in question falls in every
time, which is some overhead, but it lets us
compute precise values.

Author: Matthias Clasen
Author Date: 2023-08-10 12:09:18 UTC

Neuter some tests that assume special contours

Author: Matthias Clasen
Author Date: 2023-08-09 13:31:17 UTC

Make measure data smaller

We are not using the points at all, so no need to
store them. The measure data is really just a
lookup table for t -> distance.

Author: Matthias Clasen
Author Date: 2023-08-08 15:06:35 UTC

Add gsk_path_get_previous/next_point

These functions let you iterate over the 'significant'
points of a path.

Author: Matthias Clasen
Author Date: 2023-08-07 15:23:54 UTC

Add a rectangle contour

This is a simple custom contour for rectangles.

Author: Matthias Clasen
Author Date: 2023-06-26 12:41:08 UTC

tools: Add gtk4-path-tool

This comes in handy for testing, among other things.

For now, this supports decomposing,
reversing, restricting, rendering and preview.

Author: Mohammed Sadiq
Author Date: 2023-08-06 06:28:05 UTC

textbuffer: Return GObject properties on get_can_redo/undo

It's possible that the textbuffer has been subclassed and
have overridden 'can-redo' or 'can-undo' properties.

gtk_text_buffer_get_can_redo()/undo() should return those
overridden properties in those cases so that the users of the
API (eg: The 'Redo' or 'Undo' button in the text-view context
menu) behaves properly.

Author: Matthias Clasen
Author Date: 2023-08-05 14:57:47 UTC

Make points stack-allocated

This does the necessary reshuffling to make GskPathPoint
a stack-allocated struct.

Author: Matthias Clasen
Author Date: 2023-06-26 12:41:08 UTC

tools: Add gtk4-path-tool

This comes in handy for testing, among other things.

For now, this supports decomposing,
reversing, restricting, rendering and preview.

Author: Matthias Clasen
Author Date: 2023-07-28 08:25:41 UTC

4.12.0

Author: Matthias Clasen
Author Date: 2023-08-05 01:47:54 UTC

Clean up headers

Move the private scrollinfo api to just the private
header, and include it where needed.

Author: Matthias Clasen
Author Date: 2023-08-02 14:50:48 UTC

reftests: Fix one reftest

The xalign property of GtkLabel defaults to 0.5,
meaning that the contents will be centered, which
is not what GtkInscription does.

Author: Benjamin Otte
Author Date: 2023-07-31 14:02:22 UTC

vulkan: Make winding number computation more stable

Instead of just counting the roots, evaluate the y value between the
roots to ensure that the sign really did switch.

Gets rid of spurious winding number changes causing horizontal lines.

What is still causing horizontal lines is that the root solver misses
roots from time to time.

Author: Matthias Clasen
Author Date: 2023-07-02 01:26:30 UTC

tools: Add more commands to gtk4-path-tool

Add pathops.

Author: Matthias Clasen
Author Date: 2023-07-12 10:03:41 UTC

wip: port curve-editor to GtkContour

Not quite done.

Author: Matthias Clasen
Author Date: 2023-07-01 21:22:21 UTC

gsk: Make glyphy optional for now

Enable glyphy by default, but make it possible
to get the previous cairo rendering by setting
GSK_DEBUG=no-glyphy in the environment.

Keeping this optional will make it easier to
debug issues and compare output.

Author: Matthias Clasen
Author Date: 2023-07-02 13:32:40 UTC

glyphy: Add a few comments

Make this a bit more understandable.

Author: Matthias Clasen
Author Date: 2023-07-11 23:55:23 UTC

Add GtkContour

Author: Nelson Benitez
Author Date: 2023-07-09 05:46:54 UTC

widget-factory: add example on styling tooltip window

by using new api:
  gtk_tooltip_set_css_class()
  GtkWidget signals 'tooltip-show' and 'tooltip-hide'

Part of #5925

Author: Matthias Clasen
Author Date: 2022-04-08 02:51:29 UTC

Add a private getter for the stroke path

We will implement stroking by filling the stroke path.

Compute the stroke path ahead of time, so we don't have
to do it over and over.

This may change in the future, at least for simple
strokes, so keep this private.

Author: Matthias Clasen
Author Date: 2023-07-06 15:39:38 UTC

wip: api for exact points

Author: Matthias Clasen
Author Date: 2020-12-20 16:19:43 UTC

Add a test for tangents of degenerate curves

The stroker relies on these to work.

Author: Matthias Clasen
Author Date: 2023-06-26 12:41:08 UTC

tools: Add gtk4-path-tool

This comes in handy for testing, among other things.

For now, this supports decomposing, transforming,
reversing, restricting, rendering and preview.

Author: Matthias Clasen
Author Date: 2023-07-02 04:03:33 UTC

Update affected tests

We preserve quadratics in the SVG path roundtrip
tests now.

Author: Matthias Clasen
Author Date: 2023-07-05 17:32:00 UTC

gsk_path_measure_is_closed -> gsk_path_is_closed

This is a property of the path that doesn't need
a measure to determine, so move the API to GskPath.

Author: Matthias Clasen
Author Date: 2023-07-02 01:26:30 UTC

tools: Add more commands to gtk4-path-tool

Add pathops.

Author: Matthias Clasen
Author Date: 2022-03-26 05:48:04 UTC

Add some tests for pathops

Author: Matthias Clasen
Author Date: 2023-07-05 04:28:23 UTC

tests: Remove debug spew from working tests

The poly solver has made these pass.
So no need for that debug spew anymore.

Author: Matthias Clasen
Author Date: 2023-07-04 22:27:37 UTC

theme: Adapt some of the notebook style

Make the tab bar appear similar to the way
GtkNotebook looks.

Author: Matthias Clasen
Author Date: 2023-07-02 00:55:13 UTC

path tool: Report convexity

We have the info, might as well.

Author: Benjamin Otte
Author Date: 2020-11-30 09:05:18 UTC

stroke: Add support for dashes

... and hook it up in the node parser and for Cairo rendering.

Author: Matthias Clasen
Author Date: 2023-06-26 12:41:08 UTC

tools: Add gtk4-path-tool

This comes in handy for testing, among other things.

For now, this supports decomposing, transforming,
stroking, offsetting, reversing, restricting,
pathops, rendering and preview.

Author: Emmanuele Bassi
Author Date: 2023-06-28 14:28:38 UTC

trashmonitor: Replace internal 1-bit fields with bool

Single bit fields cannot be used by address, and will overflow when
set to values that are bigger than one bit; the behaviour (if not the
size) of the C99 bool type is better defined.

Author: Matthias Clasen
Author Date: 2023-06-21 15:23:32 UTC

Deprecate gtk_popover_present

The replacement is gtk_popover_allocate.

Part of: #5431

Author: Daniel Boles
Author Date: 2023-06-21 17:28:43 UTC

Text,TextView: Deselect text on ::focus-out

We don't differentiate between foreground and backdropped selections,
which confuses/infuriates users, particularly in the FileChooser entry.
There's no design desire to introduce that differentiation in the theme.
The preferred fix is instead to clear the selection on focussing out.

This patch does that by changing the existing code that clears the
selection when the state changes and the widget is no longer :sensitive
to instead clear the selection if it's not the focus within its toplevel

https://gitlab.gnome.org/GNOME/gtk/issues/665#note_110313

Author: Daniel Boles
Author Date: 2018-03-31 12:38:19 UTC

Entry,TextView: Deselect text on ::focus-out

We don't differentiate between foreground and backdropped selections,
which confuses/infuriates users, particularly in the FileChooser entry.
There's no design desire to introduce that differentiation in the theme.
The preferred fix is instead to clear the selection on focussing out.

This patch does that by changing the existing code that clears the
selection when the state changes and the widget is no longer :sensitive
to instead clear the selection if it's not the focus within its toplevel

https://gitlab.gnome.org/GNOME/gtk/issues/665#note_110313

Author: Matthias Clasen
Author Date: 2023-06-19 23:28:48 UTC

gtk-demo: Use the new API

Make the app launcher demo get read by orca
using the new list item api.

Author: Benjamin Otte
Author Date: 2023-06-18 23:29:03 UTC

testsuite: Increase tolerances to make the path test work

I dislike the corner cases being so low (lower than 1% and off by a
whole point).

Author: Matthias Clasen
Author Date: 2023-06-17 00:26:57 UTC

printeroptiowidget: Override mnemonic_labels_changed

Set the labelled-by relationship on the control
that is contained inside the printer option widget.

Author: Matthias Clasen
Author Date: 2023-06-17 12:43:44 UTC

listview: Accessibility support

Set GTK_ACCESSIBLE_RELATION_ROW_COUNT on the listview,
and GTK_ACCESSIBLE_RELATION_ROW_INDEX on the listitemwidgets.

Author: Michael Catanzaro
Author Date: 2023-06-08 21:02:58 UTC

Avoid deprecation warnings cased by GTK_ALIGN_BASELINE_FILL

We have to be careful to only use GDK_ALIGN_BASELINE_FILL when permitted
by GDK_VERSION_MAX_ALLOWED because gtkenums.h is a public header. If
it's not allowed, then just fall back to the previous definition of
GtkAlign since they are both compatible.

I don't think we can avoid conditional compilation here, because the old
definition is going to cause deprecated declaration warnings unless you
define an old GDK_VERSION_MIN_REQUIRED.

Fixes #5875

Author: Matthias Clasen
Author Date: 2023-06-04 23:50:29 UTC

fontchooser: Flip models around

Make the fontchooser use a GtkFilterListModel
wrapping a GtkSingleSelection, instead of the
other way around. This exercises the new
selection model support in GtkFilterListModel.

Author: Matthias Clasen
Author Date: 2023-05-29 19:17:50 UTC

Add a comment

This is something that wasn't clear to me, and it
is important to know to understand how we are handling
(un)premultiplication here.

Author: Matthias Clasen
Author Date: 2023-05-27 20:05:02 UTC

gridview: Reorganize size_allocate a bit more

Treat headers more like multirow tiles, and
footers more like regular items. Also, explicitly
set the height of all tiles to 0 at the outset,
so we have a certain way to know which tiles have
already had their size set to row_height.

Author: Matthias Clasen
Author Date: 2023-05-21 11:44:04 UTC

gridview: Rewrite size_allocate

Rewrite size_allocate to use the new split_tiles
function and the multirow helper, and move the handling
of the footer tile at the end into the regular allocation
loop.

This is preparing the code to work with sections.
For now, nothing has changed.

Author: Benjamin Otte
Author Date: 2023-05-28 00:07:43 UTC

testsuite: Validate the section changing sortmodel

Author: Matthias Clasen
Author Date: 2023-05-25 19:26:18 UTC

scrollinfo: Init the refcount

Author: Matthias Clasen
Author Date: 2023-05-21 00:48:04 UTC

gridview: Add tests for tile split

These tests are reusing the section model plumbing
of the listitemmanager tests, and just check that
splitting tiles according to a certain number of
columns works