~vcs-imports/gnome-system-monitor/+git/gnome-system-monitor:gnome-system-monitor-port-bits-part-one

Last commit made on 2023-08-31
Get this branch:
git clone -b gnome-system-monitor-port-bits-part-one https://git.launchpad.net/~vcs-imports/gnome-system-monitor/+git/gnome-system-monitor

Branch merges

Branch information

Name:
gnome-system-monitor-port-bits-part-one
Repository:
lp:~vcs-imports/gnome-system-monitor/+git/gnome-system-monitor

Recent commits

599abec... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

legacy/treeview: Save a column only if it exists

I encountered an issue when closing the application which was probably
caused by TreeView misconfiguration during the GTK4 work which caused
a column to be misconfigured/incomplete. That would cause a crash during
the close sequence. So, be extra defensive and only save an existing
column.

d043d03... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Remove magic values from graph drawing & fit graphs properly

Finally the graphs won't be so annoyingly misaligned... And who's
supposed to understand the meaning of random numbers anyway?

fb64635... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Call ceil() just once

19c01ed... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Group graph properties initialization

90342b2... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Move variables to local scopes

I like to push declarations of variables as deep as possible to make it
a bit more clear when exactly those variables are being used.

309a520... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Rename draw_background() to create_beackground()

Makes more sense as it does not draw to the main surface directly. Also,
relying on global variables/class properties gets messy quickly and thus
return the background surface instead of setting the property from the
function.

8de539c... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Turn magic values into constant expressions

576de11... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Change variable from double to int

While used to calculate floats, on its own the values are integers.

0d91fba... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Make non-public functions static

8745d93... by =?utf-8?b?T25kxZllaiBNw61jaGFs?= <email address hidden>

load-graph: Reorder functions by call order

Many GTK codebases use the convention of putting static functions at the
top of the file, then they follow up with complex methods, then
constructors/destructors and then setters/getters. Let's use that
convention here.