~vcs-imports/gnome-control-center/+git/gnome-control-center:wip/corey/search-xdg

Last commit made on 2024-02-14
Get this branch:
git clone -b wip/corey/search-xdg https://git.launchpad.net/~vcs-imports/gnome-control-center/+git/gnome-control-center

Branch merges

Branch information

Recent commits

0ab1fab... by Corey Berla

search-locations-dialog: Allow multiple XDG folders to same location

Now that each place has stores an array of possible paths, use the
stored paths to compare against the tracker locations rather than
the single (possibly incorrect) stored location. This allows for
multiple xdg folders (with different paths) pointing to a single
location.

Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1265

2acf213... by Corey Berla

search-locations-dialog: Stop recreating paths

We are storing the path now, use the stored path, rather than
recreating a path from the stored location.

e6e6280... by Corey Berla

search-locations-dialog: Add comment for clarity

dece0df... by Corey Berla

search-locations-dialog: Store path in Place

Rather than recreating the path using the stored location, store the
Place's path(s). With the exception of xdg directories, this doesn't
change the behavior of paths. But for xdg directories, we can have
a single location that points to multiple paths. This commit does not
cause any change in behavior.

d2605e8... by Corey Berla

search-locations-dialog: Split out tracker dir mapping

Simplifiy the tracker dir to path mapping. This will be
more useful in the coming commit as we will want a mapping
from xdg dirs to paths.

6163f6f... by Corey Berla

search-locations-dialog: Stop using destroyed GFile

While iterating through the possible locations, we can potentially
keep destroyed GFiles in the hashtable because of the calls to
g_hash_table_insert instead of g_hash_table_replace. The
place owns the reference to the file and upon inserting a duplicate
place the place is freed (releasing the reference to the GFile).
This usually won't happen because in most cases we check for an
existing place, but during the iteration for xdg we don't check
and if two xdg directories point to the same location, we will
end up in this situtation.

Replace all calls for insert with replace to address this issue
and prevent possible future issues.

Related: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/1265

9d5371f... by Felipe Borges <email address hidden>

46.beta.2

b0ce59a... by Matthijs Velsink <email address hidden>

po: Remove POTFILES.in entry after GOA changes

Commit 08c51127 (!2039) removed gnome-control-center-goa-helper.c, but
forgot to remove the POTFILES.in entry.

This fixes that.

Fixes #2893

3ca34ff... by Matthijs Velsink <email address hidden>

po: Fix POTFILES.in for the "Remote Login" move

Commit c0c357c3 (!2211) moved the "Remote Login" code to the System
Panel, but did not change the POTFILES.in entries.

This fixes that.

959f8af... by Matthijs Velsink <email address hidden>

sharing: Clean leftover "Remote Login" code

Commit c0c357c3 (!2211) moved the "Remote Login" code to the System
panel. There are some leftover bits of code in the sharing panel though.

This cleans that up.

Closes #2895