~vcs-imports/gnome-control-center/+git/gnome-control-center:startup-notify

Last commit made on 2018-05-03
Get this branch:
git clone -b startup-notify https://git.launchpad.net/~vcs-imports/gnome-control-center/+git/gnome-control-center

Branch merges

Branch information

Recent commits

df8eccc... by Mario Sánchez Prada

Don't declare StartupNotify=true in panel-specific desktop files

As per the Startup Notification Spec, when an application declares this
in its desktop file, it the launcher (e.g. the shell) will initiate the
startup process, expecting the launchee to finish it with a "remove" X
message once it's ready, unless there's a failure launching it.

The problem here is that this panel-specific desktop files declaring that
key confuses the shell, since it will make it initiate the startup process
but then no "remove" message is ever received if g-c-c was already running,
since the newly launched process will realize it's not the main instance and
will exit gracefully after handing over control of the situation to the
original process, with exit code 0, leaving the startup process unfinished.

Due to this, the shell will keep waiting for a supposedly new application
(as per the the panel-specific desktop file used to launch) to finish, which
will result in the cursor to keep spinning after the app is discarded by the
shell on a timeout.

We should fix this in a more general way (see [2]), since apps exiting due
to handing control over to a previous instance should still send the "remove"
message, but in the meantime let's make our user's lives better by not
declaring this key in any of the panel-specific desktop files.

[1] https://www.freedesktop.org/wiki/Specifications/startup-notification-spec
[2] https://bugzilla.gnome.org/show_bug.cgi?id=795779

af0186a... by Georges Basile Stavracas Neto

project: Update meson files

I probably have OCD. Seeing these files
with this poor alignment gives me physical
pain.

36af5e5... by Georges Basile Stavracas Neto

shell-model: Remove boilerplate and update code style

3228632... by Georges Basile Stavracas Neto

project: Update DOAP file

The maintainers listed there aren't maintaining it anymore,
and shouldn't be pinged about Settings. Please let me know
if any of you want your maintainership status back again.

70b346d... by Georges Basile Stavracas Neto

project: Add coding style and contribution guidelines

And also update the README file.

16f0666... by Georges Basile Stavracas Neto

window, shell-model: Silence warnings

A fallback from the previous commit.

4b91361... by Georges Basile Stavracas Neto

project: Add issue templates

37b06c1... by Benjamin Berg <email address hidden>

ci: Do not run install for testing

There is no need to install g-c-c to run the tests, and in fact, we
should ensure that this is the case as it simplifies testing for e.g.
distributions.

f655e46... by Benjamin Berg <email address hidden>

tests/network: Add basic testing of network panel

This adds tests for the network panel based on the test service found in
NetworkManager. Another possible solution may be to use the one from
dbusmock, however NetworkManager already has readily available code to
write tests in C which makes checking the widget hierarchy easier.

7630bf9... by Benjamin Berg <email address hidden>

tests: Add helper for glib based test binaries

This makes running glib based tests inside a dbusmock environment easier
and more beautiful (i.e. output is supressed unless an error occurs).

This helper has been submitted for inclusion in dbusmock. If it cannot$
live there in some form, then we should try to find a home in the GNOME$
project for it.$