907e5cf...
by
Matthijs Velsink <email address hidden>
display: Fix crash from closing lid
When closing the lid on a laptop, the number of active monitors drops to
zero. However, `monitor_labeler_show()` always assumes at least one
monitor is active, as it unconditionally closes the `GVariantBuilder`.
This causes a crash when there is no monitor added to the
`GVariantBuilder`, however, as no value was added to it.
Instead, only close the `GVariantBuilder` when we're actually going to
use it and know a value was added.
Commit ca9228bb fixed a similar crash for when there are no outputs at
all. But in this case, there is still an output, it is just not active,
only with the active UI number as 0.
Fixes #3058
(cherry picked from commit 08e32e95730eeb18b69d5cc3647bd63ce10d5e26)
2bec32d...
by
Matthijs Velsink <email address hidden>
universal-access: Fix icon name in .desktop file
The full icon name is `org.gnome.Settings-accessibility-symbolic`. Even
though it was still being found due to the way icon lookup works, the
Fedora Update System (bodhi) Automated Testing tagged this with
Desktop file /usr/share/applications/gnome-universal-access-panel.desktop
on x86_64 references icon org.gnome.Settings-accessibility but no
subpackages contain org.gnome.Settings-accessibility
So, fix that.
(cherry picked from commit fd651824d95c588010ff0191c8cac1eb2d41f1f0)
967b4d3...
by
Felipe Borges <email address hidden>
45.4
42b0552...
by
Matthijs Velsink <email address hidden>
display: Fix crash due to shortcut propagation phase
For a managed GtkShortcutController, changing its propagation phase
away from `GTK_PHASE_BUBBLE` currently results in a lingering reference
due to a bug in GTK (gtk#6246). This means the Escape key shortcut
remains active even after leaving the Display panel, resulting in a
crash when pressing Escape in any panel after leaving the Display panel.
This is now fixed in GTK (gtk!7115), but there seems to be no reason for
changing the propagation phase at all anyways. Since the callback
returns `GDK_EVENT_PROPAGATE` when it does not activate, the event
should still make it to other handlers.
So, to speed up the fix for gnome-control-center, we remove the
propagation phase changes althogether. There is also no need to let the
shortcut have global scope, managed is enough.
Closes #2768
(cherry picked from commit e7e9753aacae7d6b4ee80824630057a9a30e9b7d)
(cherry picked from commit 9eb2576f893569e852bf2bfef792eb8a2927d150)
bfa3a1c...
by
=?utf-8?q?Luk=C3=A1=C5=A1_Tyrychtr?= <email address hidden>
universal-access: Add a few activatable widgets in the typing page
This also fixes missing a11y labels for the sliders.
Fixes #2998.
(cherry picked from commit c3483b3a685a0291e19276b17e92815402a054a3)
(cherry picked from commit 06472e320d707bc79443df8e090871268fc2f75d)
b4609b6...
by
Maximiliano Sandoval <email address hidden>
privacy: Remove rows that had their perms reset
When a permission for an app is reset, e.g. via:
flatpak permission-reset APP_ID
the Changed signal simply contains one fewer entry in its dictionary. If
we had a row for an app_id, and such app_id is not in the new
permissions we remove the row from the list box.
