lp:busybox

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

17710. By Ron Yorston <email address hidden> on 2023-08-31

tsort: avoid use-after-free

When the input data contained a cycle it was possible for tsort to
attempt to access freed nodes. This sometimes resulted in the
test case 'echo a b b a | tsort' crashing.

Don't free nodes when they're removed from the graph.

function old new delta
tsort_main 621 596 -25
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-25) Total: -25 bytes

Signed-off-by: Ron Yorston <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17709. By zhuyan <email address hidden> on 2023-08-31

ash: initialize basepf.buf in ash

When I planned to print the command in read_line_input, I found that after
the system started, the command printed for the first time was always
garbled.

After analysis, it is found that in the init() function of ash, the
variable basepf.buf is not initialized after applying for memory, resulting
in garbled initial data. Then assign it to the global variable
g_parsefile->buf in ash.c, and then pass g_parsefile->buf to the parameter
command of the function read_line_input in the function preadfd(), and
finally cause it to be garbled when the command is printed by
read_line_input.

The call stack is as follows:
 #0 read_line_input (st=0xb6fff220, prompt=0xb6ffc910 "\\[\\033[32m\\]\\h \\w\\[\\033[m\\] \\$ ", command=command@entry=0xb6ffc230 "P\325\377\266P\325\377\266", maxsize=maxsize@entry=1024) at libbb/lineedit.c:2461
 #1 0x0043ef8c in preadfd () at shell/ash.c:10812
 #2 preadbuffer () at shell/ash.c:10914
 #3 pgetc () at shell/ash.c:10997
 #4 0x00440c20 in pgetc_eatbnl () at shell/ash.c:11039
 #5 0x00440cbc in xxreadtoken () at shell/ash.c:13157
 #6 0x00440f40 in readtoken () at shell/ash.c:13268
 #7 0x00441234 in list (nlflag=nlflag@entry=1) at shell/ash.c:11782
 #8 0x004420e8 in parsecmd (interact=<optimized out>) at shell/ash.c:13344
 #9 0x00442c34 in cmdloop (top=top@entry=1) at shell/ash.c:13549
 #10 0x00444e4c in ash_main (argc=<optimized out>, argv=0x444e4c <ash_main+1328>) at shell/ash.c:14747
 #11 0x00407954 in run_applet_no_and_exit (applet_no=9, name=<optimized out>, argv=0xbefffd34) at libbb/appletlib.c:1024
 #12 0x00407b68 in run_applet_and_exit (name=0xbefffe56 "ash", argv=0x9) at libbb/appletlib.c:1047
 #13 0x00407f88 in main (argc=<optimized out>, argv=0xbefffd34) at libbb/appletlib.c:1181

Fixes: 82dd14a510ca ("ash: use CONFIG_FEATURE_EDITING_MAX_LEN")

Signed-off-by: zhuyan <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17708. By Vda-linux on 2023-07-18

libbb: rename source files, no code changes

Signed-off-by: Denys Vlasenko <email address hidden>

17707. By Vda-linux on 2023-07-17

introduce and use exitcode_t

function old new delta
strings_main 422 420 -2
setfattr_main 175 173 -2
brctl_main 1548 1546 -2
makedevs_main 979 975 -4
rev_main 337 332 -5
getfattr_main 307 302 -5
cut_main 1201 1196 -5
cksum_main 398 393 -5
umount_main 573 565 -8
ln_main 516 508 -8
expand_main 660 652 -8
df_main 1068 1060 -8
renice_main 346 332 -14
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/13 up/down: 0/-76) Total: -76 bytes

Signed-off-by: Denys Vlasenko <email address hidden>

17706. By Vda-linux on 2023-07-17

getfattr: fix "getfattr NOTEXIST" - now prints error msg

function old new delta
getfattr_main 309 307 -2
.rodata 105395 105391 -4
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-6) Total: -6 bytes

Signed-off-by: Denys Vlasenko <email address hidden>

17705. By YU Jincheng <email address hidden> on 2023-07-16

getfattr: new applet

function old new delta
getfattr_main - 309 +309
print_attr - 115 +115
packed_usage 34576 34631 +55
.rodata 105349 105395 +46
lgetxattr - 41 +41
getxattr - 41 +41
llistxattr - 35 +35
listxattr - 35 +35
applet_names 2806 2815 +9
applet_main 1620 1624 +4
------------------------------------------------------------------------------
(add/remove: 7/0 grow/shrink: 4/0 up/down: 690/0) Total: 690 bytes

Signed-off-by: YU Jincheng <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17704. By Vda-linux on 2023-07-14

hwclock: force LONG_OPTS, stop accepting non-compatible -t

function old new delta
hwclock_main 576 579 +3
.rodata 105404 105349 -55
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 1/1 up/down: 3/-55) Total: -52 bytes

Signed-off-by: Denys Vlasenko <email address hidden>

17703. By Andrej Picej <email address hidden> on 2023-07-12

hwclock: add get/set parameters option

In kernel 5.16 special ioctls were introduced to get/set RTC parameters.
Add option to get/set parameters into busybox version of hwclock.
Implementation is similar to the one already used in linux-utils hwclock
tool.

Example of parameter get use:
$ hwclock -g 2
The RTC parameter 0x2 is set to 0x2.
$ hwclock --param-get bsm
The RTC parameter 0x2 is set to 0x2.

Example of parameter set use:
$ hwclock -p 2=1
The RTC parameter 0x2 will be set to 0x1.
$ hwclock -p bsm=2
The RTC parameter 0x2 will be set to 0x2.

function old new delta
hwclock_main 298 576 +278
.rodata 105231 105400 +169
packed_usage 34541 34576 +35
static.hwclock_longopts 60 84 +24
------------------------------------------------------------------------------
(add/remove: 0/0 grow/shrink: 4/0 up/down: 506/0) Total: 506 bytes

Signed-off-by: Andrej Picej <email address hidden>
Signed-off-by: Denys Vlasenko <email address hidden>

17702. By Vda-linux on 2023-07-10

ntpd: fix a warning on 32-bit arch build

Signed-off-by: Denys Vlasenko <email address hidden>

17701. By Vda-linux on 2023-07-10

i2ctransfer: fix build warning

Signed-off-by: Denys Vlasenko <email address hidden>