~vcs-imports/balsa/+git/balsa:popover

Branch merges

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

f6e659e... by Peter Bloomfield <email address hidden> on 2020-09-13

Various: Use stateless GActions with targets

Use stateless GActions with targets instead of setting GObject data on
random objects.

If the GAction is given a non-NULL parameter type but no state and no
"change state" callback, it is rendered as stateless, and the target can
be retrieved from the GVariant parameter of the "activated" callback. The
target cannot be an arbitrary pointer, and is in fact a string in all
these cases:

* libbalsa/libbalsa-vfs.c (libbalsa_vfs_launch_app),
  (libbalsa_vfs_launch_app_for_body), (gio_add_vfs_menu_item),
  (libbalsa_vfs_fill_menu_by_content_type),
  (libbalsa_vfs_mime_button):
* libbalsa/libbalsa-vfs.h:
* src/balsa-index.c (move_to_activated), (bndx_add_actions),
  (bndx_do_popup):
* src/balsa-mblist.c (balsa_mblist_mru_menu),
  (balsa_mblist_mru_get_url_from_variant),
  (balsa_mblist_mru_get_mailbox_from_variant):
* src/balsa-mblist.h:
* src/balsa-message.c (open_with_activated), (copy_part_activated),
  (part_add_actions), (part_create_menu):
* src/balsa-mime-widget-callbacks.c
  (balsa_mime_widget_ctx_menu_launch_app),
  (balsa_mime_widget_ctx_menu_cb):
* src/balsa-mime-widget-callbacks.h:
* src/balsa-mime-widget-message.c (copy_activated),
  (bm_header_extend_popup):
* src/balsa-mime-widget-text.c (open_with_activated),
  (text_view_populate_popup), (bmwt_html_open_with_activated),
  (bmwt_html_populate_popup_menu), (bmwt_html_button_press_cb):
* src/message-window.c (move_to_activated), (message_window_new):
* src/sendmsg-window.c (launch_app_activated), (open_attachment),
  (add_attachment), (add_urlref_attachment):

mblist: Add guards for NULL GVariant

971f4ca... by Peter Bloomfield <email address hidden> on 2020-07-12

balsa-index: Fix a typo

3b1a732... by Peter Bloomfield <email address hidden> on 2020-07-12

Various: Drop libbalsa_{radio,toggle}_activated

Drop some more uses of libbalsa_{radio,toggle}_activated.

src/balsa-message.c
src/sendmsg-window.c
src/toolbar-factory.c

4b55368... by Peter Bloomfield <email address hidden> on 2020-07-02

balsa-mblist: Add guards

0efa7ab... by Peter Bloomfield <email address hidden> on 2020-06-28

Minor cleanup

libbalsa-vfs: Add guards
balsa-mblist.c: Correct description

3a4da49... by Peter Bloomfield <email address hidden> on 2020-06-28

Various: Improve the MRU menu helpers

Users of the menu don't need to know how the action's state is obtained
from the action and the user-data.

66f5e95... by Peter Bloomfield <email address hidden> on 2020-06-27

Various: Fill some menus with stateless GMenuItems

Fill the move-to/copy-to menus with stateless GMenuItems, so that they
are rendered without radio buttons.

Instead, pass the URL as GObject data on a convenient object.

* src/balsa-mblist.c (bmbl_add_action), (balsa_mblist_mru_menu),
  (balsa_mblist_mru_get_url), (balsa_mblist_mru_get_mailbox_from_url):
    rework balsa_mblist_mru_menu();
* src/balsa-mblist.h: revised APIs;
* src/balsa-index.c (move_to_activated), (bndx_add_actions),
  (bndx_popup_menu_create), (bndx_do_popup): use them;
* src/balsa-message.c (copy_part_activated), (part_add_actions),
  (part_create_menu): ditto;
* src/balsa-mime-widget-message.c (copy_activated),
  (bm_header_extend_popup): ditto;
* src/message-window.c (move_to_activated), (message_window_new): ditto;
* src/sendmsg-window.c (add_urlref_attachment): ditto.

a9b8c86... by Peter Bloomfield <email address hidden> on 2020-06-26

Various: Fill some menus with stateless GMenuItems

Fill the open-with menus with stateless GMenuItems, so that they are
rendered without radio buttons.

Instead of passing the app's name as the state of a stateful GMenuItem,
pass the GAppInfo itself as GObject data on a convenient object.

* libbalsa/libbalsa-vfs.c (libbalsa_vfs_launch_app),
  (libbalsa_vfs_launch_app_for_body), (gio_add_vfs_menu_item),
  (libbalsa_vfs_fill_menu_by_content_type),
  (libbalsa_vfs_mime_button):
* libbalsa/libbalsa-vfs.h:
* src/balsa-message.c (open_with_activated), (part_add_actions),
  (part_create_menu):
* src/balsa-mime-widget-callbacks.c
  (balsa_mime_widget_ctx_menu_launch_app),
  (balsa_mime_widget_ctx_menu_cb):
* src/balsa-mime-widget-callbacks.h:
* src/balsa-mime-widget-text.c (open_with_activated),
  (text_view_populate_popup), (bmwt_html_open_with_activated),
  (bmwt_html_populate_popup_menu), (bmwt_html_button_press_cb):
* src/sendmsg-window.c (attachment_menu_vfs_cb), (add_attachment):

6ebaa8b... by Peter Bloomfield <email address hidden> on 2020-06-24

mime-widget-text: Actually pop up a context menu

Actually pop up the context menu when right-clicking on an URL.

* src/balsa-mime-widget-text.c (text_view_url_popup):

f33344c... by Peter Bloomfield <email address hidden> on 2020-06-24

balsa-message: Add action-entries in a helper