Merge lp:~vbocek/unity-system-compositor/fix-hammerhead-backlight into lp:unity-system-compositor

Proposed by Vojtech Bocek
Status: Merged
Approved by: kevin gunn
Approved revision: 172
Merged at revision: 172
Proposed branch: lp:~vbocek/unity-system-compositor/fix-hammerhead-backlight
Merge into: lp:unity-system-compositor
Diff against target: 24 lines (+4/-4)
1 file modified
src/screen_state_handler.cpp (+4/-4)
To merge this branch: bzr merge lp:~vbocek/unity-system-compositor/fix-hammerhead-backlight
Reviewer Review Type Date Requested Status
Alberto Aguirre (community) Approve
Unity System Compositor Development Team Pending
Review via email: mp+233572@code.launchpad.net

Commit message

This fixes backlight problems on Nexus 5. Android does things in this order, and the kernel drivers don't work correctly if the brightness is set after the panel is powered down.

Description of the change

This fixes backlight problems on Nexus 5. Android does things in this order, and the kernel drivers don't work correctly if the brightness is set after the panel is powered down.

To post a comment you must log in.
Revision history for this message
Kevin DuBois (kdub) wrote :

change seems okay to me, working on testing a few more devices

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Works fine on all devices I tested.

review: Approve
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

@Vojtech, The MP needs a commit message so we can land it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/screen_state_handler.cpp'
2--- src/screen_state_handler.cpp 2014-08-14 19:42:15 +0000
3+++ src/screen_state_handler.cpp 2014-09-05 18:17:07 +0000
4@@ -165,6 +165,10 @@
5 //Some devices do not turn screen on properly from suspend mode
6 powerd_mediator->disable_suspend();
7 }
8+ else
9+ {
10+ powerd_mediator->turn_off_backlight();
11+ }
12
13 display->configure(*displayConfig.get());
14
15@@ -173,10 +177,6 @@
16 compositor->start();
17 powerd_mediator->set_normal_backlight();
18 }
19- else
20- {
21- powerd_mediator->turn_off_backlight();
22- }
23
24 current_power_mode = mode;
25

Subscribers

People subscribed via source and target branches