Code review comment for lp:~vbkaisetsu/tomdroid/sql-args

Revision history for this message
Piotr Adamski (mcveat) wrote :

Great, Koichi! But your fix needs one more change in my opinion. The point of using StringBuilder is to avoid explicit string concatenation, as each produces new String in strings pool. It may strike back as memory issue, so it is worth to avoid them in cases like this, where there is a lot string operations. Consider replacing each concatenation with append method call. I know it doesn't look so concise, but in that situation i think it is worth it.

Regards
Piotr

« Back to merge proposal