Merge lp:~vauxoo/web-addons/7.0-nocreatedb-link into lp:~webaddons-core-editors/web-addons/7.0

Proposed by Nhomar - Vauxoo
Status: Merged
Merged at revision: 4
Proposed branch: lp:~vauxoo/web-addons/7.0-nocreatedb-link
Merge into: lp:~webaddons-core-editors/web-addons/7.0
Diff against target: 100 lines (+83/-0)
2 files modified
web_nocreatedb/__openerp__.py (+67/-0)
web_nocreatedb/static/src/xml/web_nocreatedb.xml (+16/-0)
To merge this branch: bzr merge lp:~vauxoo/web-addons/7.0-nocreatedb-link
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Disapprove
Holger Brunn (Therp) code review Approve
OpenERP Community Reviewer/Maintainer Pending
Nhomar - Vauxoo Pending
Review via email: mp+165729@code.launchpad.net

This proposal supersedes a proposal from 2013-05-20.

Description of the change

Just hide the createdb link from the login page.

This is a common feature asked by almst all customers, it should be greate in an MP to the core, but I think it should be reviewed by us.

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote : Posted in a previous version of this proposal

Was going to ask you to remove *just* the offensive link but that would leave you with a silly '|' sign under the login window, so I approve of overwriting the div.

Nits:
- Please fix the copyright message in __openerp__.py. You do not have to confirm the copyright of OpenERP SA on OpenERP itself (esp. only up until 2009 ;-). Just establish your own copyright on this OpenERP *module*. Remove the first blank line of the file. I'd also be interested to hear about the "Financed and Planified" thing!

- Please add a copyright message in the javascript file

review: Needs Fixing
Revision history for this message
Nhomar - Vauxoo (nhomar) wrote : Posted in a previous version of this proposal

Hello.

1.- The licence was fixed.
2.- About the "Financed and Planified":

We in vauxoo make a lot of modules day by day, some times we dont remember why we develop something, and what customer is using it, this is the "Why" the "Planified Part" to know who planify something.

About the "Financed Part", we sign contract with our customers where we encourage "Almost in a mandatory way" to allow us to put EVERYTHING as free software, some of them ask us make a public mention at least with the "Financed By " part, to be sure they take the credit for them investment in improve OpenERP.

About the coded by: It is so frequent we dont remember who make something and we always put this info to be sure inside Vauxoo who is the best person to help in something.

In this specific case, i just took my template of Licence and I forgot clean it, if somebody in the community is against this information on the licence I can remove it.

Regards.

review: Needs Resubmitting
13. By Nhomar - Vauxoo

[FIX] Take off the last part of the GPL stuff

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Nhomar,

honestly, thank you for the cleanup but I don't feel that it acceptable to adopt a module in the community projects that uses a license that has F*ck in its name. Otherwise, fine.

review: Needs Fixing
Revision history for this message
Nhomar - Vauxoo (nhomar) wrote :

Hello Stefan.

The licence is available with a little history:

http://en.wikipedia.org/wiki/WTFPL

but BTW, I think this module it so so so little to try to bock somebody with GPL or AGPL in terms of share something,

Even if you see there are less that 30 lines of code.

This is the reason i select the more open licence ;-)

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

given the entrenchment, I have no problems with bad words in sourcecode comments

review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I know that the contents of the license are valid and seek to supply a solution to the BSD/GLP feuds, but I just can't get over the immaturity of the name, sorry.

review: Disapprove
Revision history for this message
Nhomar - Vauxoo (nhomar) wrote :

We have here 2 votes. 1 - yes 1 - No .... Who will asume be the tiebreaker?

Honestly this is a module that can be published even as an Snnipet, and we install in almost all our production enviroments, Honestly, I can not lock anything with this, should I select a new licence with Vauxoo PL or something like that to give the TOTAL freedom the user to make whatever he wants?

I can redact a New licence or make a new one if it give the same freewom in 10 words ;-)

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

yes, please use a license that has a name Stefan can live with, then I'll be happy to do the merge

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Honestly, 95% of OpenERP community code is AGPL, 5% may still be GPL. You would save everyone some processing power if you just applied one of these by convention. A more liberal license doesn't even make any sense if the code is not usable outside of OpenERP or Tryton context (like this particular code), because the licenses of the core products are viral with respect to code with licenses such as the WTFPL so that when you run they are licensed *GPL effectively.

And I am actually fed up with it because we are not getting enough community reviews done and at the same time are spending time on such issues. These conventions save time and effort, really.

14. By Nhomar - Vauxoo

[FIX] Licence without bad words.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'web_nocreatedb'
2=== added file 'web_nocreatedb/__init__.py'
3=== added file 'web_nocreatedb/__openerp__.py'
4--- web_nocreatedb/__openerp__.py 1970-01-01 00:00:00 +0000
5+++ web_nocreatedb/__openerp__.py 2013-06-22 14:47:26 +0000
6@@ -0,0 +1,67 @@
7+# -*- coding: utf-8 -*-
8+##############################################################################
9+# Financed and Planified by Vauxoo
10+# developed by: tulio@vauxoo.com
11+#
12+
13+# This program is free software: you can redistribute it and/or modify
14+# it under the terms of the GNU General Public License as
15+# published by the Free Software Foundation, either version 3 of the
16+# License, or (at your option) any later version.
17+#
18+# This program is distributed in the hope that it will be useful,
19+# but WITHOUT ANY WARRANTY; without even the implied warranty of
20+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21+# GNU General Public License for more details.
22+#
23+# You should have received a copy of the GNU General Public License
24+# along with this program. If not, see <http://www.gnu.org/licenses/>.
25+#
26+##############################################################################
27+
28+{
29+ 'name': "NO create database link",
30+ 'author': "Vauxoo",
31+ 'category': "Web",
32+ 'website': "http://vauxoo.com",
33+ 'description': """
34+After install this module, you will not see anymore the
35+"Manage Databases" link in login screen.
36+
37+See the image bellow:
38+
39+.. image:: web_nocreatedb/static/src/img/screen.png
40+
41+How to use:
42+
43+When you start your server add the name of this module in the "load" option::
44+
45+ $./openerp-server --load=web,web_nocreatedb -u all -d database
46+
47+Then you can start your server without the -u and -d (just the first time you
48+need update all to be sure all base and web will be fine).
49+
50+With this option you can just take off and restart the server if you need to show
51+the link temporaly again.
52+
53+TODO: It should be great add a parameter in the database to hide it configurable
54+way and with web_preload: True, but BTW, in old versions of openerp it was a
55+parameter in the config file, i think as it is is fine for now.
56+
57+.. note:: This module probably will not be shown in your module list by default
58+You should create a menu to see "All modules without filter.
59+ """,
60+ 'version': "1.0",
61+ 'depends': [
62+ 'web',
63+ ],
64+ 'js': [
65+ ],
66+ 'css': [
67+ ],
68+ 'qweb': [
69+ 'static/src/xml/web_nocreatedb.xml',
70+ ],
71+ 'installable': True,
72+ 'auto_install': False,
73+}
74
75=== added directory 'web_nocreatedb/static'
76=== added directory 'web_nocreatedb/static/src'
77=== added directory 'web_nocreatedb/static/src/img'
78=== added file 'web_nocreatedb/static/src/img/screen.png'
79Binary files web_nocreatedb/static/src/img/screen.png 1970-01-01 00:00:00 +0000 and web_nocreatedb/static/src/img/screen.png 2013-06-22 14:47:26 +0000 differ
80=== added directory 'web_nocreatedb/static/src/xml'
81=== added file 'web_nocreatedb/static/src/xml/web_nocreatedb.xml'
82--- web_nocreatedb/static/src/xml/web_nocreatedb.xml 1970-01-01 00:00:00 +0000
83+++ web_nocreatedb/static/src/xml/web_nocreatedb.xml 2013-06-22 14:47:26 +0000
84@@ -0,0 +1,16 @@
85+<?xml version="1.0" encoding="UTF-8"?>
86+<!--
87+ This program is free software: you can redistribute it and/or modify
88+ it under the terms of the GNU General Public License as
89+ published by the Free Software Foundation, either version 3 of the
90+ License, or (at your option) any later version.
91+-->
92+<templates id="template" xml:space="preserve">
93+ <t t-extend="Login">
94+ <t t-jquery="div[class=oe_login_footer]" t-operation="replace">
95+ <div class="oe_login_footer">
96+ <a href="http://www.openerp.com" target="_blank">Powered by <span>OpenERP</span></a>
97+ </div>
98+ </t>
99+ </t>
100+</templates>

Subscribers

People subscribed via source and target branches