Merge lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani into lp:openerp-venezuela-localization

Proposed by Yanina Aular (Vauxoo)
Status: Merged
Merged at revision: 770
Proposed branch: lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani
Merge into: lp:openerp-venezuela-localization
Diff against target: 0 lines
To merge this branch: bzr merge lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani
Reviewer Review Type Date Requested Status
Gabriela Quilarque Pending
Nhomar - Vauxoo Pending
Jose Antonio Morales Ponce(vauxoo) - - http://www.vauxoo.com Pending
Review via email: mp+139954@code.launchpad.net

This proposal supersedes a proposal from 2012-12-11.

Description of the change

Revisión del módulo l10n_ve_withholding_src, solo falta terminar la tarea 4.4.1. De resto, el módulo está listo para su revisión.

To post a comment you must log in.
Revision history for this message
Nhomar - Vauxoo (nhomar) wrote : Posted in a previous version of this proposal

Por mi desde el punto de vista funcional hace todo lo esperado.

review: Approve
Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote : Posted in a previous version of this proposal

Bajando branch para testear...

les comento al finalizar.

saludos

2012/12/11 Nhomar Hernandez (Vauxoo) <email address hidden>

> Review: Approve
>
> Por mi desde el punto de vista funcional hace todo lo esperado.
> --
>
> https://code.launchpad.net/~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani/+merge/139318
> You are subscribed to branch
> lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani.
>

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote : Posted in a previous version of this proposal

Si se instala el modulo sin data de demostrativa explota por que hace
referencia
a una vista que no existe en el modulo account: account_journal_view,

lo otro es que los datos que estan creando no estan bien organizados

hay referencias a xml_id que estan antes de la definicion de la xml_id

como esta referencia seq_account_retencion_src_customer, donde el
xml_id se referncia antes de la definicion

Este otro caso de abajo, es que aparece arriba definido
luego se referencia y por ultimo se vuelve a definir.

realmente son dos registros distintos que se han registrado con el
mismo xml_id, estos dentro de un mismo modulo deben ser unicos.

seq_type_account_wh_src_supplier

El orden de esa data xml habria de ser,

ir.sequence.type
ir.sequence
account.journal

2012/12/12 Humberto Arocha <email address hidden>

> Bajando branch para testear...
>
> les comento al finalizar.
>
> saludos
>
> 2012/12/11 Nhomar Hernandez (Vauxoo) <email address hidden>
>
> Review: Approve
>>
>> Por mi desde el punto de vista funcional hace todo lo esperado.
>> --
>>
>> https://code.launchpad.net/~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani/+merge/139318
>> You are subscribed to branch
>> lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani.
>>
>
>

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote : Posted in a previous version of this proposal

Paso la propuesta de merge a rechazado, para agregar los cambios y tareas que estan en el whiteboard y workitems del blueprint.

Revision history for this message
Nhomar - Vauxoo (nhomar) wrote : Posted in a previous version of this proposal

Yo creo que deberia estar en needs fixing no crees?
On Dec 12, 2012 1:20 AM, "hbto [Vauxoo] http://www.vauxoo.com" <
<email address hidden>> wrote:

> Paso la propuesta de merge a rechazado, para agregar los cambios y tareas
> que estan en el whiteboard y workitems del blueprint.
>
> --
>
> https://code.launchpad.net/~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani/+merge/139318
> You are reviewing the proposed merge of
> lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani into
> lp:openerp-venezuela-localization.
>

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote : Posted in a previous version of this proposal

Si esa opción es correcta y existe por favor aplicala, no recuerdo haberla
visto

Hbto [Vauxoo]
On Dec 12, 2012 1:43 AM, "Nhomar Hernandez (Vauxoo)" <email address hidden>
wrote:

> Yo creo que deberia estar en needs fixing no crees?
> On Dec 12, 2012 1:20 AM, "hbto [Vauxoo] http://www.vauxoo.com" <
> <email address hidden>> wrote:
>
> > Paso la propuesta de merge a rechazado, para agregar los cambios y tareas
> > que estan en el whiteboard y workitems del blueprint.
> >
> > --
> >
> >
> https://code.launchpad.net/~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani/+merge/139318
> > You are reviewing the proposed merge of
> > lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani into
> > lp:openerp-venezuela-localization.
> >
>
> --
>
> https://code.launchpad.net/~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani/+merge/139318
> You are subscribed to branch
> lp:~vauxoo/openerp-venezuela-localization/ovl70-whsrc-rev-yani.
>

Revision history for this message
Nhomar - Vauxoo (nhomar) wrote : Posted in a previous version of this proposal

Sorry Tiene errores técnicos.

review: Needs Fixing
795. By Yanina Aular (Vauxoo)

[DEL] Method unused

796. By hbto [Vauxoo] http://www.vauxoo.com

[FIX] reverting wrong move in 776

797. By hbto [Vauxoo] http://www.vauxoo.com

[FIX] reverting wrong move in file l10n_ve_withholding_src/model/partner.py
and file l10n_ve_withholding_src/view/partner_view.xml

Preview Diff

Empty