Merge lp:~vauxoo/openerp-venezuela-localization/ovl70-rev-taskovl-yani into lp:openerp-venezuela-localization

Proposed by Yanina Aular (Vauxoo)
Status: Merged
Merged at revision: 822
Proposed branch: lp:~vauxoo/openerp-venezuela-localization/ovl70-rev-taskovl-yani
Merge into: lp:openerp-venezuela-localization
Diff against target: 243 lines (+90/-11)
10 files modified
l10n_ve_fiscal_requirements/__openerp__.py (+1/-0)
l10n_ve_fiscal_requirements/demo/journal_demo.xml (+50/-0)
l10n_ve_fiscal_requirements/model/invoice.py (+18/-1)
l10n_ve_fiscal_requirements/model/res_company.py (+2/-1)
l10n_ve_fiscal_requirements/view/account_invoice_view.xml (+13/-4)
l10n_ve_fiscal_requirements/view/res_company_view.xml (+4/-1)
l10n_ve_withholding/model/l10n_ve_withholding.py (+1/-1)
l10n_ve_withholding_iva/model/generate_txt.py (+0/-1)
l10n_ve_withholding_iva/report/__init__.py (+1/-1)
l10n_ve_withholding_src/model/partner.py (+0/-1)
To merge this branch: bzr merge lp:~vauxoo/openerp-venezuela-localization/ovl70-rev-taskovl-yani
Reviewer Review Type Date Requested Status
hbto [Vauxoo] http://www.vauxoo.com Approve
Review via email: mp+160938@code.launchpad.net

This proposal supersedes a proposal from 2013-04-18.

Description of the change

localization improvements, bug fixes

To post a comment you must log in.
Revision history for this message
Yanina Aular (Vauxoo) (yanina-aular) wrote : Posted in a previous version of this proposal

localization improvements, bug fixes

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_ve_fiscal_requirements/__openerp__.py'
2--- l10n_ve_fiscal_requirements/__openerp__.py 2013-04-12 21:29:36 +0000
3+++ l10n_ve_fiscal_requirements/__openerp__.py 2013-04-25 15:51:30 +0000
4@@ -88,6 +88,7 @@
5 ],
6 'demo_xml': [
7 'demo/demo_partners.xml',
8+ 'demo/journal_demo.xml',
9 ],
10 'test': [
11 'test/control_number.yml',
12
13=== added file 'l10n_ve_fiscal_requirements/demo/journal_demo.xml'
14--- l10n_ve_fiscal_requirements/demo/journal_demo.xml 1970-01-01 00:00:00 +0000
15+++ l10n_ve_fiscal_requirements/demo/journal_demo.xml 2013-04-25 15:51:30 +0000
16@@ -0,0 +1,50 @@
17+<?xml version="1.0" encoding="utf-8"?>
18+<openerp>
19+ <data noupdate="1">
20+
21+ <!-- Sequences -->
22+
23+ <record id="seq_debit_purchase_type" model="ir.sequence.type">
24+ <field name="name">Nota Debito Compra</field>
25+ <field name="code">account.journal.debit.purchase</field>
26+ </record>
27+
28+ <record id="seq_debit_purchase_journal" model="ir.sequence">
29+ <field name="name">Nota de debito Compra</field>
30+ <field name="code">account.journal.debit.purchase</field>
31+ <field name="prefix">RE:</field>
32+ <field name="padding">6</field>
33+ <field name="number_increment">1</field>
34+ </record>
35+
36+ <record id="seq_debit_sale_type" model="ir.sequence.type">
37+ <field name="name">Nota Debito Venta</field>
38+ <field name="code">account.journal.debit.sale</field>
39+ </record>
40+
41+ <record id="seq_debit_sale_journal" model="ir.sequence">
42+ <field name="name">Nota de debito Venta</field>
43+ <field name="code">account.journal.debit.sale</field>
44+ <field name="prefix">RE:</field>
45+ <field name="padding">6</field>
46+ <field name="number_increment">1</field>
47+ </record>
48+
49+ <!-- Journal -->
50+
51+ <record id="debit_purchase_journal" model="account.journal">
52+ <field name="name">DIARIO DE NOTA DE DEBITO COMPRA</field>
53+ <field name="code">DBT1</field>
54+ <field name="type">purchase_debit</field>
55+ <field name="sequence_id" ref="seq_debit_purchase_journal"/>
56+ </record>
57+
58+ <record id="debit_sale_journal" model="account.journal">
59+ <field name="name">DIARIO DE NOTA DE DEBITO VENTA</field>
60+ <field name="code">DBT2</field>
61+ <field name="type">sale_debit</field>
62+ <field name="sequence_id" ref="seq_debit_sale_journal"/>
63+ </record>
64+
65+ </data>
66+</openerp>
67
68=== modified file 'l10n_ve_fiscal_requirements/model/invoice.py'
69--- l10n_ve_fiscal_requirements/model/invoice.py 2013-04-16 15:45:09 +0000
70+++ l10n_ve_fiscal_requirements/model/invoice.py 2013-04-25 15:51:30 +0000
71@@ -72,6 +72,18 @@
72 return False
73 return True
74
75+ def _get_loc_req(self, cr, uid, context=None):
76+ """Get if a field is required or not by a Localization
77+ @param uid: Integer value of the user
78+ """
79+ context = context or {}
80+ res = False
81+ rc_obj = self.pool.get('res.company')
82+ rc_brw = rc_obj.browse(cr, uid, uid, context=context)
83+
84+ if rc_brw.country_id and rc_brw.country_id.code == 'VE' and rc_brw.printer_fiscal:
85+ res = True
86+ return res
87
88 _inherit = 'account.invoice'
89 _columns = {
90@@ -84,9 +96,14 @@
91 'invoice_printer' : fields.char('Fiscal printer invoice number', size=64, required=False,help="Fiscal printer invoice number, is the number of the invoice on the fiscal printer"),
92 #TODO": maybe it must be a many2one to declared FiscalPrinter when FiscalV is ready
93 'fiscal_printer' : fields.char('Fiscal printer number', size=64, required=False,help="Fiscal printer number, generally is the id number of the printer."),
94-
95+ 'loc_req':fields.boolean('Required by Localization', help='This fields is for technical use'),
96 }
97
98+ _defaults ={
99+ 'loc_req': _get_loc_req
100+ }
101+
102+
103 _constraints = [
104 (_unique_invoice_per_partner, _('The Document you have been entering for this Partner has already been recorded'),['Control Number (nro_ctrl)','Reference (reference)']),
105 ]
106
107=== modified file 'l10n_ve_fiscal_requirements/model/res_company.py'
108--- l10n_ve_fiscal_requirements/model/res_company.py 2013-03-26 23:24:31 +0000
109+++ l10n_ve_fiscal_requirements/model/res_company.py 2013-04-25 15:51:30 +0000
110@@ -36,7 +36,8 @@
111 _columns = {
112 'jour_id': fields.many2one('account.journal', 'Journal', required=False, help="Default journal for damaged invoices"),
113 'acc_id': fields.many2one('account.account', 'Account', required=False, help="Default account used for invoices and lines from damaged invoices"),
114- }
115+ 'printer_fiscal' : fields.boolean('Manages fiscal printer', help='Indicates that the company can operate a fiscal printer'),
116+ }
117
118 def create(self, cr, uid, vals, context=None):
119 '''
120
121=== modified file 'l10n_ve_fiscal_requirements/view/account_invoice_view.xml'
122--- l10n_ve_fiscal_requirements/view/account_invoice_view.xml 2013-04-16 20:53:35 +0000
123+++ l10n_ve_fiscal_requirements/view/account_invoice_view.xml 2013-04-25 15:51:30 +0000
124@@ -26,19 +26,27 @@
125 </group>
126 <newline/>
127 </xpath>
128+
129 <xpath expr="//page[@string='Payments']" position="after">
130- <page string="Debit-Credit Notes">
131+ <page string="Debit-Credit Notes" attrs="{'invisible':['|','|',('type','=','in_refund'),('type','=','out_refund'),('parent_id','!=',False)]}">
132 <newline/>
133 <field name="child_ids" nolabel="1" widget="many2many" domain="[('partner_id','=',partner_id),('id', '!=', active_id),('type','in',['out_invoice', 'out_refund'])]"/>
134 </page>
135 </xpath>
136+
137 <xpath expr="//page[@string='Other Info']/group/group[2]" position="after">
138
139 <group colspan="2" >
140 <separator colspan="6" string="Fiscal Information"/>
141 <field name="sin_cred" />
142- <field name="invoice_printer" groups="parameters_fiscal_printer.group_parameters_fiscal_printer_user"/>
143+ <!--
144+ <field name="invoice_printer" groups="parameters_fiscal_printer.group_parameters_fiscal_printer_user"/>
145 <field name="fiscal_printer" groups="parameters_fiscal_printer.group_parameters_fiscal_printer_user"/>
146+ -->
147+ <field name="loc_req" invisible="1"/>
148+ <field name="invoice_printer" attrs="{'required':[('loc_req','=',True)]}"/>
149+ <field name="fiscal_printer" attrs="{'required':[('loc_req','=',True)]}"/>
150+
151 <field name="parent_id"
152 attrs="{'required':[('type','=','out_refund')]}"
153 domain="[('partner_id','=',partner_id),('id', '!=', active_id),('type','in',['out_invoice', 'out_refund'])]"/>
154@@ -152,15 +160,16 @@
155 <field name="address_invoice_id" domain="[('partner_id','=',partner_id), ('type','=','invoice')]"/>
156 </xpath>
157 -->
158-
159+
160 <xpath expr="//page[@string='Payments']" position="after">
161- <page string="Debit-Credit Notes">
162+ <page string="Debit-Credit Notes" attrs="{'invisible':['|','|',('type','=','in_refund'),('type','=','out_refund'),('parent_id','!=',False)]}">
163 <field name="child_ids"
164 nolabel="1"
165 widget="many2many"
166 domain="[('partner_id','=',partner_id),('id', '!=', active_id),('type','in',['in_invoice', 'in_refund'])]"/>
167 </page>
168 </xpath>
169+
170 <xpath expr="//button[@string='Refund Invoice']" position="after">
171 <button name="%(action_account_invoice_debit)d"
172 type='action'
173
174=== modified file 'l10n_ve_fiscal_requirements/view/res_company_view.xml'
175--- l10n_ve_fiscal_requirements/view/res_company_view.xml 2013-01-08 14:55:04 +0000
176+++ l10n_ve_fiscal_requirements/view/res_company_view.xml 2013-04-25 15:51:30 +0000
177@@ -9,6 +9,10 @@
178 <field name="inherit_id" ref="base.view_company_form"/>
179 <field name="arch" type="xml">
180
181+ <xpath expr='//page[@string="Configuration"]/group/group[@name="account_grp"]' position="inside">
182+ <field name="printer_fiscal"/>
183+ </xpath>
184+
185 <xpath expr='//page[@string="Configuration"]/group/group[@name="account_grp"]' position="after">
186 <separator string="Data used by default for invoices damaged" colspan="4"/>
187 </xpath>
188@@ -17,7 +21,6 @@
189
190 <field name="jour_id"/>
191
192- <field name="acc_id"/>
193 <newline/>
194
195 <field name="acc_id" domain="[('type','in',('other','receivable','payable'))]"/>
196
197=== modified file 'l10n_ve_withholding/model/l10n_ve_withholding.py'
198--- l10n_ve_withholding/model/l10n_ve_withholding.py 2013-03-20 21:00:03 +0000
199+++ l10n_ve_withholding/model/l10n_ve_withholding.py 2013-04-25 15:51:30 +0000
200@@ -27,7 +27,7 @@
201
202
203 class account_wh_doc(osv.osv):
204- _description = 'With holding document'
205+ _description = 'Withholding document'
206 _name = 'account.wh.doc'
207 _columns = {
208 'model_parent': fields.char('Parent Object', size=64, required=True, select=1, help="parent for relationship between withholding"),
209
210=== modified file 'l10n_ve_withholding_iva/model/generate_txt.py'
211--- l10n_ve_withholding_iva/model/generate_txt.py 2013-03-21 15:58:01 +0000
212+++ l10n_ve_withholding_iva/model/generate_txt.py 2013-04-25 15:51:30 +0000
213@@ -75,7 +75,6 @@
214 'type':fields.boolean('Retention Suppliers?',required=True,states={'draft':[('readonly',False)]}, help="Select the type of retention to make"),
215 'date_start': fields.date('Begin Date',required=True,states={'draft':[('readonly',False)]}, help="Begin date of period"),
216 'date_end': fields.date('End date', required=True,states={'draft':[('readonly',False)]}, help="End date of period"),
217- 'type':fields.boolean('Retención Proveedores?',required=True,states={'draft':[('readonly',False)]}, help="Select the type of retention to make"),
218 'txt_ids':fields.one2many('txt.iva.line','txt_id', readonly=True,states={'draft':[('readonly',False)]}, help='Txt field lines of ar required by SENIAT for VAT withholding'),
219 'amount_total_ret':fields.function(_get_amount_total,method=True, digits=(16, 2), readonly=True, string=' Total Monto de Retencion', help="Monto Total Retenido"),
220 'amount_total_base':fields.function(_get_amount_total_base,method=True, digits=(16, 2), readonly=True, string='Total Base Imponible', help="Total de la Base Imponible"),
221
222=== modified file 'l10n_ve_withholding_iva/report/__init__.py'
223--- l10n_ve_withholding_iva/report/__init__.py 2011-10-28 17:13:52 +0000
224+++ l10n_ve_withholding_iva/report/__init__.py 2013-04-25 15:51:30 +0000
225@@ -26,4 +26,4 @@
226 ##############################################################################
227
228 import list_wh_iva
229-import wittholding_vat
230+import withholding_vat
231
232=== renamed file 'l10n_ve_withholding_iva/report/wittholding_vat.py' => 'l10n_ve_withholding_iva/report/withholding_vat.py'
233=== modified file 'l10n_ve_withholding_src/model/partner.py'
234--- l10n_ve_withholding_src/model/partner.py 2013-04-16 20:27:37 +0000
235+++ l10n_ve_withholding_src/model/partner.py 2013-04-25 15:51:30 +0000
236@@ -31,7 +31,6 @@
237
238 class res_partner(osv.osv):
239 _inherit = 'res.partner'
240- logger = netsvc.Logger()
241 _columns = {
242 'wh_src_agent': fields.boolean('SRC Wh. Agent', help="Indicate if the partner is a SRC withholding agent"),
243 'wh_src_rate': fields.float(string='SRC Rate', digits_compute= dp.get_precision('Withhold'), help="SRC Withholding rate"),