Merge lp:~vauxoo/openerp-venezuela-localization/miguel-wizard-url-seniat into lp:~openerp-venezuela/openerp-venezuela-localization/6.0-trunk

[Miguel Delgado (Vauxoo)]

Added a wizard to configure the url of SENIAT if they were modified over time.

Improvement the model partner.py found in the module l10n_ve_witholding_iva,in order to take the url of SENIAT found in the model seniat.url from module l10n_ve_fiscal_requirements.

Improvement the logic in models res_partner (l10n_ve_fiscal_requirements, l10n_ve_withholding_iva) to update fiscal information

[Nhomar - Vauxoo (nhomar)]

hELLO.

Trying in a new db:

[2011-10-09 14:08:27,391][tr_ve] WARNING:init:[01]: object seniat.url (
[2011-10-09 14:08:27,391][tr_ve] WARNING:init:[02]: OpenERP Model : seniat_url
[2011-10-09 14:08:27,391][tr_ve] WARNING:init:[03]: ) has no access rules!

And then this traceback appear.

[2011-10-09 14:09:02,371][tr_ve] WARNING:browse_record:[01]: Field 'url_seniat1_company' does not exist in object 'browse_record(seniat.url, 1)':
[2011-10-09 14:09:02,371][tr_ve] WARNING:browse_record:[02]: None
[2011-10-09 14:09:02,372][tr_ve] ERROR:web-services:Uncaught exception
Traceback (most recent call last):
  File "/home/nhomar/instancias/pedimento/server/bin/osv/osv.py", line 122, in wrapper
    return f(self, dbname, *args, **kwargs)
  File "/home/nhomar/instancias/pedimento/server/bin/osv/osv.py", line 176, in execute
    res = self.execute_cr(cr, uid, obj, method, *args, **kw)
  File "/home/nhomar/instancias/pedimento/server/bin/osv/osv.py", line 167, in execute_cr
    return getattr(object, method)(cr, uid, *args, **kw)
  File "/home/nhomar/instancias/pedimento/modules/l10n_ve_fiscal_requirements/installer.py", line 43, in onchange_update_rif
    partner_info = self.pool.get('res.partner').update_rif(cr, uid, ids, context)
  File "/home/nhomar/instancias/pedimento/modules/l10n_ve_fiscal_requirements/partner.py", line 165, in update_rif
    url1 = url_obj.url_seniat1_company + '%s'
  File "/home/nhomar/instancias/pedimento/server/bin/osv/orm.py", line 294, in __getattr__
    raise AttributeError(e)
AttributeError: "Field 'url_seniat1_company' does not exist in object 'browse_record(seniat.url, 1)'"

IMHO, it need some checks.

review: Needs Fixing

[Nhomar - Vauxoo (nhomar)]

The traceback appear, whern i put a RIF-VAT number

[lp:~vauxoo/openerp-venezuela-localization/miguel-wizard-url-seniat]

433. By Miguel Delgado (Vauxoo) on 2011-10-09

[FIX] fixed problem in the model res_partner in module l10n_ve_fiscal_requiremens when load url from seniat

=== modified file 'l10n_ve_fiscal_requirements/__openerp__.py'
--- l10n_ve_fiscal_requirements/__openerp__.py	2011-10-07 18:46:58 +0000
+++ l10n_ve_fiscal_requirements/__openerp__.py	2011-10-09 19:21:23 +0000
@@ -49,6 +49,7 @@
     """,
     'init_xml': [
         'data/l10n_ut_data.xml',
+        'data/seniat_url_data.xml',
     ],
     "depends" : ["base_vat", "account", "account_accountant"],
     'update_xml': [
@@ -58,9 +59,9 @@
         'view/res_company_view.xml',
         'view/l10n_ut_view.xml',
         'view/partner_view.xml',
-        'view/seniat_url_view.xml',
         'wizard/wizard_invoice_nro_ctrl_view.xml',
         'wizard/wizard_nro_ctrl_view.xml',
+        'wizard/wizard_url_seniat_view.xml',
     ],
     'demo_xml': [
         'demo/demo_partners.xml',

=== added file 'l10n_ve_fiscal_requirements/data/seniat_url_data.xml'
--- l10n_ve_fiscal_requirements/data/seniat_url_data.xml	1970-01-01 00:00:00 +0000
+++ l10n_ve_fiscal_requirements/data/seniat_url_data.xml	2011-10-09 19:21:23 +0000
@@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+<openerp>
+  <data noupdate="1">
+    <record id="seniat_url_2011" model="seniat.url">
+    <field name="name">http://contribuyente.seniat.gob.ve/getContribuyente/getrif?rif=</field>
+    <field name="url_seniat">http://contribuyente.seniat.gob.ve/BuscaRif/BuscaRif.jsp?p_rif=</field>
+    </record>
+  </data>
+</openerp>

=== modified file 'l10n_ve_fiscal_requirements/installer.py'
--- l10n_ve_fiscal_requirements/installer.py	2011-10-07 18:26:34 +0000
+++ l10n_ve_fiscal_requirements/installer.py	2011-10-09 19:21:23 +0000
@@ -48,6 +48,7 @@
         wiz_data = self.browse(cr, uid, ids[0])
         data = {'name': wiz_data.name, 'vat': "VE%s" % wiz_data.vat, 'vat_apply': wiz_data.vat_apply}
         partner = self.pool.get('res.users').browse(cr, uid, uid).company_id.partner_id
+        print 'esto es partner_id',partner.id
         self.pool.get('res.partner').write(cr, uid, [partner.id], data)
 
     _columns = {

=== modified file 'l10n_ve_fiscal_requirements/partner.py'
--- l10n_ve_fiscal_requirements/partner.py	2011-10-07 18:26:34 +0000
+++ l10n_ve_fiscal_requirements/partner.py	2011-10-09 19:21:23 +0000
@@ -142,20 +142,14 @@
 
     def _eval_seniat_data(self,xml_data,context={}):
         if xml_data.find('450')>=0:
-            if not 'all_rif' in context:
-                self._print_error(_('Vat Error !'),_('Invalid VAT!'))
-            else:
-                return True
+            self._print_error(_('Vat Error !'),_('Invalid VAT!'))
+
         if xml_data.find('452')>=0:
-            if not 'all_rif' in context:
-                self._print_error(_('Vat Error !'),_('Unregistered VAT!'))
-            else:
-                return True
+            self._print_error(_('Vat Error !'),_('Unregistered VAT!'))
+
         if xml_data.find("404")>=0:
-            if not 'all_rif' in context:
-                self._print_error(_('No Connection !'),_("Could not connect! Check the URL "))
-            else:
-                return True
+            self._print_error(_('No Connection !'),_("Could not connect! Check the URL "))
+
 
     def _dom_giver(self, url1, url2, context, vat):
         xml_data = self._load_url(3,url1 % vat)
@@ -168,19 +162,16 @@
     def update_rif(self, cr, uid, ids, context={}):
         pool = self.pool.get('seniat.url')
         url_obj = pool.browse(cr, uid, pool.search(cr, uid, []))[0]
-        url1 = url_obj.url_seniat1_company + '%s'
-        url2 = url_obj.url_seniat2_company + '%s'
+        url1 = url_obj.name + '%s'
+        url2 = url_obj.url_seniat + '%s'
         if context.get('exec_wizard'):
             return self._dom_giver(url1, url2, context, context['vat'])
 
         for partner in self.browse(cr,uid,ids):
             if partner.vat:
-                    data = self._dom_giver(url1, url2, context, partner.vat[2:])
-                    print data
-                    self.write(cr,uid,partner.id,data)
-            else:
-                if not 'all_rif' in context:
-                    self._print_error(_('Vat Error !'),_('The field vat is empty'))
+                data = self._dom_giver(url1, url2, context, partner.vat[2:])
+                print data
+                self.write(cr,uid,partner.id,data)
         return True
 
 res_partner()

=== modified file 'l10n_ve_fiscal_requirements/seniat_url.py'
--- l10n_ve_fiscal_requirements/seniat_url.py	2011-10-07 17:09:18 +0000
+++ l10n_ve_fiscal_requirements/seniat_url.py	2011-10-09 19:21:23 +0000
@@ -34,11 +34,7 @@
     _name = 'seniat.url'
     _description = __doc__
     _columns = {
-         'url_seniat1_company':fields.char('URL Seniat for Partner Information',size=64, required=True, readonly=False,help='In this field enter the URL from Seniat for search the fiscal information from partner'),
-        'url_seniat2_company':fields.char('URL Seniat for Retention Rate',size=64, required=True, readonly=False,help='In this field enter the URL from Seniat for search the retention rate from partner'),
-    }
-    _defaults = {
-        'url_seniat1_company':'http://contribuyente.seniat.gob.ve/getContribuyente/getrif?rif=',
-        'url_seniat2_company':'http://contribuyente.seniat.gob.ve/BuscaRif/BuscaRif.jsp?p_rif=',
+         'name':fields.char('URL Seniat for Partner Information',size=64, required=True, readonly=False,help='In this field enter the URL from Seniat for search the fiscal information from partner'),
+        'url_seniat':fields.char('URL Seniat for Retention Rate',size=64, required=True, readonly=False,help='In this field enter the URL from Seniat for search the retention rate from partner'),
     }
 seniat_url()

=== removed file 'l10n_ve_fiscal_requirements/view/seniat_url_view.xml'
--- l10n_ve_fiscal_requirements/view/seniat_url_view.xml	2011-10-07 17:15:47 +0000
+++ l10n_ve_fiscal_requirements/view/seniat_url_view.xml	1970-01-01 00:00:00 +0000
@@ -1,29 +0,0 @@
-<?xml version="1.0"?>
-<openerp>
-  <data>
-
-        <record id="view_seniat_url_form" model="ir.ui.view">
-            <field name="name">seniat.url.form</field>
-            <field name="model">seniat.url</field>
-            <field name="type">form</field>
-            <field name="arch" type="xml">
-                <form string="Seniat URL">
-                    <field name="url_seniat1_company"/>
-                    <field name="url_seniat2_company"/>
-                </form>
-            </field>
-        </record>
-
-        <record id="action_seniat_url" model="ir.actions.act_window">
-            <field name="name">Seniat URL</field>
-            <field name="type">ir.actions.act_window</field>
-            <field name="res_model">seniat.url</field>
-            <field name="view_type">form</field>
-            <field name="view_mode">form,form</field>
-            <field name="view_id" ref="view_seniat_url_form"/>
-        </record>
-
-        <menuitem action="action_seniat_url" string="Seniat URL" id="seniat_url_menu" parent="base.menu_res_company_global"/>
-
-  </data>
-</openerp>

=== modified file 'l10n_ve_fiscal_requirements/wizard/__init__.py'
--- l10n_ve_fiscal_requirements/wizard/__init__.py	2011-09-30 22:47:49 +0000
+++ l10n_ve_fiscal_requirements/wizard/__init__.py	2011-10-09 19:21:23 +0000
@@ -25,3 +25,4 @@
 ##############################################################################
 import wizard_nro_ctrl
 import wizard_invoice_nro_ctrl
+import wizard_url_seniat

=== added file 'l10n_ve_fiscal_requirements/wizard/wizard_url_seniat.py'
--- l10n_ve_fiscal_requirements/wizard/wizard_url_seniat.py	1970-01-01 00:00:00 +0000
+++ l10n_ve_fiscal_requirements/wizard/wizard_url_seniat.py	2011-10-09 19:21:23 +0000
@@ -0,0 +1,62 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution    
+#    Copyright (C) 2004-2009 Tiny SPRL (<http://tiny.be>). All Rights Reserved
+#    [e-mail]
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from osv import fields, osv
+import tools
+from tools.translate import _
+from tools import config
+
+class wizard_url_seniat(osv.osv_memory):
+
+
+    def _get_url(self,cr,uid,ids,context=None):
+        url= self.pool.get('seniat.url')
+        url_ids = url.search(cr, uid,[])
+        if len(url_ids)>1:
+            url.unlink(cr, uid,url_ids[1:])
+        url_obj=url.browse(cr, uid,url_ids,context=None)[0]
+        return url_obj
+
+    def _get_url1(self,cr,uid,ids,context=None):
+        url_obj = self._get_url(cr,uid,ids,context)
+        return url_obj.name
+    
+    def _get_url2(self,cr,uid,ids,context=None):
+        url_obj = self._get_url(cr,uid,ids,context)
+        return url_obj.url_seniat
+    
+    def update_url(self,cr,uid,ids,context=None):
+        data= self.pool.get('wizard.seniat.url').read(cr, uid, ids)[0]
+        url_obj = self._get_url(cr,uid,ids,context)
+        url_obj.write({'name':data['url1'],'url_seniat':data['url2']})
+        return {}
+
+    _name = "wizard.seniat.url"
+    _columns = {
+        'url1':fields.char('URL1',64, required=True, readonly=False,help='In this field enter the URL from Seniat for search the fiscal information from partner'),
+        'url2':fields.char('URL2',64, required=True, readonly=False,help='In this field enter the URL from Seniat for search the retention rate from partner'),
+    }
+    _defaults = {
+        'url1': _get_url1,
+        'url2': _get_url2,
+    }
+wizard_url_seniat()
+

=== added file 'l10n_ve_fiscal_requirements/wizard/wizard_url_seniat_view.xml'
--- l10n_ve_fiscal_requirements/wizard/wizard_url_seniat_view.xml	1970-01-01 00:00:00 +0000
+++ l10n_ve_fiscal_requirements/wizard/wizard_url_seniat_view.xml	2011-10-09 19:21:23 +0000
@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+        <record id="view_wizard_url_seniat" model="ir.ui.view">
+            <field name="name">view.wizard.seniat.url</field>
+            <field name="model">wizard.seniat.url</field>
+            <field name="type">form</field>
+            <field name="arch" type="xml">
+                <form string="Update Url From Seniat">
+                    <separator string="URL Seniat for Partner Information" colspan="4"/>
+                    <field name="url1"/>
+                    <newline/>
+                    <separator string="URL Seniat for Retention Rate" colspan="4"/>
+                    <field name="url2"/>
+                    <separator string="Are you sure you want to do this?" colspan="4"/>
+                     <group colspan="8" col="8">
+                            <button icon="gtk-ok" name="update_url" string="Yes" type="object"/>
+                            <button icon="gtk-cancel" special="cancel" string="No"/>
+                     </group>
+                </form>
+            </field>
+        </record>
+        <record id="wizard_url_seniat_action" model="ir.actions.act_window">
+            <field name="name">Update URL From Seniat</field>
+            <field name="res_model">wizard.seniat.url</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">tree,form</field>
+            <field name="view_id" ref="view_wizard_url_seniat"/>
+            <field name="target">new</field>
+        </record>
+        <menuitem name="Update URL Seniat" id="wizard_url_seniat_action2" 
+            parent="base.menu_res_company_global" action="wizard_url_seniat_action"/>
+    </data>
+</openerp>

=== modified file 'l10n_ve_withholding_iva/partner.py'
--- l10n_ve_withholding_iva/partner.py	2011-10-06 17:08:59 +0000
+++ l10n_ve_withholding_iva/partner.py	2011-10-09 19:21:23 +0000
@@ -114,15 +114,15 @@
                 return True
 
         if xml_data.find("404")>=0:
-            if not 'all_rif' in context:
-                self._print_error(_('No Connection !'),_("Could not connect! Check the URL "))
-            else:
-                return True
+            self._print_error(_('No Connection !'),_("Could not connect! Check the URL "))
+            return True
     
     def update_rif(self, cr, uid, ids, context={}):
+        pool = self.pool.get('seniat.url')
+        url_obj = pool.browse(cr, uid, pool.search(cr, uid, []))[0]
+        url1 = url_obj.name + '%s'
+        url2 = url_obj.url_seniat + '%s'
         for partner in self.browse(cr,uid,ids):
-            url1=partner.company_id.url_seniat1_company+'%s'
-            url2=partner.company_id.url_seniat2_company+'%s'
             if partner.vat:
                 xml_data = self._load_url(3,url1 %partner.vat[2:])
                 if not self._eval_seniat_data(xml_data,context):