Merge lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve_wh_iva_third_party-dev-1704-kty into lp:openerp-venezuela-localization

Proposed by Katherine Zaoral (Vauxoo)
Status: Merged
Merged at revision: 998
Proposed branch: lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve_wh_iva_third_party-dev-1704-kty
Merge into: lp:openerp-venezuela-localization
Diff against target: 53 lines (+10/-3)
3 files modified
l10n_ve_withholding_iva/model/wh_iva.py (+5/-0)
l10n_ve_withholding_iva/report/withholding_vat_report.rml (+3/-3)
l10n_ve_withholding_iva/view/wh_iva_view.xml (+2/-0)
To merge this branch: bzr merge lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve_wh_iva_third_party-dev-1704-kty
Reviewer Review Type Date Requested Status
hbto [Vauxoo] http://www.vauxoo.com Approve
Katherine Zaoral (Vauxoo) Needs Information
Review via email: mp+226736@code.launchpad.net

Description of the change

[MERGE] add third party partnet to the l10n_ve_withholding_iva module.

To post a comment you must log in.
Revision history for this message
Katherine Zaoral (Vauxoo) (kathy-zaoral) wrote :

waiting for runbot result.

review: Needs Information
Revision history for this message
Katherine Zaoral (Vauxoo) (kathy-zaoral) wrote :

runbot is green but need to make some functional test first

review: Needs Information
1005. By Katherine Zaoral (Vauxoo)

[FIX] bad reference to the parner_id view field from the third party domain.

1006. By Katherine Zaoral (Vauxoo)

[ADD] change the domain of the third party field.

Revision history for this message
Katherine Zaoral (Vauxoo) (kathy-zaoral) wrote :

this functionality is ready
runbot green
and functional tested
please @hbto review this mp

Revision history for this message
hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_ve_withholding_iva/model/wh_iva.py'
2--- l10n_ve_withholding_iva/model/wh_iva.py 2014-01-08 15:21:44 +0000
3+++ l10n_ve_withholding_iva/model/wh_iva.py 2014-07-15 15:05:31 +0000
4@@ -287,7 +287,12 @@
5 string="Fortnight",
6 readonly=True, states={"draft": [("readonly",False)]},
7 help="Withholding type"),
8+ 'third_party_id': fields.many2one(
9+ 'res.partner',
10+ 'Third Party Partner',
11+ help='Third Party Partner'),
12 }
13+
14 _defaults = {
15 'code': lambda self,cr,uid,c: self.wh_iva_seq_get(cr, uid),
16 'type': _get_type,
17
18=== modified file 'l10n_ve_withholding_iva/report/withholding_vat_report.rml'
19--- l10n_ve_withholding_iva/report/withholding_vat_report.rml 2012-05-30 19:13:00 +0000
20+++ l10n_ve_withholding_iva/report/withholding_vat_report.rml 2014-07-15 15:05:31 +0000
21@@ -168,9 +168,9 @@
22 </blockTable>
23 <blockTable colWidths="88.6mm,88.6mm,88.7mm" style="ITEMSWHITE" >
24 <tr>
25- <td><para style="ITEMSRIF"><b>[[ o.partner_id.name ]]</b></para></td>
26- <td><para style="ITEMSRIF"><b>[[ (o.partner_id.vat and ('%s-%s-%s'%(o.partner_id.vat[2:3],o.partner_id.vat[3:11],o.partner_id.vat[11:12])) or removeParentNode('para')) ]]</b></para></td>
27- <td><para style="ITEMSLEFT">[[ get_partner_addr2( o.partner_id.id ) ]]</para></td>
28+ <td><para style="ITEMSRIF"><b>[[ o.third_party_id and o.third_party_id.name or o.partner_id.name ]]</b></para></td>
29+ <td><para style="ITEMSRIF"><b>[[ o.third_party_id and o.third_party_id.vat and ('%s-%s-%s'%(o.third_party_id.vat[2:3],o.third_party_id.vat[3:11],o.third_party_id.vat[11:12])) or o.partner_id.vat and ('%s-%s-%s'%(o.partner_id.vat[2:3],o.partner_id.vat[3:11],o.partner_id.vat[11:12])) or removeParentNode('para') ]]</b></para></td>
30+ <td><para style="ITEMSLEFT">[[ get_partner_addr2( o.third_party_id and o.third_party_id.id or o.partner_id.id ) ]]</para></td>
31 </tr>
32 </blockTable>
33 <spacer length="5mm"/>
34
35=== modified file 'l10n_ve_withholding_iva/view/wh_iva_view.xml'
36--- l10n_ve_withholding_iva/view/wh_iva_view.xml 2014-05-14 20:07:35 +0000
37+++ l10n_ve_withholding_iva/view/wh_iva_view.xml 2014-07-15 15:05:31 +0000
38@@ -160,6 +160,7 @@
39 name="partner_id"
40 on_change="onchange_lines_filter(type, partner_id, period_id, fortnight)"
41 domain="[('supplier','=',True),('parent_id','=',False)]"/>
42+ <field name="third_party_id" domain="[('is_company','=',False),('id','!=',partner_id)]"/>
43 <field name="currency_id"/>
44 <field name="date_ret" readonly="1"/>
45 <field name="account_id" domain="[('type','=', type == 'in_invoice' and 'payable' or 'receivable'), ('company_id', '=', company_id)]"/>
46@@ -213,6 +214,7 @@
47 name="partner_id"
48 on_change="onchange_partner_id(type,partner_id)"
49 domain="[('wh_iva_agent','=',True), ('customer','=',True), ('parent_id','=',False)]"/>
50+ <field name="third_party_id" domain="[('is_company','=',False),('id','!=',partner_id)]"/>
51 <field name="currency_id"/>
52 <field name="date_ret" attrs="{'readonly':[('state','!=','draft')]}"/>
53 <field name="account_id" domain="[('type','=', type == 'in_invoice' and 'payable' or 'receivable'), ('company_id', '=', company_id)]"/>