Merge lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve_fiscal_requirements-rev-2210-kty into lp:openerp-venezuela-localization

[Katherine Zaoral (Vauxoo)]

[MERGE] new validations for supplier invoice were added to l10n_ve_withholding_iva and l10n_ve_fiscal_requiriments module. The document date field must be: 1) set when the invoice is in open state, 2) need to be less or equal to the invoice date field, 3) need to be readonly when the invoice is in open state.

[Katherine Zaoral (Vauxoo) (kathy-zaoral)]

waiting for runbot

[Katherine Zaoral (Vauxoo) (kathy-zaoral)]

there is a problem with the runbot
waiting for hbto to make a choice.

review: Needs Fixing

[lp:~vauxoo/openerp-venezuela-localization/7.0-l10n_ve_fiscal_requirements-rev-2210-kty]

1032. By Katherine Zaoral (Vauxoo) on 2014-09-17

[ADD] move the defined method in the fiscal requiremens as account.invoice
constraints as a simple method in the iva module.

1033. By Katherine Zaoral (Vauxoo) on 2014-09-17

[IMP] change the return False for a openerp raise osv exception in the two old
method used for the account invoice constraint.

1034. By Katherine Zaoral (Vauxoo) on 2014-09-17

[CC] extend the method inline document.

1035. By Katherine Zaoral (Vauxoo) on 2014-09-17

[IMP] rename some methods name.

1036. By Katherine Zaoral (Vauxoo) on 2014-09-17

[ADD] integrate the check of the documentd date and the check of the invoice
dates to the wh action server workflow.

1037. By Katherine Zaoral (Vauxoo) on 2014-09-17

[FIX] update the yml test case to define the date_document field of the invoice
when a invoice is created.

[Katherine Zaoral (Vauxoo) (kathy-zaoral)]

some changes specified by hbto were made to solve the problem.
Waiting for new runbot run test.

[Katherine Zaoral (Vauxoo) (kathy-zaoral)]

runbot is green.
I will proceed with the merge.

review: Approve

=== modified file 'l10n_ve_fiscal_requirements/model/invoice.py'
--- l10n_ve_fiscal_requirements/model/invoice.py	2014-01-21 14:15:07 +0000
+++ l10n_ve_fiscal_requirements/model/invoice.py	2014-09-17 22:38:43 +0000
@@ -99,8 +99,8 @@
 
 
     _constraints = [
-          (_unique_invoice_per_partner, _('The Document you have been entering for this Partner has already been recorded'),['Control Number (nro_ctrl)','Reference (reference)']),
-         ]
+        (_unique_invoice_per_partner, _('The Document you have been entering for this Partner has already been recorded'),['Control Number (nro_ctrl)','Reference (reference)']),
+     ]
 
     def copy(self, cr, uid, id, default={}, context=None):
         """ Allows you to duplicate a record,

=== modified file 'l10n_ve_fiscal_requirements/view/account_invoice_view.xml'
--- l10n_ve_fiscal_requirements/view/account_invoice_view.xml	2014-01-20 13:03:50 +0000
+++ l10n_ve_fiscal_requirements/view/account_invoice_view.xml	2014-09-17 22:38:43 +0000
@@ -90,7 +90,7 @@
                     <group colspan="1" cols="1">
                         <label for="date_document"/>
                         <newline/>
-                        <field name="date_document" nolabel="1"/>
+                        <field name="date_document" nolabel="1" attrs="{'readonly': [('state','=','open')]}"/>
                         <newline/>
                         <label string="(Put here the date when Purchase Invoice was generated for the supplier)"/>
                     </group>

=== modified file 'l10n_ve_withholding_iva/model/invoice.py'
--- l10n_ve_withholding_iva/model/invoice.py	2014-09-17 19:12:10 +0000
+++ l10n_ve_withholding_iva/model/invoice.py	2014-09-17 22:38:43 +0000
@@ -114,6 +114,36 @@
             invoice_ids = self.pool.get('account.invoice').search(cr, uid, [('move_id','in',move.keys())], context=context)
         return invoice_ids
 
+    def check_document_date(self, cr, uid, ids, context=None):
+        """
+        check that the invoice in open state have the document date defined.
+        @return True or raise an osv exception.
+        """
+        context = context or context
+        ids = isinstance(ids, (int, long)) and ids or ids[0]
+        inv_brw = self.browse(cr, uid, ids, context=context)
+        if (inv_brw.type in ('in_invoice', 'in_refund') and
+            inv_brw.state == 'open' and not inv_brw.date_document):
+            raise osv.except_osv(_('Warning'),
+                _('The document date can not be empty when the invoice is in'
+                  ' open state.'))
+        return True
+
+    def check_invoice_dates(self, cr, uid, ids, context=None):
+        """
+        check that the date document is less or equal than the date invoice.
+        @return True or raise and osv exception.
+        """
+        context = context or context
+        ids = isinstance(ids, (int, long)) and ids or ids[0]
+        inv_brw = self.browse(cr, uid, ids, context=context)
+        if (inv_brw.type in ('in_invoice', 'in_refund') and
+            inv_brw.date_document and
+            not inv_brw.date_document <= inv_brw.date_invoice):
+            raise osv.except_osv(_('Warning'),
+                _('The document date must be less or equal than the invoice'
+                  ' date.'))
+        return True
 
     _columns = {
         'wh_iva': fields.function(_retenida, method=True, string='Withhold', type='boolean',

=== modified file 'l10n_ve_withholding_iva/workflow/wh_action_server.xml'
--- l10n_ve_withholding_iva/workflow/wh_action_server.xml	2013-05-23 04:34:03 +0000
+++ l10n_ve_withholding_iva/workflow/wh_action_server.xml	2014-09-17 22:38:43 +0000
@@ -9,7 +9,9 @@
             <field name="condition">True</field>
             <field eval="3" name="sequence"/>
             <field name="type">ir.actions.server</field>
-            <field name="code">object.check_wh_apply() and \
+            <field name="code">object.check_document_date() and \
+object.check_invoice_dates() and \
+object.check_wh_apply() and \
 object.check_withholdable() and \
 object.action_wh_iva_supervisor() and \
 object.action_wh_iva_create()</field>

=== modified file 'l10n_ve_withholding_muni/test/awm_supplier.yml'
--- l10n_ve_withholding_muni/test/awm_supplier.yml	2013-12-10 20:58:56 +0000
+++ l10n_ve_withholding_muni/test/awm_supplier.yml	2014-09-17 22:38:43 +0000
@@ -13,6 +13,7 @@
     account_id: account.a_pay
     company_id: base.main_company
     currency_id: base.EUR
+    date_document: !eval time.strftime('%Y-%m-%d')
     invoice_line:
       - account_id: account.a_expense
         name: 'Test product description'

=== modified file 'l10n_ve_withholding_src/test/aws_supplier.yml'
--- l10n_ve_withholding_src/test/aws_supplier.yml	2014-01-15 19:25:45 +0000
+++ l10n_ve_withholding_src/test/aws_supplier.yml	2014-09-17 22:38:43 +0000
@@ -13,6 +13,7 @@
     account_id: account.a_recv
     company_id: base.main_company
     currency_id: base.EUR
+    date_document: !eval time.strftime('%Y-%m-%d')
     invoice_line:
       - account_id: account.a_recv
         name: 'Test product description'