Merge lp:~vauxoo/addons-vauxoo/validate_type_line_invoice_dev_luis into lp:addons-vauxoo

[Luis Torres - http://www.vauxoo.com]

Se agrego una validacion para que al momento de validar la factura revise que el tipo de cuenta de las lineas sea diferente a 'payable' o receivable'

[Moisés López - http://www.vauxoo.com (moylop260)]

Luis,
Tienes que regresar lo mismo que regresaría la original.
Y si llegara a entrar al raise te darás cuenta, que ya no frena todo lo que estaba haciendo la función, y hace rollback de lo demás.

Mira, aquí te mando un cambio de lógica de esto que te comento.

119 + def action_move_create(self, cr, uid, ids, context=None):
120 + invoice_line_obj=self.pool.get('account.invoice.line')
121 + account_obj=self.pool.get('account.account')
122 + lines = invoice_line_obj.search(cr,uid,[('invoice_id','=',ids)])
123 + ban=0
124 + for line in lines:
125 + id_account=invoice_line_obj.browse(cr,uid,line).account_id.id
126 + type_line=account_obj.browse(cr,uid,id_account).type
127 + if type_line == 'receivable' or type_line == 'payable':
132 + raise osv.except_osv(_('Error'), _("Type of account in line's most be differt to
133 + return super(account_invoice, self).action_move_create(cr, uid, ids)

[Rodolfo Lopez (el-rodo-1)]

Generar una validación mas:
si la factura es de cliente (out_invoice,out_refound) validar que la cuenta de la factura sea "a cobrar".
y si la factura es de proveedor (in_invoice, in_refound) validar que la cuenta de la factura sea "a pagar".
tienen domain para asegurarse que no la puedan elegir mal, pero no valida que no le puedan cambiar, por esto debe validar también en el botón validar que sea del tipo correspondiente:

review: Needs Fixing

[lp:~vauxoo/addons-vauxoo/validate_type_line_invoice_dev_luis]

447. By Luis Torres - http://www.vauxoo.com on 2012-09-18

[IMP]Validate that type account invoice for customer was 'receivable' & to partner was 'payable'

[Luis Torres - http://www.vauxoo.com (luis-cleto-)]

Se valida que:
si la factura es de cliente (out_invoice,out_refound) validar que la cuenta de la factura sea "a cobrar".
y si la factura es de proveedor (in_invoice, in_refound) validar que la cuenta de la factura sea "a pagar".

review: Needs Resubmitting

=== added directory 'validate_type_line_invoice'
=== added file 'validate_type_line_invoice/__init__.py'
--- validate_type_line_invoice/__init__.py	1970-01-01 00:00:00 +0000
+++ validate_type_line_invoice/__init__.py	2012-09-18 21:03:19 +0000
@@ -0,0 +1,26 @@
+# -*- encoding: utf-8 -*-
+###########################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2010 Vauxoo - http://www.vauxoo.com/
+#    All Rights Reserved.
+#    info Vauxoo ([e-mail])
+############################################################################
+#    Coded by: Luis Torres ([e-mail])
+############################################################################
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+import account_invoice

=== added file 'validate_type_line_invoice/__openerp__.py'
--- validate_type_line_invoice/__openerp__.py	1970-01-01 00:00:00 +0000
+++ validate_type_line_invoice/__openerp__.py	2012-09-18 21:03:19 +0000
@@ -0,0 +1,46 @@
+# -*- encoding: utf-8 -*-
+###########################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2010 Vauxoo - http://www.vauxoo.com/
+#    All Rights Reserved.
+#    info Vauxoo ([e-mail])
+############################################################################
+#    Coded by: Luis Torres ([e-mail])
+############################################################################
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    "name" : "Validate Type Line Invoice",
+    "version" : "1.0",
+    "author" : "Vauxoo",
+    "category" : "Generic Modules",
+    "description" : """
+        This module validate that type line to invoice is different to "a pagar" or "a cobrar"
+    """,
+    "website" : "http://www.vauxoo.com/",
+    "license" : "AGPL-3",
+    "depends" : ["account",
+        ],
+    "init_xml" : [],
+    "demo_xml" : [],
+    "update_xml" : [
+        
+    ],
+    "installable" : True,
+    "active" : False,
+}

=== added file 'validate_type_line_invoice/account_invoice.py'
--- validate_type_line_invoice/account_invoice.py	1970-01-01 00:00:00 +0000
+++ validate_type_line_invoice/account_invoice.py	2012-09-18 21:03:19 +0000
@@ -0,0 +1,49 @@
+# -*- encoding: utf-8 -*-
+###########################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#
+#    Copyright (c) 2010 Vauxoo - http://www.vauxoo.com/
+#    All Rights Reserved.
+#    info Vauxoo ([e-mail])
+############################################################################
+#    Coded by: Luis Torres ([e-mail])
+############################################################################
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from osv import osv, fields
+from tools.translate import _
+
+class account_invoice(osv.osv):
+    _inherit = 'account.invoice'
+    
+    def action_move_create(self, cr, uid, ids, context=None):
+        invoice_line_obj=self.pool.get('account.invoice.line')
+        account_obj=self.pool.get('account.account')
+        for id_ in ids:
+            lines = invoice_line_obj.search(cr,uid,[('invoice_id','=',id_)])
+            for line in lines:
+                id_account=invoice_line_obj.browse(cr,uid,line).account_id.id
+                type_line=account_obj.browse(cr,uid,id_account).type
+                if type_line == 'receivable' or type_line == 'payable':
+                    raise osv.except_osv(_('Error'), _("Type of account in line's must be differt to 'receivable' and 'payable'"))
+            type_acc_invo=self.browse(cr,uid,id_).account_id.type
+            type_invoice=self.browse(cr,uid,id_).type
+            if (type_invoice == 'out_invoice' or type_invoice=='out_refound') and type_acc_invo != 'receivable':
+                raise osv.except_osv(_('Error'), _("Type of account in invoice to Customer must be 'receivable'"))
+            if (type_invoice == 'in_invoice' or type_invoice=='in_refound') and type_acc_invo != 'payable':
+                raise osv.except_osv(_('Error'), _("Type of account in invoice to Partner must be 'payable'"))
+        return super(account_invoice, self).action_move_create(cr, uid, ids)
+account_invoice()