Merge lp:~vanvugt/unity8/fix-1556763 into lp:unity8

[Daniel van Vugt]

Reinstate the touch performance/smoothness fix
(LP: #1486341, LP: #1556763).

It never really went away, but someone accidentally moved it out of
pre-start and into post-start where it has no effect.

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:2279
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/699/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/399
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/399
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/399
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/921
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/937
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/937
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/935
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/935/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/935
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/935/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/935
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/935/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/935
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/935/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/935
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/935/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/935
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/935/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/699/rebuild

review: Approve (continuous-integration)

[Chris Halse Rogers (raof)]

Are you deliberately removing the MIR_SERVER_NBUFFERS=2 setting?

review: Needs Information

[Daniel van Vugt (vanvugt)]

Yes. The MIR_SERVER_NBUFFERS=2 was never used and actually detrimental for some devices (because Unity8 renders too slow and starts skipping frames without triple buffering). Also the option is about to be superseded by NBS.

I spent a year or two trying to enable double buffering, with some success. After I fixed all the starvation/freeze bugs in Mir, I just kept running into stuttering on Unity8 (because the dash especially is too slow to meet frame deadlines much of the time). So double buffering in Unity8 won't be considered for now...

If you want to experiment with high performance though, you still can with MIR_CLIENT_FORCE_SWAP_INTERVAL=0

[Daniel van Vugt (vanvugt)]

Reviewers can safely ignore the previous two comments... that feature is off-topic and commented out anyway.

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2279
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/836/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1082
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1098
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1098
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1096/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1096/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1096/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1096/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1096
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1096/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1096/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/836/rebuild

review: Needs Fixing (continuous-integration)

[lp:~vanvugt/unity8/fix-1556763]

2280. By Daniel van Vugt on 2016-03-29

Merge latest trunk

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2280
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/874/
Executed test runs:
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/457
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/457
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/457
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1169
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1148
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1148
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1146
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1146/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1146
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1146/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1146
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1146/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1146
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1146/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1146
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1146/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1146
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1146/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/874/rebuild

review: Needs Fixing (continuous-integration)

[lp:~vanvugt/unity8/fix-1556763]

2281. By Daniel van Vugt on 2016-03-31

Merge latest trunk

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2281
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/900/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/481
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/481
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/481
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1208
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1184
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1184
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1182
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1182/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1182
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1182/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1182
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1182/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1182
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1182/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1182
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1182/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1182
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1182/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/900/rebuild

review: Needs Fixing (continuous-integration)

[Daniel d'Andrada (dandrader)]

Looks good.

review: Approve

[Timo Jyrinki (timo-jyrinki)]

This fix indeed improves the responsiveness to touch. Even though bug #1563287 persists, this improves the experience user has anyway also there.

review: Approve

[Daniel van Vugt (vanvugt)]

Are we waiting on some external force to land this?

I just noticed this fix was up for review two weeks before OTA-10 went out. So we should have had it sorted before then. Hopefully the same regression won't still be in OTA-11.

[Albert Astals Cid (aacid)]

Daniel, see https://code.launchpad.net/~unity-team/unity8/trunk/+activereviews you're not the only one waiting for its branch to be landed, landing unity8 takes time :)

=== modified file 'data/unity8.conf'
--- data/unity8.conf	2016-02-12 00:10:08 +0000
+++ data/unity8.conf	2016-03-31 03:15:52 +0000
@@ -44,22 +44,18 @@
     fi
 
     initctl set-env --global MIR_SERVER_PROMPT_FILE=1
+
+    # Disable Qt's stuttering 'touch compression' to fix scrolling smoothness
+    # issues (LP: #1486341, LP: #1556763). As a bonus, this eliminates most of
+    # the lag seen in the indicator panel pull-down (LP: #1488327) and also
+    # reduces lag seen in apps:
+    initctl set-env --global QML_NO_TOUCH_COMPRESSION=1
 end script
 
 exec ${BINARY:-unity8} $ARGS
 
 post-start script
     initctl emit --no-wait indicator-services-start
-
-    # Disable Qt's stuttering 'touch compression' to fix scrolling smoothness
-    # issues (LP: #1486341). As a bonus, this eliminates most of the
-    # lag seen in the indicator panel pull-down (LP: #1488327) and also
-    # reduces lag seen in apps:
-    initctl set-env --global QML_NO_TOUCH_COMPRESSION=1
-
-    # For twice the fun and half the latency, try this (Warning: not all
-    # devices are fast enough to keep up smoothly yet)...
-    # initctl set-env MIR_SERVER_NBUFFERS=2
 end script
 
 post-stop script