Code review comment for lp:~vanvugt/unity/regionalDamage

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

It seems that this patch has caused a regression.

Use case:
 1 - have number of windows open
 2 - hold alt key
 3 - press tab key [switcher comes up]
 4 - click on some unselected icon

Expected outcome:
 Selected icon is instantly redrawn

Actual outcome:
 It frequently take several seconds for the switcher to be redrawn after SwitcherView calls QueueDraw()

Branches:
  lp:~dandrader/unity/switcher_click_test
  This this patch and the issue appears.

  lp:~dandrader/unity/switcher_click_test_older_trunk
  Does not have this patch and things work nice and dandy.

Background info:
I'm working on new gestures to switch between windows and interact with the window switcher (the alt-tab guy). The branches above have a snippet of my WIP code that enables a user to select a window by directly tapping/clicking over its icon on the switcher.

So is my code snipped doing something dumb or have this patch indeed caused a regresssion?

review: Needs Information

« Back to merge proposal