Code review comment for lp:~vanvugt/unity/fix-742544-trunk

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I prefer option 5. There are probably other driver edge cases that gdk handles.

Also prefer to use nux::logging::Logger instead of g_print in unity. nux::logging::Logger allows filtering of error messages by domains etc and is safer than print* because it uses iostreams.

You can do that with something like:

namespace
{
    nux::logging::Logger logger ("unity.screen");
}

LOG_INFO (logger) << "foo!";

review: Needs Fixing

« Back to merge proposal