Merge lp:~vanvugt/unity/fix-1089779 into lp:unity

[Daniel van Vugt]

Update to the new CompWindow API where CompWindow::minimized() is const.
This change happened recently in lp:compiz r3517. Not updating
UnityWindow::minimized was causing it to be masked and no longer treated
as a virtual method. This means Compiz would never call the UnityWindow
version and would think that windows are never minimized (so don't need
restoring).
(LP: #1089779)

Note 1: In Compiz we use clang to detect masked method problems like this. Please consider compiling with clang occasionally to detect such pedantic problems (cmake .. -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++).

Note 2: I don't think UnityWindow::[un]minimize[d]() are a good idea. They have caused nothing but bugs and should be removed IMHO.

[Andrea Azzarone (azzar1)]

The change looks good but when I minimize a window the area that was behind it is still input-insensitive.

[Daniel van Vugt (vanvugt)]

Yeah that must be a different bug then.

[Andrea Azzarone (azzar1)]

review: Approve

[Michael Terry (mterry)]

This bug symptom seems like it could use a test.

=== modified file 'plugins/unityshell/src/unityshell.cpp'
--- plugins/unityshell/src/unityshell.cpp	2012-12-13 00:51:04 +0000
+++ plugins/unityshell/src/unityshell.cpp	2012-12-13 07:02:23 +0000
@@ -2639,7 +2639,7 @@
 }
 
 bool
-UnityWindow::minimized ()
+UnityWindow::minimized () const
 {
   return mMinimizeHandler.get () != nullptr;
 }

=== modified file 'plugins/unityshell/src/unityshell.h'
--- plugins/unityshell/src/unityshell.h	2012-11-12 17:27:48 +0000
+++ plugins/unityshell/src/unityshell.h	2012-12-13 07:02:23 +0000
@@ -369,7 +369,7 @@
 
   void minimize();
   void unminimize();
-  bool minimized();
+  bool minimized() const;
   bool focus();
   void activate();