Merge lp:~vanvugt/ubuntu/quantal/nux/fix-1039155 into lp:ubuntu/quantal/nux
Status: | Rejected |
---|---|
Rejected by: | Martin Pitt |
Proposed branch: | lp:~vanvugt/ubuntu/quantal/nux/fix-1039155 |
Merge into: | lp:ubuntu/quantal/nux |
Diff against target: |
49 lines (+9/-14) 5 files modified
debian/50_check_unity_support (+8/-0) debian/nux-tools.install (+1/-0) debian/nux-tools.maintscript (+0/-1) debian/patches/01_blacklist_llvmpipe.patch (+0/-12) debian/patches/series (+0/-1) |
To merge this branch: | bzr merge lp:~vanvugt/ubuntu/quantal/nux/fix-1039155 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Disapprove | ||
Unity Team | Pending | ||
Ubuntu branches | Pending | ||
Review via email:
|
Commit message
Actually check the result of unity_support_test. And if it fails then fall
back to LLVMpipe, instead of leaving the user with no shell at all.
(LP: #1039155)
Description of the change
Test case:
1. Simulate a machine that fails unity_support_test by replacing /usr/lib/
2. Log out and in again.
3. Verify you are now using LLVMpipe:
(a) Rendering is slower; and
(b) glxinfo | grep OpenGL shows llvmpipe
Note: 3(b) is likely to change in future as programs spawned after Unity starts should not have LLVMpipe mode forced upon them. But that's an exercise for later.
Unmerged revisions
- 369. By Daniel van Vugt
-
Actually check the result of unity_support_test. And if it fails then fall
back to LLVMpipe, instead of leaving the user with no shell at all.
(LP: #1039155)
8:50:34 didrocks | the checker tool isn't used anymore
8:50:44 didrocks | so the branch will do nothing and it's too late to add it
8:50:56 didrocks | last time we discussed, this checks needs to be in compiz itself
8:51:00 Mirv | aha...
8:51:21 didrocks | (so exactly the same check minus the llvmpipe one) in the opengl plugin
8:51:22 Mirv | duflu yesterday changed the bug to indicate that the problem would not be in compiz
8:51:49 didrocks | well, ok, compiz may support opengl < 1.4 and no vertex shaders
8:52:09 didrocks | but in ubuntu, we mainly use it for ubuntu and the fallback to llvmpipe need to be done before the opengl plugin
| load
8:52:38 didrocks | as we don't use any external tool, it would make sense to distro-patch compiz for it