Merge lp:~vanvugt/ubuntu/precise/avidemux/fix-831096 into lp:ubuntu/precise/avidemux

Proposed by Daniel van Vugt
Status: Merged
Merged at revision: 49
Proposed branch: lp:~vanvugt/ubuntu/precise/avidemux/fix-831096
Merge into: lp:ubuntu/precise/avidemux
Diff against target: 105 lines (+66/-0)
5 files modified
debian/avidemux-common.install (+1/-0)
debian/changelog (+10/-0)
debian/control (+1/-0)
debian/patches/32-x264-115.patch (+52/-0)
debian/patches/series (+2/-0)
To merge this branch: bzr merge lp:~vanvugt/ubuntu/precise/avidemux/fix-831096
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+79534@code.launchpad.net

Description of the change

Fix build failure of 1:2.5.4-0ubuntu7 (LP: #831096) due to:
  - changed structure members in x264.h release 115 and later;
  - missing install rule for i18n files;
  - missing dependency on xsltproc, causing unpredictable failures on systems without xsltproc.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This proposal was developed on an amd64 Ubuntu 11.10 system. But also tested on an i386 Ubuntu 11.10 VM where I found the (very frustrating) xsltproc problem too.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It should be noted that all 3 of these fixes already exist in debian-multimedia (avidemux_2.5.5-0.3).

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Very confusing -

This proposal hasn't been merged yet but it has been published here:
https://launchpad.net/ubuntu/+source/avidemux/1:2.5.4-0ubuntu8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/avidemux-common.install'
2--- debian/avidemux-common.install 2009-07-13 16:56:09 +0000
3+++ debian/avidemux-common.install 2011-10-17 10:50:30 +0000
4@@ -1,3 +1,4 @@
5 usr/share/icons
6 usr/share/locale
7 usr/share/ADM_scripts
8+usr/share/avidemux/i18n
9
10=== modified file 'debian/changelog'
11--- debian/changelog 2011-05-12 11:36:01 +0000
12+++ debian/changelog 2011-10-17 10:50:30 +0000
13@@ -1,3 +1,13 @@
14+avidemux (1:2.5.4-0ubuntu8) precise; urgency=low
15+
16+ * Fix build failure of 1:2.5.4-0ubuntu7 (LP: #831096) due to:
17+ - changed structure members in x264.h release 115 and later;
18+ - missing install rule for i18n files;
19+ - missing dependency on xsltproc, causing unpredictable failures
20+ on systems without xsltproc.
21+
22+ -- Daniel van Vugt <vanvugt@gmail.com> Mon, 17 Oct 2011 17:27:32 +0800
23+
24 avidemux (1:2.5.4-0ubuntu7) oneiric; urgency=low
25
26 * Add patch to fix audio in avidemux2_qt4 (LP: #774912).
27
28=== modified file 'debian/control'
29--- debian/control 2011-05-12 11:36:01 +0000
30+++ debian/control 2011-10-17 10:50:30 +0000
31@@ -34,6 +34,7 @@
32 libjack-dev,
33 libpulse-dev,
34 yasm [i386 amd64],
35+ xsltproc,
36 libopencore-amrnb-dev,
37 libopencore-amrwb-dev
38 Vcs-Git: git://git.debian.org/collab-maint/avidemux.git
39
40=== added file 'debian/patches/32-x264-115.patch'
41--- debian/patches/32-x264-115.patch 1970-01-01 00:00:00 +0000
42+++ debian/patches/32-x264-115.patch 2011-10-17 10:50:30 +0000
43@@ -0,0 +1,52 @@
44+Description: Fix build failure with libx264 >= 115
45+ The structure member x264_param_t.i_open_gop was renamed to b_open_gop in
46+ x264.h version 115.
47+Origin: http://debian-multimedia.org/pool/main/a/avidemux/avidemux_2.5.5-0.3.diff.gz
48+Bug-Ubuntu: https://launchpad.net/bugs/831096
49+
50+Index: avidemux-2.5.5/plugins/ADM_videoEncoder/ADM_vidEnc_x264/encoder.cpp
51+===================================================================
52+--- avidemux-2.5.5.orig/plugins/ADM_videoEncoder/ADM_vidEnc_x264/encoder.cpp 2011-06-07 08:37:03.127997243 +0200
53++++ avidemux-2.5.5/plugins/ADM_videoEncoder/ADM_vidEnc_x264/encoder.cpp 2011-06-07 08:38:06.281464832 +0200
54+@@ -488,8 +488,10 @@
55+ printf("[x264] analyse.b_transform_8x8 = %d\n", x264Param->analyse.b_transform_8x8);
56+ printf("[x264] analyse.inter = %d\n", x264Param->analyse.inter);
57+ printf("[x264] b_cabac = %d\n", x264Param->b_cabac);
58+-#if X264_BUILD > 101
59++#if X264_BUILD > 101 && X264_BUILD < 115
60+ printf("[x264] i_open_gop = %d\n", x264Param->i_open_gop);
61++#elif X264_BUILD > 114
62++ printf("[x264] b_open_gop = %d\n", x264Param->b_open_gop);
63+ #endif
64+ printf("[x264] b_interlaced = %d\n", x264Param->b_interlaced);
65+ #if X264_BUILD > 88
66+Index: avidemux-2.5.5/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp
67+===================================================================
68+--- avidemux-2.5.5.orig/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp 2011-06-07 08:38:15.341100944 +0200
69++++ avidemux-2.5.5/plugins/ADM_videoEncoder/ADM_vidEnc_x264/x264Options.cpp 2011-06-07 08:41:08.114138787 +0200
70+@@ -417,7 +417,7 @@
71+ _param.b_cabac = cabac;
72+ }
73+
74+-#if X264_BUILD > 101
75++#if X264_BUILD > 101 && X264_BUILD < 115
76+ unsigned int x264Options::getOpenGopMode(void)
77+ {
78+ return _param.i_open_gop;
79+@@ -428,6 +428,16 @@
80+ if (openGopMode < 3)
81+ _param.i_open_gop = openGopMode;
82+ }
83++#elif X264_BUILD > 114
84++unsigned int x264Options::getOpenGopMode(void)
85++{
86++ return _param.b_open_gop;
87++}
88++void x264Options::setOpenGopMode(unsigned int openGopMode)
89++{
90++ if (openGopMode < 3)
91++ _param.b_open_gop = openGopMode;
92++}
93+ #endif
94+
95+ unsigned int x264Options::getInterlaced(void)
96
97=== modified file 'debian/patches/series'
98--- debian/patches/series 2011-05-12 11:36:01 +0000
99+++ debian/patches/series 2011-10-17 10:50:30 +0000
100@@ -9,3 +9,5 @@
101 22-mpegdemuxer.patch
102 30-fix_avidemux2_qt4_audio.patch
103 31-gcc46.patch
104+32-x264-115.patch
105+

Subscribers

People subscribed via source and target branches