Merge lp:~vanvugt/ubuntu/oneiric/bcmwl/fix-776439 into lp:ubuntu/natty/bcmwl

[Daniel van Vugt]

Failing to remove a DKMS module that does not exist is not an error (LP: #776439)

The prerm script for bcmwl-kernel-source was often failing to remove a DKMS module that did not exist. Failing to remove something that does not exist should not mean the overall remove operation should fail.

This patch ensures that if the DKMS module does not exist, then prerm doesn't fail trying to remove it (LP: #776439)

It is true that the root cause of this bug is failure to install the DKMS module in the first place. However that failure would always be visible as a failure during installation, and should be treated as a separate bug/s.

[Luke Yelavich (themuso)]

Thanks for your work. Both this fix and the fix for bug 776165 are worthy of a stable update for natty. I have prepared the necessary paperwork for this update and will be uploading both fixes shortly.

Thanks again.

review: Approve

=== modified file 'debian/bcmwl-kernel-source.prerm'
--- debian/bcmwl-kernel-source.prerm	2010-11-25 15:06:14 +0000
+++ debian/bcmwl-kernel-source.prerm	2011-06-02 05:25:52 +0000
@@ -10,8 +10,10 @@
 CVERSION=`dpkg-query -W -f='${Version}' bcmwl-kernel-source | awk -F "-" '{print $1}' | cut -d\: -f2`
 case "$1" in
     remove|upgrade)
-		echo "Removing all DKMS Modules"
-		dkms remove -m bcmwl -v $CVERSION --all > /dev/null
+		count=`dkms status -m bcmwl -v $CVERSION | wc -l`
+		echo "Removing all DKMS Modules ($count)"
+		[ $count -le 0 ] && true ||
+			dkms remove -m bcmwl -v $CVERSION --all > /dev/null
 		echo "Done."
         ;;
 esac