Merge lp:~vanvugt/ubuntu-themes/fix-1725921-xenial into lp:ubuntu-themes/xenial

Proposed by Daniel van Vugt
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 489
Merged at revision: 489
Proposed branch: lp:~vanvugt/ubuntu-themes/fix-1725921-xenial
Merge into: lp:ubuntu-themes/xenial
Diff against target: 28 lines (+0/-11)
1 file modified
Ambiance/gtk-2.0/gtkrc (+0/-11)
To merge this branch: bzr merge lp:~vanvugt/ubuntu-themes/fix-1725921-xenial
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+340938@code.launchpad.net

Commit message

Remove an old workaround which would force combobox menu text
to be dark. Starting in r487 the combobox menu background also
changed to dark, so forcing the text to dark made it almost the
same colour as the background. (LP: #1725921)

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Ambiance/gtk-2.0/gtkrc'
2--- Ambiance/gtk-2.0/gtkrc 2017-10-12 05:18:51 +0000
3+++ Ambiance/gtk-2.0/gtkrc 2018-03-07 08:27:10 +0000
4@@ -571,15 +571,6 @@
5 text[INSENSITIVE] = darker (@bg_color)
6 }
7
8-# Workaround style for menus where the text color is used instead of the fg color.
9-style "menuitem_text_is_fg_color_workaround" {
10- text[NORMAL] = @fg_color
11- text[PRELIGHT] = @selected_fg_color
12- text[SELECTED] = @selected_fg_color
13- text[ACTIVE] = @fg_color
14- text[INSENSITIVE] = "#99958b"
15-}
16-
17 # Workaround style for places where the fg color is used instead of the text color.
18 style "fg_is_text_color_workaround" {
19 fg[NORMAL] = @text_color
20@@ -707,8 +698,6 @@
21 # Work around for http://bugzilla.gnome.org/show_bug.cgi?id=382646
22 # Note that this work around assumes that the combobox is _not_ in appears-as-list mode.
23 widget_class "*.<GtkComboBox>.<GtkCellView>" style "text_is_fg_color_workaround"
24-# This is the part of the workaround that fixes the menus
25-widget "*.gtk-combobox-popup-menu.*" style "menuitem_text_is_fg_color_workaround"
26
27 # Work around the usage of GtkLabel inside GtkListItems to display text.
28 # This breaks because the label is shown on a background that is based on the base color.

Subscribers

People subscribed via source and target branches