Merge lp:~vanvugt/ubuntu-system-settings/fix-1607240 into lp:ubuntu-system-settings

Proposed by Daniel van Vugt on 2016-08-01
Status: Merged
Approved by: Jonas G. Drange on 2016-09-27
Approved revision: 1681
Merged at revision: 1735
Proposed branch: lp:~vanvugt/ubuntu-system-settings/fix-1607240
Merge into: lp:ubuntu-system-settings
Diff against target: 21 lines (+2/-2)
1 file modified
plugins/mouse/Connected.qml (+2/-2)
To merge this branch: bzr merge lp:~vanvugt/ubuntu-system-settings/fix-1607240
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) 2016-08-01 Approve on 2016-09-27
Lukáš Tinkl (community) 2016-08-02 Approve on 2016-08-04
Review via email: mp+301606@code.launchpad.net

Commit message

Allow scroll speed multipliers up to 3.0; since the default speed in
gsettings-ubuntu-touch-schemas is changing from 0.5 to 1.0, some users
will want to ability to increase it above the native speed still.
(LP: #1607240) (LP: #1627567)

Just don't make the maximum too high or else the slider will be difficult
to use, since 1.0 is the native speed.

To post a comment you must log in.
Daniel van Vugt (vanvugt) wrote :

Maybe 3 would be better?...

Lukáš Tinkl (lukas-kde) wrote :

Yeah I also think 5.0 is a bit too much

1681. By Daniel van Vugt on 2016-08-04

Maximum scroll speed of 3.0 instead

Lukáš Tinkl (lukas-kde) wrote :

LGTM, makes sense together with the other patches

review: Approve
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/mouse/Connected.qml'
2--- plugins/mouse/Connected.qml 2016-04-05 17:31:24 +0000
3+++ plugins/mouse/Connected.qml 2016-08-04 09:57:06 +0000
4@@ -109,7 +109,7 @@
5 showDivider: false
6 function formatValue(v) { return v.toFixed(2) }
7 minimumValue: 0.0
8- maximumValue: 1.0
9+ maximumValue: 3.0
10 value: backend.mouseScrollSpeed
11 live: true
12 property real serverValue: enabled ? backend.mouseScrollSpeed : 0.0
13@@ -281,7 +281,7 @@
14 showDivider: false
15 function formatValue(v) { return v.toFixed(2) }
16 minimumValue: 0.0
17- maximumValue: 1.0
18+ maximumValue: 3.0
19 value: backend.touchpadScrollSpeed
20 live: true
21 property real serverValue: enabled ? backend.touchpadScrollSpeed : 0.0

Subscribers

People subscribed via source and target branches