Merge lp:~vanvugt/ubuntu-system-settings/brightness-slider-title into lp:ubuntu-system-settings

Proposed by Daniel van Vugt
Status: Needs review
Proposed branch: lp:~vanvugt/ubuntu-system-settings/brightness-slider-title
Merge into: lp:ubuntu-system-settings
Diff against target: 23 lines (+1/-5)
1 file modified
plugins/brightness/PageComponent.qml (+1/-5)
To merge this branch: bzr merge lp:~vanvugt/ubuntu-system-settings/brightness-slider-title
Reviewer Review Type Date Requested Status
Ubuntu Touch System Settings Pending
Review via email: mp+317738@code.launchpad.net

Commit message

Use the proper text attribute for the "Display brightness" slider.

Less code, and a more consistent layout (since most other sliders do
it this way already).

To post a comment you must log in.

Unmerged revisions

1761. By Daniel van Vugt

Use the proper text attribute for the "Display brightness" slider.

Less code, and a more consistent layout (since most other sliders do
it this way already).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/brightness/PageComponent.qml'
2--- plugins/brightness/PageComponent.qml 2016-12-06 15:38:02 +0000
3+++ plugins/brightness/PageComponent.qml 2017-02-20 04:00:37 +0000
4@@ -80,11 +80,6 @@
5 anchors.left: parent.left
6 anchors.right: parent.right
7
8- ListItem.Standard {
9- text: i18n.tr("Display brightness")
10- showDivider: false
11- }
12-
13 /* Use the SliderMenu component instead of the Slider to avoid binding
14 issues on valueChanged until LP: #1388094 is fixed.
15 */
16@@ -93,6 +88,7 @@
17 objectName: "sliderMenu"
18 enabled: indicatorPower.brightness.state != null
19 live: true
20+ text: i18n.tr("Display brightness")
21 minimumValue: 0.0
22 maximumValue: 100.0
23 minIcon: "image://theme/display-brightness-min"

Subscribers

People subscribed via source and target branches