Merge lp:~vanvugt/qtubuntu/correct-scroll-speed into lp:qtubuntu

Proposed by Daniel van Vugt
Status: Merged
Approved by: Lukáš Tinkl
Approved revision: 332
Merged at revision: 337
Proposed branch: lp:~vanvugt/qtubuntu/correct-scroll-speed
Merge into: lp:qtubuntu
Diff against target: 13 lines (+2/-1)
1 file modified
src/ubuntumirclient/input.cpp (+2/-1)
To merge this branch: bzr merge lp:~vanvugt/qtubuntu/correct-scroll-speed
Reviewer Review Type Date Requested Status
Lukáš Tinkl (community) Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+301465@code.launchpad.net

Commit message

Use correct scrolling scale of 120 as documented:
   http://doc.qt.io/qt-5/qwheelevent.html#angleDelta
because it's in eighths of a degree, and not degrees.
So now the speed is correct when used with the corresponding Unity8
fix (LP: #1607240)

Description of the change

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:332
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/98/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2405
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2433
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2320
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2320
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2320
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2313/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2313
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2313/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtubuntu-ci/98/rebuild

review: Approve (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Yup, works fine for me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/ubuntumirclient/input.cpp'
2--- src/ubuntumirclient/input.cpp 2016-04-28 14:58:55 +0000
3+++ src/ubuntumirclient/input.cpp 2016-07-29 09:51:09 +0000
4@@ -521,7 +521,8 @@
5 const float vDelta = mir_pointer_event_axis_value(pev, mir_pointer_axis_vscroll);
6
7 if (hDelta != 0 || vDelta != 0) {
8- const QPoint angleDelta = QPoint(hDelta * 15, vDelta * 15);
9+ // QWheelEvent::DefaultDeltasPerStep = 120 but doesn't exist on vivid
10+ const QPoint angleDelta(120 * hDelta, 120 * vDelta);
11 QWindowSystemInterface::handleWheelEvent(window, timestamp, localPoint, window->position() + localPoint,
12 QPoint(), angleDelta, modifiers, Qt::ScrollUpdate);
13 }

Subscribers

People subscribed via source and target branches