lp:~vanvugt/qtmir/fix-1607240
- Get this branch:
- bzr branch lp:~vanvugt/qtmir/fix-1607240
Branch merges
- Daniel d'Andrada (community): Abstain
- Unity8 CI Bot (community): Approve (continuous-integration)
- Lukáš Tinkl (community): Approve
-
Diff: 32 lines (+7/-2)2 files modifiedsrc/modules/Unity/Application/mirsurface.cpp (+5/-1)
src/platforms/mirserver/qteventfeeder.cpp (+2/-1)
Related bugs
Related blueprints
Branch information
Recent revisions
- 530. By Daniel van Vugt
-
Fix incorrect mouse wheel/touchpad scrolling scale (LP: #1607240)
and also add sufficient precision that high-resolution touchpad
scrolling now works! (LP: #1607223)This fixes two mistakes:
1. angleDelta is not in degrees but eighths of a degree, so the magic
constant 15 should be 120 (QWheelEvent::DefaultDeltasP erStep)
[http://doc.qt. io/qt-5/ qwheelevent. html#angleDelta].
2. When converting from Qt back into a Mir event we forgot completely
to divide by the same factor to get back to the Mir scale of things.Additional fixes required!
Unfortunately we've built an ecosystem with tweaked values to work with
the old incorrect scroll values and additional fixes are required after
this one:
Xmir: Done, pending release in yakkety.
System Settings: Default scroll scale should be 1.0, not 0.5 (which is
the secret unlabelled scroll bar under 'Mouse & Touchpad').
webbrowser and other Qt apps: Not sure where to do that but they scroll
way too slowly with this fix and obviously need updating. - 527. By Daniel d'Andrada
-
Implement MirSurface:
:inputBounds and make use of mir's input region This allows us to finally drop the UbuntuKeyboardInfo hack.
Approved by: Gerry Boland
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:qtmir