lp:~vanvugt/nux/fix-1064834

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:nux at revision 686

Andrea Azzarone (community): Approve on 2012-10-10

jenkins: Pending (continuous-integration) requested 2012-10-10

Diff: 40 lines (+2/-7)

1 file modified

NuxGraphics/IOpenGLSurface.cpp (+2/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1064834: Compiz spends 94% of its CPU time in glTexImage2D() from nux::IOpenGLSurface::InitializeLevel() from ... nux::GraphicsEngine::CreateTextureFromBackBuffer when the dash is open

High

Fix Released

Link a bug report

Related blueprints

685. By Daniel van Vugt on 2012-10-10

Remove a massive bottleneck, where almost all the CPU time was spent
loading a black image on texture creation. (LP: #1064834)

CPU time spent in glTexImage2D:
  Before: 93.54%
  After: 0.10%

684. By Eleni Maria Stea on 2012-10-05

Removed all the PostDraw calls and definitions.. Fixes: . Approved by Jay Taoko, Andrea Azzarone, Nicolas d'Offay.

683. By Daniel d'Andrada on 2012-10-04

New: KineticScrollView

+ InputArea::SetTrackChildMouseEvents() and EVENT_MOUSE_CANCEL. Fixes: . Approved by Jay Taoko, Eleni Maria Stea, Nick Dedekind, Michi Henning.

682. By Daniel d'Andrada on 2012-10-03

Proper fix for lp1057995.

Reverts commit 680.

* mouse_position_on_owner_ is used only to come up with the delta for the mouse
  drag signal in TrackMouseEvent. There's no point in filling it up when the mouse
  is released as there can't be an upcoming drag while the mouse is not pressed
  (and therefore there's no owner).

* mouse_position_on_owner_ should be updated and used only inside
  WindowCompositor::TrackMouseMovement(). Responsibilities are split between
  methods to keep things more manageable. Commit 680 was starting to mix them
  again.

* This bug has show that line 310 (on revision 680) was likely never called (the
  cause of the bug). Commit 680 just turned it into dead code, making the logic
  misleading.

* Includes a regression test. Fixes: https://bugs.launchpad.net/bugs/1057995. Approved by Jay Taoko, Nick Dedekind.

681. By Stephen M. Webb on 2012-10-02

Fixes undefined behaviour caused by the use of undefined variables.. Fixes: . Approved by Brandon Schaefer.

680. By Nick Dedekind on 2012-10-02

Fixed drag delta processing in mouse event cycle.
(LP: #1057995). Fixes: https://bugs.launchpad.net/bugs/1057995. Approved by Daniel van Vugt.

679. By Michi Henning on 2012-10-02

Fixed catch clause and removed #ifdef because it can be the same for Windows and Linux.

Removed duplicate -Werror flag from maintainer flags.. Fixes: https://bugs.launchpad.net/bugs/937583. Approved by Michi Henning.

678. By Michi Henning on 2012-10-02

Added -Wextra to compiler flags and removed a large number of warnings about unused parameters. Code compiles clean now without warnings, except for one remaining warning (see bug #1052765).. Fixes: https://bugs.launchpad.net/bugs/1056633. Approved by Michi Henning.

677. By Eleni Maria Stea on 2012-10-01

Resolved conflicts, merged to trunk. Fixes: . Approved by Jay Taoko.

676. By Jay Taoko on 2012-10-01

* Removing instances of NString.
* Fixed integer to pointer convertion in GpuDevice::DrawIndexedPrimitive.
* Fixed bug in Them.cpp: Check that a pointer is NULL before calling UnReference.
* Use proper member variables naming.
* GpuDevice: Changed code for detection of OpenGL minor and minor version.. Fixes: https://bugs.launchpad.net/bugs/1052765. Approved by Nicolas d'Offay, Eleni Maria Stea, Michi Henning.