Mir

Merge lp:~vanvugt/mir/workaround-1522031 into lp:mir

Proposed by Daniel van Vugt
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 3189
Proposed branch: lp:~vanvugt/mir/workaround-1522031
Merge into: lp:mir
Diff against target: 12 lines (+1/-1)
1 file modified
cmake/MirCommon.cmake (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/workaround-1522031
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alberto Aguirre (community) Approve
Review via email: mp+279979@code.launchpad.net

Commit message

Don't use memcheck on the ClientLatency acceptance test. Because
valgrind is too slow to adequately emulate the multi-process performance
we're testing for and will cause failures.

This is a kind of workaround for LP: #1522031 which itself probably
won't and shouldn't be "fixed". This is also a small step toward beginning
to resolve LP: #1524209.

Description of the change

Also don't move the offending test out of acceptance and into performance
tests because it's a crucial test for a lot of work going on of late and we need it to catch mistakes as we make them.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

OK.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks like bug 1523621. Unrelated.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/MirCommon.cmake'
2--- cmake/MirCommon.cmake 2015-12-04 15:08:00 +0000
3+++ cmake/MirCommon.cmake 2015-12-09 07:57:15 +0000
4@@ -63,7 +63,7 @@
5
6 if(ENABLE_MEMCHECK_OPTION)
7 set(test_cmd ${VALGRIND_CMD} ${test_cmd_no_memcheck})
8- set(test_no_memcheck_filter "*DeathTest.*")
9+ set(test_no_memcheck_filter "*DeathTest.*:ClientLatency.*")
10 endif()
11
12 if(cmake_build_type_lower MATCHES "threadsanitizer")

Subscribers

People subscribed via source and target branches