Mir

Merge lp:~vanvugt/mir/workaround-1499229-attempt1 into lp:mir

  1. workaround-1499229-attempt1
  2. Merge into development-branch
Proposed by Daniel van Vugt
Status: Work in progress
Proposed branch: lp:~vanvugt/mir/workaround-1499229-attempt1
Merge into: lp:mir
Diff against target: 12 lines (+1/-1)
1 file modified
cmake/MirCommon.cmake (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/workaround-1499229-attempt1
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Cemil Azizoglu (community) Abstain
Review via email: mp+280266@code.launchpad.net

Commit message

Try to avoid valgrind on ThreadedDispatcherSignalTest.* that's failing
all the time on xenial-armhf at least, apparently from unnamed valgrind
errors in its child process that are not in our code.

This might work around LP: #1499229...

Description of the change

Annoyingly I can't yet reproduce the failure (if I remember to use our valgrind suppressions). So there's something peculiar about the CI hardware/OS for the xenial-armhf tasks that I'm not replicating.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3191
http://jenkins.qa.ubuntu.com/job/mir-ci/5818/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5276
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4182
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5225
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/137/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/146
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/146/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/146
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/146/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5225
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5225/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7747
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25976
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/135/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5818/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Would prefer the other one over this, if it can be made to work.

review: Abstain
Reply
lp:~vanvugt/mir/workaround-1499229-attempt1 updated
3192. By Daniel van Vugt

Merge latest trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3192
http://jenkins.qa.ubuntu.com/job/mir-ci/5831/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5291
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4197
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5240
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/159/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/159
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/159/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5240
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5240/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7761
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/25999

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5831/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Only bug 1525003 there.

Reply
lp:~vanvugt/mir/workaround-1499229-attempt1 updated
3193. By Daniel van Vugt

Ping Jenkins

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Suspicious. Having disabled one test under valgrind, we still fail with the same number of valgrind errors. Just a bit later. So they're coming from somewhere else.

Maybe we should focus on bug 1524209 instead?

Reply
lp:~vanvugt/mir/workaround-1499229-attempt1 updated
3194. By Daniel van Vugt

Merge latest trunk again; adds new suppressions from Cemil.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3193
http://jenkins.qa.ubuntu.com/job/mir-ci/5832/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5292
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4198
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5241
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/146/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/160
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/160/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/160
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/160/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5241
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5241/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7762
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26000
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/144/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5832/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Seems like the root cause is still there:

9: ==16551== ERROR SUMMARY: 2457 errors from 8 contexts (suppressed: 230276 from 41)
 9/11 Test #9: mir_unit_tests ............................***Failed 288.38 sec

So perhaps ThreadedDispatcherSignalTest is not the cause, but just a victim of these errors.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3194
http://jenkins.qa.ubuntu.com/job/mir-ci/5835/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-vivid-i386-build/5296
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-vivid-amd64-build/4202
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-vivid-touch/5245
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-xenial-touch/148/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/163
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-amd64-ci/163/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/163
        deb: http://jenkins.qa.ubuntu.com/job/mir-xenial-i386-ci/163/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5245
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-vivid-armhf/5245/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-touch/7766
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26006
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/146
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-xenial-armhf/146/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-xenial-touch/5/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26009

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-ci/5835/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

3194. By Daniel van Vugt

Merge latest trunk again; adds new suppressions from Cemil.

3193. By Daniel van Vugt

Ping Jenkins

3192. By Daniel van Vugt

Merge latest trunk

3191. By Daniel van Vugt

Try to avoid valgrind on ThreadedDispatcherSignalTest.* that's failing
all the time on xenial-armhf at least, apparently from unnamed valgrind
errors in its child process. This might work around LP: #1499229...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/MirCommon.cmake'
2--- cmake/MirCommon.cmake 2015-12-14 06:21:46 +0000
3+++ cmake/MirCommon.cmake 2015-12-14 06:40:34 +0000
4@@ -63,7 +63,7 @@
5
6 if(ENABLE_MEMCHECK_OPTION)
7 set(test_cmd ${VALGRIND_CMD} ${test_cmd_no_memcheck})
8- set(test_no_memcheck_filter "*DeathTest.*:ClientLatency.*")
9+ set(test_no_memcheck_filter "*DeathTest.*:ClientLatency.*:ThreadedDispatcherSignalTest.*")
10 endif()
11
12 if(cmake_build_type_lower MATCHES "threadsanitizer")

Subscribers

People subscribed via source and target branches