Mir

Merge lp:~vanvugt/mir/this-should-fail-1 into lp:mir

Proposed by Daniel van Vugt
Status: Rejected
Rejected by: Daniel van Vugt
Proposed branch: lp:~vanvugt/mir/this-should-fail-1
Merge into: lp:mir
Diff against target: 13 lines (+2/-1)
1 file modified
tests/performance-tests/test_glmark2-es2-mir.cpp (+2/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/this-should-fail-1
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Needs Fixing
Alan Griffiths Disapprove
Review via email: mp+291081@code.launchpad.net

Description of the change

Do not approve.

This should fail CI. Assuming we still run performance tests on at least one machine.

To post a comment you must log in.
Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3441
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~vanvugt/mir/this-should-fail-1/+merge/291081/+edit-commit-message

https://mir-jenkins.ubuntu.com/job/mir-ci/763/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/749/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/786
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/777
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/777
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/758
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/758/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/758
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/758/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/758/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/758/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/758
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/758/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/758
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/758/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/763/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Failing for the wrong reasons it seems.

lp:~vanvugt/mir/this-should-fail-1 updated
3442. By Daniel van Vugt

Merge latest trunk

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Fails for the expected reason too?

08:42:20 + phablet-test-run -x -s JB011018 -v sudo /usr/bin/mir_performance_tests
08:42:20 running sudo /usr/bin/mir_performance_tests
08:42:20 Running main() from main.cpp
08:42:20 [==========] Running 1 test from 1 test case.
08:42:20 [----------] Global test environment set-up.
08:42:20 [----------] 1 test from GLMark2Test
08:42:20 [ RUN ] GLMark2Test.fullscreen_default
08:42:20 [2016-04-06 08:42:20.454578] mirplatform: Found graphics driver: mir:android (version 0.22.0)
08:42:20 [2016-04-06 08:42:20.456125] mirplatform: Found graphics driver: mir:mesa-kms (version 0.22.0)
08:42:20 [2016-04-06 08:42:20.457692] mirplatform: Found graphics driver: mir:mesa-x11 (version 0.22.0)
08:42:20 [2016-04-06 08:42:20.458406] mirplatform: Found graphics driver: throw-on-creation (version 0.22.0)
08:42:20 [2016-04-06 08:42:20.458540] mirplatform: Found graphics driver: dummy (version 0.22.0)
08:42:20 libevdev error in fix_invalid_absinfo: BUG: Device "mtk-tpd" has invalid ABS_MT_TRACKING_ID rangeSaving GLMark2 detailed results to: /tmp/GLMark2Test_fullscreen_default.log
08:42:31 ../../../tests/performance-tests/test_glmark2-es2-mir.cpp:101: Failure
08:42:31 Value of: run_glmark2("--fullscreen")
08:42:31 Expected: is >= 9999999
08:42:31 Actual: 69 (of type int)
08:42:31 [ FAILED ] GLMark2Test.fullscreen_default (10783 ms)
08:42:31 [----------] 1 test from GLMark2Test (10784 ms total)
08:42:31
08:42:31 [----------] Global test environment tear-down
08:42:31 [==========] 1 test from 1 test case ran. (10784 ms total)
08:42:31 [ PASSED ] 0 tests.
08:42:31 [ FAILED ] 1 test, listed below:
08:42:31 [ FAILED ] GLMark2Test.fullscreen_default
08:42:31
08:42:31 1 FAILED TEST
08:42:31  YOU HAVE 5 DISABLED TESTS

https://mir-jenkins.ubuntu.com/job/device-runtests-mir/device_type=krillin/397/consoleFull

Revision history for this message
Alan Griffiths (alan-griffiths) :
review: Disapprove
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Where did you copy that text from? I can't find it.

Also, there should be failures on all amd64 and i386 systems too.

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

> Where did you copy that text from? I can't find it.

I pasted the link above.

> Also, there should be failures on all amd64 and i386 systems too.

In theory I agree. But that's not something we've ever had working. Some (all?) of those machines are unsuitable for tests that need real graphics.

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3442
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~vanvugt/mir/this-should-fail-1/+merge/291081/+edit-commit-message

https://mir-jenkins.ubuntu.com/job/mir-ci/767/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/756/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/793
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/784
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/784
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/765
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/765/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/765
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/765/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/765/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/765/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/765
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/765/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/765
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/765/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/767/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Yes indeed, thanks for the link:
   https://mir-jenkins.ubuntu.com/job/device-runtests-mir/device_type=krillin/397/consoleFull
But where did you get it from?

I thought we've always had at least one desktop running the performance tests. Although now that you mention it I only remember for certain them running on a droid (which unfortunately means most of them don't get run).

lp:~vanvugt/mir/this-should-fail-1 updated
3443. By Daniel van Vugt

Merge latest trunk

Revision history for this message
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3443
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~vanvugt/mir/this-should-fail-1/+merge/291081/+edit-commit-message

https://mir-jenkins.ubuntu.com/job/mir-ci/776/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/766/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/803
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/794
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/794
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/775
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/775
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/775/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/775/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/775
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/775/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/775
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/775/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/776/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Oh, found it eventually. Multiple levels of indirection.

Unmerged revisions

3443. By Daniel van Vugt

Merge latest trunk

3442. By Daniel van Vugt

Merge latest trunk

3441. By Daniel van Vugt

Sanity checking

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/performance-tests/test_glmark2-es2-mir.cpp'
2--- tests/performance-tests/test_glmark2-es2-mir.cpp 2016-03-23 06:39:56 +0000
3+++ tests/performance-tests/test_glmark2-es2-mir.cpp 2016-04-07 02:41:28 +0000
4@@ -97,7 +97,8 @@
5
6 TEST_F(GLMark2Test, fullscreen_default)
7 {
8- EXPECT_THAT(run_glmark2("--fullscreen"), ::testing::Ge(56));
9+ // XXX This should fail XXX
10+ EXPECT_THAT(run_glmark2("--fullscreen"), ::testing::Ge(9999999));
11 }
12
13 #ifdef ANDROID

Subscribers

People subscribed via source and target branches