Mir

Merge lp:~vanvugt/mir/test-1270964 into lp:mir

Proposed by Daniel van Vugt
Status: Rejected
Rejected by: Daniel van Vugt
Proposed branch: lp:~vanvugt/mir/test-1270964
Merge into: lp:mir
Diff against target: 22 lines (+15/-0)
1 file modified
tests/unit-tests/compositor/test_switching_bundle.cpp (+15/-0)
To merge this branch: bzr merge lp:~vanvugt/mir/test-1270964
Reviewer Review Type Date Requested Status
Alan Griffiths Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+202406@code.launchpad.net

Commit message

Add a regression test for LP: #1270964 (disabled till it's fixed)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'm not a fan of tests that fail by hanging. Especially on CI infrastructure.

review: Needs Fixing

Unmerged revisions

1341. By Daniel van Vugt

Add a regression test for LP: #1270964 (disabled till it's fixed)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unit-tests/compositor/test_switching_bundle.cpp'
2--- tests/unit-tests/compositor/test_switching_bundle.cpp 2014-01-13 06:12:33 +0000
3+++ tests/unit-tests/compositor/test_switching_bundle.cpp 2014-01-21 07:53:39 +0000
4@@ -869,3 +869,18 @@
5 }
6 }
7
8+TEST_F(SwitchingBundleTest, DISABLED_compositor_client_interleaved)
9+{ // Regression test for LP: #1270964
10+ int const nbuffers = 3;
11+ mc::SwitchingBundle bundle(nbuffers, allocator, basic_properties);
12+ mg::Buffer* client_buffer = nullptr;
13+
14+ client_buffer = bundle.client_acquire();
15+ bundle.client_release(client_buffer);
16+
17+ client_buffer = bundle.client_acquire();
18+ bundle.compositor_acquire(0);
19+ bundle.client_release(client_buffer);
20+
21+ client_buffer = bundle.client_acquire(); // <- locks here if in buggy state
22+}

Subscribers

People subscribed via source and target branches