Mir

Merge lp:~vanvugt/mir/server-abi-25 into lp:mir

Proposed by Daniel van Vugt
Status: Work in progress
Proposed branch: lp:~vanvugt/mir/server-abi-25
Merge into: lp:mir
Diff against target: 41 lines (+4/-4)
3 files modified
debian/control (+2/-2)
debian/libmirserver25.install (+1/-1)
src/server/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/server-abi-25
Reviewer Review Type Date Requested Status
Cemil Azizoglu (community) Needs Resubmitting
Daniel van Vugt Needs Resubmitting
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+230039@code.launchpad.net

Commit message

Bump MIRSERVER_ABI to 25. Since branching 0.6 we've broken the server ABI
by public header changes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Since we haven't released 0.6, and due to traincon-0, I'd like to resync 0.6 with devel.

Release landing is a time-consuming process and we fight with other silos to land our ABI breaking changes (e.g. qtmir is in 3 silos landings for which have to be serialized). So I'd like to add as much content as possible, before we have actually gotten to a point where we have tested and ready to land the release. Once we have done comprehensive testing, it's a different story, but we 're not there yet. Currently, we will need to rebuild (and test) due to other landings that will take place before Mir lands.

Thanks.

review: Disapprove
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Verified lp:mir/0.6 r1840 just got devel r1831 merged into it. That means we're redefining what "ABI 24" means to be what's in devel up to r1831. So this proposal doesn't need to land right now. It will be needed after the _next_ server ABI break though.

review: Needs Resubmitting
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Yes we'll need this after the next ABI break (and after the release is over).

review: Needs Resubmitting

Unmerged revisions

1833. By Daniel van Vugt

Remember the contents of debian/libmirserver25.install

1832. By Daniel van Vugt

Bump MIRSERVER_ABI to 25. Since branching 0.6 we've broken the server ABI
by public header changes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-08-07 08:43:25 +0000
3+++ debian/control 2014-08-08 04:06:58 +0000
4@@ -44,7 +44,7 @@
5 # just go ahead. ~mir-team will notice and sync up the code again.
6 Vcs-Bzr: https://code.launchpad.net/~mir-team/mir/trunk
7
8-Package: libmirserver24
9+Package: libmirserver25
10 Section: libs
11 Architecture: i386 amd64 armhf arm64
12 Multi-Arch: same
13@@ -141,7 +141,7 @@
14 Architecture: i386 amd64 armhf arm64
15 Multi-Arch: same
16 Pre-Depends: ${misc:Pre-Depends}
17-Depends: libmirserver24 (= ${binary:Version}),
18+Depends: libmirserver25 (= ${binary:Version}),
19 libmirplatform-dev (= ${binary:Version}),
20 libmircommon-dev (= ${binary:Version}),
21 libglm-dev,
22
23=== renamed file 'debian/libmirserver24.install' => 'debian/libmirserver25.install'
24--- debian/libmirserver24.install 2014-07-30 15:25:54 +0000
25+++ debian/libmirserver25.install 2014-08-08 04:06:58 +0000
26@@ -1,1 +1,1 @@
27-usr/lib/*/libmirserver.so.24
28+usr/lib/*/libmirserver.so.25
29
30=== modified file 'src/server/CMakeLists.txt'
31--- src/server/CMakeLists.txt 2014-08-07 08:43:42 +0000
32+++ src/server/CMakeLists.txt 2014-08-08 04:06:58 +0000
33@@ -79,7 +79,7 @@
34 )
35 endif()
36
37-set(MIRSERVER_ABI 24) # Be sure to increment MIR_VERSION_MINOR at the same time
38+set(MIRSERVER_ABI 25) # Be sure to increment MIR_VERSION_MINOR at the same time
39
40 set_target_properties(
41 mirserver

Subscribers

People subscribed via source and target branches