Mir

Merge lp:~vanvugt/mir/series-0.28 into lp:mir

Proposed by Daniel van Vugt on 2017-05-26
Status: Rejected
Rejected by: Daniel van Vugt on 2017-05-29
Proposed branch: lp:~vanvugt/mir/series-0.28
Merge into: lp:mir
Diff against target: 12 lines (+1/-1)
1 file modified
CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~vanvugt/mir/series-0.28
Reviewer Review Type Date Requested Status
Alan Griffiths 2017-05-26 Disapprove on 2017-05-26
Mir CI Bot continuous-integration Approve on 2017-05-26
Review via email: mp+324652@code.launchpad.net

Commit message

Clarify this is the 0.28 series.

Description of the change

To post a comment you must log in.
Daniel van Vugt (vanvugt) wrote :

Although it looks like there might be a plan to re-branch 0.27. Nothing wrong with that, but you shouldn't assign 0.28 bugs back to 0.27 until after the branch situation has changed formally in launchpad. And it hasn't yet...

https://launchpad.net/mir/0.27
https://launchpad.net/mir

Mir CI Bot (mir-ci-bot) wrote :

PASSED: Continuous integration, rev:4177
https://mir-jenkins.ubuntu.com/job/mir-ci/3418/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/4652
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/4785
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=artful/4775
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/4775
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=zesty/4775
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=artful/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=zesty/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=artful/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=zesty/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=artful/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=mesa,release=zesty/4688/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4688
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/4688/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/3418/rebuild

review: Approve (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

> Although it looks like there might be a plan to re-branch 0.27. Nothing wrong
> with that, but you shouldn't assign 0.28 bugs back to 0.27 until after the
> branch situation has changed formally in launchpad. And it hasn't yet...
>
> https://launchpad.net/mir/0.27
> https://launchpad.net/mir

We're not quite ready to rebranch 0.27, but that is the plan

review: Disapprove

Unmerged revisions

4177. By Daniel van Vugt on 2017-05-26

Series 0.28

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2017-05-08 03:04:26 +0000
3+++ CMakeLists.txt 2017-05-26 02:16:42 +0000
4@@ -28,7 +28,7 @@
5 set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
6
7 set(MIR_VERSION_MAJOR 0)
8-set(MIR_VERSION_MINOR 27)
9+set(MIR_VERSION_MINOR 28)
10 set(MIR_VERSION_PATCH 0)
11
12 add_definitions(-DMIR_VERSION_MAJOR=${MIR_VERSION_MAJOR})

Subscribers

People subscribed via source and target branches