lp:~vanvugt/mir/safer-page-flip-callbacks

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

PS Jenkins bot (community): Approve (continuous-integration) on 2014-01-28

Alan Griffiths: Disapprove on 2014-01-28

Alexandros Frantzis (community): Disapprove on 2014-01-28

Diff: 54 lines (+10/-4)

2 files modified

src/platform/graphics/mesa/kms_page_flipper.cpp (+4/-2)
src/platform/graphics/mesa/kms_page_flipper.h (+6/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1361. By Daniel van Vugt on 2014-01-28

Initialize on construction

1360. By Daniel van Vugt on 2014-01-28

Improve the thread safety of page flip callbacks, ensuring we don't pass
drmModePageFlip a pointer that could be invalidated by resizing of the
pending_page_flips map.

I don't have proof this has caused any crashes yet, but it could in theory
(with multiple monitors) so we should fix it.

1359. By Alexandros Frantzis on 2014-01-27

client: Add basic MirOutputCapture class.

Approved by PS Jenkins bot, Andreas Pokorny, Alan Griffiths, Kevin DuBois.

1358. By Kevin DuBois on 2014-01-27

fix integration test failure on the galaxy nexus that was due to creating two surfaces and registering the same buffer twice

fixes: lp: #1272597. Fixes: https://bugs.launchpad.net/bugs/1272597.

Approved by Alan Griffiths, Andreas Pokorny, PS Jenkins bot.

1357. By Alexandros Frantzis on 2014-01-24

client: Don't create mesa ClientBuffer objects from invalid MirBufferPackages.

Approved by PS Jenkins bot, Alan Griffiths.

1356. By Daniel van Vugt on 2014-01-24

Optimize surface resizing to avoid doing anything if the dimensions are
unchanged. At the buffer bundle level we already avoid unnecessary buffer
reallocations. However this proposal also ensures MirResizeEvent is not
emitted unless the dimensions have changed. Some input devices will result
in many duplicate resize requests being generated, so best to ignore the
ones you don't need, and minimize the resulting event traffic to clients.

Approved by Alexandros Frantzis, Alan Griffiths, PS Jenkins bot, Andreas Pokorny.

1355. By Alexandros Frantzis on 2014-01-24

examples, doc: Make it clear and consistent how to use a non-root client with a root compositor endpoint. Fixes: https://bugs.launchpad.net/bugs/1272143.

Approved by PS Jenkins bot, Alexandros Frantzis, Andreas Pokorny.

1354. By Daniel van Vugt on 2014-01-24

Avoid linking to umockdev on platforms (android) which don't yet use it.
This allows mir_unit_tests to run on touch images again (LP: #1271434)
. Fixes: https://bugs.launchpad.net/bugs/1271434.

Approved by Alan Griffiths, PS Jenkins bot.

1353. By Andreas Pokorny on 2014-01-24

Workaround for N4 nested server issue. This change removes mir_pixel_format_bgr_888 - HAL_PIXEL_FORMAT_RGB_888 from the list of supported pixel formats on android. (LP:#1272041)

. Fixes: https://bugs.launchpad.net/bugs/1272041.

Approved by Alan Griffiths, Daniel van Vugt, PS Jenkins bot.

1352. By Daniel van Vugt on 2014-01-23

Don't ask glUniformMatrix4fv to transpose your matrix. That option was
officially deprecated between OpenGL and OpenGL|ES. And some drivers
like the Nexus 10 don't implement it, resulting in incorrect transformations
and even nothing on screen! (LP: #1271853)
. Fixes: https://bugs.launchpad.net/bugs/1271853.

Approved by Kevin DuBois, PS Jenkins bot, Alexandros Frantzis.